zebra: resolve issue with protocol route-map not applied properly

[dslicenc]

Problem reported that route-maps applied to "ip protocol table bgp"
would not be invoked if the ip protocol table command was issued
after the bgp prefixes were installed. Found that a recent change
improving how often nexthop_active_update runs missed causing this
filtering to be applied. This fix resolves that issue as well as
a couple of other places that were problematic with the recent
change.

Signed-off-by: Don Slice dslice@cumulusnetworks.com

[LabN-CI]

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/4209 32e4bec
Date	04/26/2019
Start	09:15:20
Finish	09:39:13
Run-Time	23:53
Total	1816
Pass	1816
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-04-26-09:15:20.txt
Log	autoscript-2019-04-26-09:16:08.log.bz2
Memory	448 437 374

For details, please contact louberger

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7374/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

---

CLANG Static Analyzer Summary

• Github Pull Request 4209, comparing to Git base SHA ee02d38

New warnings:

• Logic error: Dereference of null pointer in zebra/zebra_rib.c, function rib_lookup_and_pushup, line 2697
  • See https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7374/artifact/shared/static_analysis/report-86feb0.html#EndPath

Static Analysis warning summary compared to base:

• Fixed warnings: 0
• New warnings: 1

13 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7374/artifact/shared/static_analysis/index.html

[dslicenc]

new static analysis working, so taking a look. Definitely a legitimate catch. Fixing it now

[LabN-CI]

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/4209 8225f85
Date	04/26/2019
Start	11:15:19
Finish	11:39:07
Run-Time	23:48
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-04-26-11:15:19.txt
Log	autoscript-2019-04-26-11:16:02.log.bz2
Memory	440 449 374

For details, please contact louberger

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7379/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

---

CLANG Static Analyzer Summary

• Github Pull Request 4209, comparing to Git base SHA 65c9079
• Base image data for Git 65c9079 does not exist - compare skipped

12 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7379/artifact/shared/static_analysis/index.html

[mjstapp]

just had the one white-space nit

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7382/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

---

CLANG Static Analyzer Summary

• Github Pull Request 4209, comparing to Git base SHA 65c9079

No Changes in Static Analysis warnings compared to base

12 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7382/artifact/shared/static_analysis/index.html

[LabN-CI]

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/4209 ade4a88
Date	04/26/2019
Start	14:00:20
Finish	14:24:02
Run-Time	23:42
Total	1816
Pass	1816
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-04-26-14:00:20.txt
Log	autoscript-2019-04-26-14:01:05.log.bz2
Memory	447 444 374

For details, please contact louberger