Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zebra: resolve issue with protocol route-map not applied properly #4209

Merged
merged 1 commit into from
Apr 26, 2019

Conversation

dslicenc
Copy link
Member

Problem reported that route-maps applied to "ip protocol table bgp"
would not be invoked if the ip protocol table command was issued
after the bgp prefixes were installed. Found that a recent change
improving how often nexthop_active_update runs missed causing this
filtering to be applied. This fix resolves that issue as well as
a couple of other places that were problematic with the recent
change.

Signed-off-by: Don Slice dslice@cumulusnetworks.com

@LabN-CI
Copy link
Collaborator

LabN-CI commented Apr 26, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/4209 32e4bec
Date 04/26/2019
Start 09:15:20
Finish 09:39:13
Run-Time 23:53
Total 1816
Pass 1816
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-04-26-09:15:20.txt
Log autoscript-2019-04-26-09:16:08.log.bz2
Memory 448 437 374

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7374/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.


CLANG Static Analyzer Summary

  • Github Pull Request 4209, comparing to Git base SHA ee02d38

New warnings:

Static Analysis warning summary compared to base:

  • Fixed warnings: 0
  • New warnings: 1

13 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7374/artifact/shared/static_analysis/index.html

@dslicenc
Copy link
Member Author

dslicenc commented Apr 26, 2019

new static analysis working, so taking a look. Definitely a legitimate catch. Fixing it now

@dslicenc dslicenc force-pushed the zebra-nexthop-update-flag branch from 32e4bec to 8225f85 Compare April 26, 2019 15:13
@LabN-CI
Copy link
Collaborator

LabN-CI commented Apr 26, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/4209 8225f85
Date 04/26/2019
Start 11:15:19
Finish 11:39:07
Run-Time 23:48
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-04-26-11:15:19.txt
Log autoscript-2019-04-26-11:16:02.log.bz2
Memory 440 449 374

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7379/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.


CLANG Static Analyzer Summary

  • Github Pull Request 4209, comparing to Git base SHA 65c9079
  • Base image data for Git 65c9079 does not exist - compare skipped

12 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7379/artifact/shared/static_analysis/index.html

Copy link
Contributor

@mjstapp mjstapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just had the one white-space nit

@qlyoung qlyoung added the bugfix label Apr 26, 2019
Problem reported that route-maps applied to "ip protocol table bgp"
would not be invoked if the ip protocol table command was issued
after the bgp prefixes were installed.  Found that a recent change
improving how often nexthop_active_update runs missed causing this
filtering to be applied. This fix resolves that issue as well as
a couple of other places that were problematic with the recent
change.

Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
@dslicenc dslicenc force-pushed the zebra-nexthop-update-flag branch from 8225f85 to ade4a88 Compare April 26, 2019 17:17
@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7382/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.


CLANG Static Analyzer Summary

  • Github Pull Request 4209, comparing to Git base SHA 65c9079

No Changes in Static Analysis warnings compared to base

12 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7382/artifact/shared/static_analysis/index.html

@LabN-CI
Copy link
Collaborator

LabN-CI commented Apr 26, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/4209 ade4a88
Date 04/26/2019
Start 14:00:20
Finish 14:24:02
Run-Time 23:42
Total 1816
Pass 1816
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-04-26-14:00:20.txt
Log autoscript-2019-04-26-14:01:05.log.bz2
Memory 447 444 374

For details, please contact louberger

@mjstapp mjstapp merged commit 86336f6 into FRRouting:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants