Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zebra: Add hidden 'show frr' command #4130

Merged
merged 1 commit into from
Apr 14, 2019

Conversation

donaldsharp
Copy link
Member

Signed-off-by: Donald Sharp sharpd@cumulusnetworks.com

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Copy link
Member

@sworleys sworleys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@LabN-CI
Copy link
Collaborator

LabN-CI commented Apr 12, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/4130 d2f5903
Date 04/12/2019
Start 10:30:17
Finish 10:54:21
Run-Time 24:04
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-04-12-10:30:17.txt
Log autoscript-2019-04-12-10:31:17.log.bz2
Memory 502 500 429

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7232/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for zebra_vty.c | 106 issues
===============================================
< WARNING: line over 80 characters
< #2861: FILE: /tmp/f1-24709/zebra_vty.c:2861:
< WARNING: line over 80 characters
< #2862: FILE: /tmp/f1-24709/zebra_vty.c:2862:
< WARNING: line over 80 characters
< #2863: FILE: /tmp/f1-24709/zebra_vty.c:2863:
< WARNING: line over 80 characters
< #2864: FILE: /tmp/f1-24709/zebra_vty.c:2864:
< WARNING: line over 80 characters
< #2865: FILE: /tmp/f1-24709/zebra_vty.c:2865:
< WARNING: line over 80 characters
< #2866: FILE: /tmp/f1-24709/zebra_vty.c:2866:
< WARNING: line over 80 characters
< #2867: FILE: /tmp/f1-24709/zebra_vty.c:2867:
< WARNING: line over 80 characters
< #2868: FILE: /tmp/f1-24709/zebra_vty.c:2868:
< WARNING: line over 80 characters
< #2869: FILE: /tmp/f1-24709/zebra_vty.c:2869:
< WARNING: line over 80 characters
< #2870: FILE: /tmp/f1-24709/zebra_vty.c:2870:
< WARNING: line over 80 characters
< #2871: FILE: /tmp/f1-24709/zebra_vty.c:2871:
< WARNING: line over 80 characters
< #2872: FILE: /tmp/f1-24709/zebra_vty.c:2872:
< WARNING: line over 80 characters
< #2873: FILE: /tmp/f1-24709/zebra_vty.c:2873:
< WARNING: line over 80 characters
< #2874: FILE: /tmp/f1-24709/zebra_vty.c:2874:
< WARNING: line over 80 characters
< #2875: FILE: /tmp/f1-24709/zebra_vty.c:2875:
< WARNING: line over 80 characters
< #2876: FILE: /tmp/f1-24709/zebra_vty.c:2876:
< WARNING: line over 80 characters
< #2877: FILE: /tmp/f1-24709/zebra_vty.c:2877:
< WARNING: line over 80 characters
< #2878: FILE: /tmp/f1-24709/zebra_vty.c:2878:
< WARNING: line over 80 characters
< #2879: FILE: /tmp/f1-24709/zebra_vty.c:2879:
< WARNING: line over 80 characters
< #2880: FILE: /tmp/f1-24709/zebra_vty.c:2880:
< WARNING: line over 80 characters
< #2881: FILE: /tmp/f1-24709/zebra_vty.c:2881:
< WARNING: line over 80 characters
< #2882: FILE: /tmp/f1-24709/zebra_vty.c:2882:
< WARNING: line over 80 characters
< #2883: FILE: /tmp/f1-24709/zebra_vty.c:2883:
< WARNING: line over 80 characters
< #2884: FILE: /tmp/f1-24709/zebra_vty.c:2884:
< WARNING: line over 80 characters
< #2885: FILE: /tmp/f1-24709/zebra_vty.c:2885:
< WARNING: line over 80 characters
< #2886: FILE: /tmp/f1-24709/zebra_vty.c:2886:
< WARNING: line over 80 characters
< #2887: FILE: /tmp/f1-24709/zebra_vty.c:2887:
< WARNING: line over 80 characters
< #2888: FILE: /tmp/f1-24709/zebra_vty.c:2888:
< WARNING: line over 80 characters
< #2889: FILE: /tmp/f1-24709/zebra_vty.c:2889:
< WARNING: line over 80 characters
< #2890: FILE: /tmp/f1-24709/zebra_vty.c:2890:
< WARNING: line over 80 characters
< #2891: FILE: /tmp/f1-24709/zebra_vty.c:2891:
< WARNING: line over 80 characters
< #2892: FILE: /tmp/f1-24709/zebra_vty.c:2892:
< WARNING: line over 80 characters
< #2893: FILE: /tmp/f1-24709/zebra_vty.c:2893:
< WARNING: line over 80 characters
< #2894: FILE: /tmp/f1-24709/zebra_vty.c:2894:
< WARNING: line over 80 characters
< #2895: FILE: /tmp/f1-24709/zebra_vty.c:2895:
< WARNING: line over 80 characters
< #2896: FILE: /tmp/f1-24709/zebra_vty.c:2896:
< WARNING: line over 80 characters
< #2897: FILE: /tmp/f1-24709/zebra_vty.c:2897:
< WARNING: line over 80 characters
< #2898: FILE: /tmp/f1-24709/zebra_vty.c:2898:
< WARNING: line over 80 characters
< #2899: FILE: /tmp/f1-24709/zebra_vty.c:2899:
< WARNING: line over 80 characters
< #2900: FILE: /tmp/f1-24709/zebra_vty.c:2900:
< WARNING: line over 80 characters
< #2901: FILE: /tmp/f1-24709/zebra_vty.c:2901:
< WARNING: line over 80 characters
< #2902: FILE: /tmp/f1-24709/zebra_vty.c:2902:
< WARNING: line over 80 characters
< #2903: FILE: /tmp/f1-24709/zebra_vty.c:2903:
< WARNING: line over 80 characters
< #2904: FILE: /tmp/f1-24709/zebra_vty.c:2904:
< WARNING: line over 80 characters
< #2905: FILE: /tmp/f1-24709/zebra_vty.c:2905:
< WARNING: line over 80 characters
< #2906: FILE: /tmp/f1-24709/zebra_vty.c:2906:
< WARNING: line over 80 characters
< #2907: FILE: /tmp/f1-24709/zebra_vty.c:2907:
< WARNING: line over 80 characters
< #2908: FILE: /tmp/f1-24709/zebra_vty.c:2908:
< WARNING: line over 80 characters
< #2909: FILE: /tmp/f1-24709/zebra_vty.c:2909:
< WARNING: line over 80 characters
< #2910: FILE: /tmp/f1-24709/zebra_vty.c:2910:
< WARNING: line over 80 characters
< #2911: FILE: /tmp/f1-24709/zebra_vty.c:2911:
< WARNING: line over 80 characters
< #2912: FILE: /tmp/f1-24709/zebra_vty.c:2912:
< WARNING: line over 80 characters
< #2913: FILE: /tmp/f1-24709/zebra_vty.c:2913:

CLANG Static Analyzer Summary

  • Github Pull Request 4130, comparing to Git base SHA f765a2f

No Changes in Static Analysis warnings compared to base

14 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7232/artifact/shared/static_analysis/index.html

@@ -2852,6 +2852,69 @@ static int config_write_forwarding(struct vty *vty)
return 0;
}

DEFUN_HIDDEN (show_frr,
show_frr_cmd,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why hidden?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its a secret

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just thinkint it would be fun to have this but not necessarily something that needs to be visible.
A nice little easter egg so to speak

Copy link
Member

@rwestphal rwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qlyoung added enhancement feature labels 5 hours ago

😂

@pguibert6WIND pguibert6WIND merged commit 45ec928 into FRRouting:master Apr 14, 2019
@donaldsharp donaldsharp deleted the show_frr branch April 30, 2019 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants