Binary Only Docker Image #3987

robgil · 2019-03-21T01:15:23Z

Summary

WIP
This is a build as well as docker image for FRR on top of a Debian base image.

Related Issue

TODO

Components

Docker

LabN-CI · 2019-03-21T01:44:17Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3987 `8f5d15a`
Date	03/20/2019
Start	21:20:14
Finish	21:44:05
Run-Time	23:51
Total	1816
Pass	1816
Fail	0
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2019-03-20-21:20:14.txt
Log	autoscript-2019-03-20-21:20:59.log.bz2
Memory	497 497 429

For details, please contact louberger

NetDEF-CI · 2019-03-21T02:21:13Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6978/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Ubuntu 18.04 amd64 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6978/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80

Ubuntu 14.04 amd64 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6978/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80

Debian 9 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6978/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr-rpki-rtrlib-dbgsym: package-has-long-file-name 72 (81) > 80

Ubuntu 16.04 amd64 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6978/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80

Ubuntu 16.04 i386 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6978/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr-rpki-rtrlib: package-has-long-file-name 71 (81) > 80

CLANG Static Analyzer Summary

Github Pull Request 3987, comparing to Git base SHA a6170d8

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6978/artifact/shared/static_analysis/index.html

- Adds yang models - Updates yang paths - Adds /var/run path for docker

robgil · 2019-03-21T02:34:45Z

Seems to start up, but never exits cleanly on start. Sending to the background to test

root@9c47c97f9f97:/# /usr/sbin/docker-start &
root@9c47c97f9f97:/# ps -ef
UID        PID  PPID  C STIME TTY          TIME CMD
root         1     0  0 02:12 pts/0    00:00:00 bash
root       287     0  0 02:27 pts/2    00:00:00 /bin/bash
root       295   287  0 02:28 pts/2    00:00:00 /bin/sh /usr/sbin/docker-start
root       297   295  0 02:28 pts/2    00:00:00 /bin/bash /etc/init.d/frr start
frr        310   297  1 02:28 pts/2    00:00:00 /usr/sbin/bgpd -A 127.0.0.1
root       313   287  0 02:28 pts/2    00:00:00 ps -ef

## This should be starting bgpd and bfdd but only bgpd is starting

## vtysh is working and connecting to the bgpd daemon
root@9c47c97f9f97:/# vtysh 

Hello, this is FRRouting (version 7.1-dev-MyOwnFRRVersion-g5d15abb-dirty).
Copyright 1996-2005 Kunihiro Ishiguro, et al.

This is a git build of frr-7.1-dev-157-g8f5d15abb-dirty
Associated branch(es):
	local:docker-debian-source
	git@github.com:robgil/frr.git/docker-debian-source

## Neighbors are showing
9c47c97f9f97# show bgp sum

IPv4 Unicast Summary:
BGP router identifier 0.0.0.0, local AS number 65000 vrf-id 0
BGP table version 0
RIB entries 0, using 0 bytes of memory
Peers 2, using 41 KiB of memory

Neighbor        V         AS MsgRcvd MsgSent   TblVer  InQ OutQ  Up/Down State/PfxRcd
10.10.10.1      4      65001       0       0        0    0    0    never       Active
10.10.10.2      4      65002       0       0        0    0    0    never       Active

Total number of neighbors 2

## bfdd doesn't seem to work
9c47c97f9f97# show bfd peers
bfdd is not running

daemons

bgpd=yes
ospfd=no
ospf6d=no
ripd=no
ripngd=no
isisd=no
pimd=no
ldpd=no
nhrpd=no
eigrpd=no
babeld=no
sharpd=no
pbrd=no
bfdd=yes
fabricd=no

#
# If this option is set the /etc/init.d/frr script automatically loads
# the config via "vtysh -b" when the servers are started.
# Check /etc/pam.d/frr if you intend to use "vtysh"!
#
vtysh_enable=yes
zebra_options="  -A 127.0.0.1 -s 90000000"
bgpd_options="   -A 127.0.0.1"
ospfd_options="  -A 127.0.0.1"
ospf6d_options=" -A ::1"
ripd_options="   -A 127.0.0.1"
ripngd_options=" -A ::1"
isisd_options="  -A 127.0.0.1"
pimd_options="   -A 127.0.0.1"
ldpd_options="   -A 127.0.0.1"
nhrpd_options="  -A 127.0.0.1"
eigrpd_options=" -A 127.0.0.1"
babeld_options=" -A 127.0.0.1"
sharpd_options=" -A 127.0.0.1"
pbrd_options="   -A 127.0.0.1"
staticd_options="-A 127.0.0.1"
bfdd_options="   -A 127.0.0.1"
fabricd_options="-A 127.0.0.1"

LabN-CI · 2019-03-21T02:54:11Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3987 `1abeae0`
Date	03/20/2019
Start	22:30:14
Finish	22:53:59
Run-Time	23:45
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-03-20-22:30:14.txt
Log	autoscript-2019-03-20-22:30:56.log.bz2
Memory	502 501 429

For details, please contact louberger

NetDEF-CI · 2019-03-21T03:32:09Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6979/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Ubuntu 18.04 amd64 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6979/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80

Ubuntu 14.04 amd64 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6979/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80

Debian 9 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6979/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr-rpki-rtrlib-dbgsym: package-has-long-file-name 72 (81) > 80

Ubuntu 16.04 amd64 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6979/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80

Ubuntu 16.04 i386 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6979/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr-rpki-rtrlib: package-has-long-file-name 71 (81) > 80

CLANG Static Analyzer Summary

Github Pull Request 3987, comparing to Git base SHA a6170d8

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6979/artifact/shared/static_analysis/index.html

eqvinox · 2019-03-23T11:38:37Z

This is using the old init script (and I rather not create another copy of it in the repo :/)

robgil · 2019-03-23T12:16:49Z

@eqvinox no worries, which init script should I use?

Also in terms of copying things around, i'll update the build.sh to copy the file andd make the relevant path changes.

eqvinox · 2019-03-23T12:54:02Z

@robgil tools/{frrinit,frrcommon,watchfrr}.sh

Also I think we should use integrated config since that's the default if no config exists. (I.e. don't create the per-daemon config files.) Also-also, /usr/local/lib/libyang isn't needed with the libyang version that is in debian buster, we could just use that (it can be installed on debian stretch without problems).

qlyoung · 2019-03-25T20:40:19Z

+1 for integrated config.

qlyoung · 2019-04-21T20:44:36Z

@robgil any progress on this?

robgil · 2019-04-21T20:59:01Z

Sorry haven't had a chance. It's lambing season but should be over soon and can get back to it.

…

On Sun, Apr 21, 2019, 4:44 PM Quentin Young ***@***.***> wrote: @robgil <https://github.com/robgil> any progress on this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3987 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJTC42AX7GZUYDVFZ2SKVTPRTG33ANCNFSM4HACHOIA> .

LabN-CI · 2019-05-25T02:34:13Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3987 `1abeae0`
Date	05/24/2019
Start	22:11:09
Finish	22:33:56
Run-Time	22:47
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-05-24-22:11:09.txt
Log	autoscript-2019-05-24-22:12:13.log.bz2
Memory	432 436 360

For details, please contact louberger

robgil · 2019-06-11T19:43:47Z

Closing this out in favor of a simpler binary only PR based on Debian buster.

robgil added 2 commits March 20, 2019 22:30

Adds Docker debian source build

5556ffe

Getting closer

8f5d15a

robgil added 2 commits March 21, 2019 02:23

Add the rest of the expected files - they do not auto create

fa9c44c

Multiple yang changes

1abeae0

- Adds yang models - Updates yang paths - Adds /var/run path for docker

qlyoung self-assigned this Mar 21, 2019

qlyoung added the docker label Mar 26, 2019

robgil closed this Jun 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Binary Only Docker Image #3987

Binary Only Docker Image #3987

robgil commented Mar 21, 2019

LabN-CI commented Mar 21, 2019

NetDEF-CI commented Mar 21, 2019

robgil commented Mar 21, 2019

LabN-CI commented Mar 21, 2019

NetDEF-CI commented Mar 21, 2019

eqvinox commented Mar 23, 2019

robgil commented Mar 23, 2019

eqvinox commented Mar 23, 2019

qlyoung commented Mar 25, 2019

qlyoung commented Apr 21, 2019

robgil commented Apr 21, 2019 via email

LabN-CI commented May 25, 2019

robgil commented Jun 11, 2019

Binary Only Docker Image #3987

Binary Only Docker Image #3987

Conversation

robgil commented Mar 21, 2019

Summary

Related Issue

Components

LabN-CI commented Mar 21, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Mar 21, 2019

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

robgil commented Mar 21, 2019

LabN-CI commented Mar 21, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Mar 21, 2019

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

eqvinox commented Mar 23, 2019

robgil commented Mar 23, 2019

eqvinox commented Mar 23, 2019

qlyoung commented Mar 25, 2019

qlyoung commented Apr 21, 2019

robgil commented Apr 21, 2019 via email

LabN-CI commented May 25, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

robgil commented Jun 11, 2019