staticd: Fix SRv6 SID installation and deletion (backport #18064) #18152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
The SRv6 support in staticd (PR #16894) does not set the correct SID parameters (block length, node length, function length). This commit fixes the issue and computes the correct parameters. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com> (cherry picked from commit e1654ba) # Conflicts: # staticd/static_zebra.c
The `show ipv6 route json` command displays the IPv6 routing table in JSON format, including SRv6 SIDs. For each SRv6 SID, it provides behavior and SID attributes. However, it does not include the SID structure. This commit adds the SID structure to the SRv6 SID JSON output. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com> (cherry picked from commit 312f7b3)
The `static_srv6_sids` topotest verifies that staticd correctly programs the SIDs in the zebra RIB. Currently, the topotest only validates the programmed behavior and SID attributes. This commit extends the topotest to also validate the SID structure. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com> (cherry picked from commit a6d02fe) # Conflicts: # tests/topotests/static_srv6_sids/expected_srv6_sids.json # tests/topotests/static_srv6_sids/expected_srv6_sids_sid_delete_1.json # tests/topotests/static_srv6_sids/expected_srv6_sids_sid_delete_2.json
|
Cherry-pick of e1654ba has failed: Cherry-pick of a6d02fe has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
FRR 10.2 does not have SRv6 support in staticd. This fix is not applicable to 10.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SRv6 support in staticd (PR #16894) does not set the correct SID parameters (block length, node length, function length).
This PR fixes the issue and computes the correct parameters.
The bug was reported by SONiC testing.
This is an automatic backport of pull request #18064 done by Mergify.