staticd: Fix wrong xpath in no sid X:X::X:X/M
#17989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user wants to delete a specific SRv6 SID, he executes the `no sid X:X::X:X/M` command. However, by mistake, in addition to deleting the SID requested by the user, this command also removes all other SIDs. This happens because `no sid X:X::X:X/M` triggers a destroy operation on the wrong xpath `frr-staticd:staticd/segment-routing/srv6`. This commit fixes the issue by replacing the wrong xpath `frr-staticd:staticd/segment-routing/srv6` with the correct xpath `frr-staticd:staticd/segment-routing/srv6/static-sids/sid[sid='%s']`. This ensures that the `no sid X:X::X:X/M` command only deletes the SID that was requested by the user. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
Add a new test case that deletes a SID and verifies that only this SID has been removed from the RIB. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
Add a new test case that re-add the deleted SIDs and verifies that all SIDs are added back to the RIB. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user wants to delete a specific SRv6 SID, he executes the
no sid X:X::X:X/Mcommand.However, by mistake, in addition to deleting the SID requested by the user, this command also removes all other SIDs.
This happens because
no sid X:X::X:X/Mtriggers a destroy operation on the wrong xpathfrr-staticd:staticd/segment-routing/srv6.This commit fixes the issue by replacing the wrong xpath
frr-staticd:staticd/segment-routing/srv6with the correct xpathfrr-staticd:staticd/segment-routing/srv6/static-sids/sid[sid='%s'].This ensures that the
no sid X:X::X:X/Mcommand only deletes the SID that was requested by the user.