ldpd: changes for code maintainability #13742

sri-mohan1 · 2023-06-08T17:53:16Z

these changes are for improving the code maintainability and readability

NetDEF-CI · 2023-06-08T22:22:24Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12149/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Addresssanitizer topotests part 9: Failed (click for details)

## Error: heap-use-after-free

### AddressSanitizer error in topotest `common_config.py`, test `check_router_status`, router `r0`

    ERROR: AddressSanitizer: heap-use-after-free on address 0x60c000049b78 at pc 0x564d89f20565 bp 0x7ffef21acbc0 sp 0x7ffef21acbb0
    READ of size 4 at 0x60c000049b78 thread T0
        #0 0x564d89f20564 in ospf_lsa_lock ospfd/ospf_lsa.c:262
        #1 0x564d8a01c760 in ospf_flood_delayed_lsa_ack ospfd/ospf_flood.c:130
        #2 0x564d8a01c760 in ospf_flood ospfd/ospf_flood.c:537
        #3 0x564d89f58d14 in ospf_ls_upd ospfd/ospf_packet.c:2115
        #4 0x564d89f58d14 in ospf_read_helper ospfd/ospf_packet.c:3198
        #5 0x564d89f58d14 in ospf_read ospfd/ospf_packet.c:3229
        #6 0x564d8a152958 in event_call lib/event.c:1995
        #7 0x564d8a0986ce in frr_run lib/libfrr.c:1213
        #8 0x564d89efe6a4 in main ospfd/ospf_main.c:220
        #9 0x7f2fb7617c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #10 0x564d89efe159 in _start (/usr/lib/frr/ospfd+0x2e1159)
    
    0x60c000049b78 is located 56 bytes inside of 128-byte region [0x60c000049b40,0x60c000049bc0)
    freed by thread T0 here:
        #0 0x7f2fb8dbb7a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8)
        #1 0x564d8a0b5e36 in qfree lib/memory.c:130
        #2 0x564d89f20925 in ospf_lsa_free ospfd/ospf_lsa.c:256
        #3 0x564d89f20a2e in ospf_lsa_unlock ospfd/ospf_lsa.c:279
        #4 0x564d89f327ea in ospf_lsdb_delete_entry ospfd/ospf_lsdb.c:101
        #5 0x564d89f32cfe in ospf_lsdb_add ospfd/ospf_lsdb.c:124
        #6 0x564d89f2b822 in ospf_lsa_install ospfd/ospf_lsa.c:3041
        #7 0x564d89f2f5aa in ospf_router_lsa_refresh ospfd/ospf_lsa.c:916
        #8 0x564d89f2f5aa in ospf_lsa_refresh ospfd/ospf_lsa.c:4003
        #9 0x564d89f30b1f in ospf_refresh_area_self_lsas ospfd/ospf_lsa.c:3777
        #10 0x564d8a01c655 in ospf_flood ospfd/ospf_flood.c:529
        #11 0x564d89f58d14 in ospf_ls_upd ospfd/ospf_packet.c:2115
        #12 0x564d89f58d14 in ospf_read_helper ospfd/ospf_packet.c:3198
        #13 0x564d89f58d14 in ospf_read ospfd/ospf_packet.c:3229
        #14 0x564d8a152958 in event_call lib/event.c:1995
        #15 0x564d8a0986ce in frr_run lib/libfrr.c:1213
        #16 0x564d89efe6a4 in main ospfd/ospf_main.c:220
        #17 0x7f2fb7617c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    previously allocated by thread T0 here:
        #0 0x7f2fb8dbbd28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
        #1 0x564d8a0b54a2 in qcalloc lib/memory.c:105
        #2 0x564d89f2027e in ospf_lsa_new ospfd/ospf_lsa.c:186
        #3 0x564d89f20588 in ospf_lsa_new_and_data ospfd/ospf_lsa.c:205
        #4 0x564d89f56f86 in ospf_ls_upd_list_lsa ospfd/ospf_packet.c:1797
        #5 0x564d89f56f86 in ospf_ls_upd ospfd/ospf_packet.c:1882
        #6 0x564d89f56f86 in ospf_read_helper ospfd/ospf_packet.c:3198
        #7 0x564d89f56f86 in ospf_read ospfd/ospf_packet.c:3229
        #8 0x564d8a152958 in event_call lib/event.c:1995
        #9 0x564d8a0986ce in frr_run lib/libfrr.c:1213
        #10 0x564d89efe6a4 in main ospfd/ospf_main.c:220
        #11 0x7f2fb7617c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    SUMMARY: AddressSanitizer: heap-use-after-free ospfd/ospf_lsa.c:262 in ospf_lsa_lock
    Shadow bytes around the buggy address:
      0x0c1880001310: 00 00 00 00 00 00 00 00 fa fa fa fa fa fa fa fa
      0x0c1880001320: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fa
      0x0c1880001330: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00
      0x0c1880001340: 00 00 00 00 00 00 00 00 fa fa fa fa fa fa fa fa
      0x0c1880001350: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fa
    =>0x0c1880001360: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd[fd]
      0x0c1880001370: fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa
      0x0c1880001380: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
      0x0c1880001390: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00
      0x0c18800013a0: 00 00 00 00 00 00 00 00 fa fa fa fa fa fa fa fa
      0x0c18800013b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
    Shadow byte legend (one shadow byte represents 8 application bytes):
      Addressable:           00
      Partially addressable: 01 02 03 04 05 06 07 
      Heap left redzone:       fa
      Freed heap region:       fd
      Stack left redzone:      f1
      Stack mid redzone:       f2
      Stack right redzone:     f3
      Stack after return:      f5
      Stack use after scope:   f8
      Global redzone:          f9
      Global init order:       f6
      Poisoned by user:        f7
      Container overflow:      fc
      Array cookie:            ac
      Intra object redzone:    bb
      ASan internal:           fe
      Left alloca redzone:     ca
      Right alloca redzone:    cb

---------------
## Error: heap-use-after-free

### AddressSanitizer error in topotest `test_ospf_flood_reduction.py`, test `teardown_module`, router `r0`

    ERROR: AddressSanitizer: heap-use-after-free on address 0x60c000049b78 at pc 0x564d89f20565 bp 0x7ffef21acbc0 sp 0x7ffef21acbb0
    READ of size 4 at 0x60c000049b78 thread T0
        #0 0x564d89f20564 in ospf_lsa_lock ospfd/ospf_lsa.c:262
        #1 0x564d8a01c760 in ospf_flood_delayed_lsa_ack ospfd/ospf_flood.c:130
        #2 0x564d8a01c760 in ospf_flood ospfd/ospf_flood.c:537
        #3 0x564d89f58d14 in ospf_ls_upd ospfd/ospf_packet.c:2115
        #4 0x564d89f58d14 in ospf_read_helper ospfd/ospf_packet.c:3198
        #5 0x564d89f58d14 in ospf_read ospfd/ospf_packet.c:3229
        #6 0x564d8a152958 in event_call lib/event.c:1995
        #7 0x564d8a0986ce in frr_run lib/libfrr.c:1213
        #8 0x564d89efe6a4 in main ospfd/ospf_main.c:220
        #9 0x7f2fb7617c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
        #10 0x564d89efe159 in _start (/usr/lib/frr/ospfd+0x2e1159)
    
    0x60c000049b78 is located 56 bytes inside of 128-byte region [0x60c000049b40,0x60c000049bc0)
    freed by thread T0 here:
        #0 0x7f2fb8dbb7a8 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xde7a8)
        #1 0x564d8a0b5e36 in qfree lib/memory.c:130
        #2 0x564d89f20925 in ospf_lsa_free ospfd/ospf_lsa.c:256
        #3 0x564d89f20a2e in ospf_lsa_unlock ospfd/ospf_lsa.c:279
        #4 0x564d89f327ea in ospf_lsdb_delete_entry ospfd/ospf_lsdb.c:101
        #5 0x564d89f32cfe in ospf_lsdb_add ospfd/ospf_lsdb.c:124
        #6 0x564d89f2b822 in ospf_lsa_install ospfd/ospf_lsa.c:3041
        #7 0x564d89f2f5aa in ospf_router_lsa_refresh ospfd/ospf_lsa.c:916
        #8 0x564d89f2f5aa in ospf_lsa_refresh ospfd/ospf_lsa.c:4003
        #9 0x564d89f30b1f in ospf_refresh_area_self_lsas ospfd/ospf_lsa.c:3777
        #10 0x564d8a01c655 in ospf_flood ospfd/ospf_flood.c:529
        #11 0x564d89f58d14 in ospf_ls_upd ospfd/ospf_packet.c:2115
        #12 0x564d89f58d14 in ospf_read_helper ospfd/ospf_packet.c:3198
        #13 0x564d89f58d14 in ospf_read ospfd/ospf_packet.c:3229
        #14 0x564d8a152958 in event_call lib/event.c:1995
        #15 0x564d8a0986ce in frr_run lib/libfrr.c:1213
        #16 0x564d89efe6a4 in main ospfd/ospf_main.c:220
        #17 0x7f2fb7617c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    previously allocated by thread T0 here:
        #0 0x7f2fb8dbbd28 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xded28)
        #1 0x564d8a0b54a2 in qcalloc lib/memory.c:105
        #2 0x564d89f2027e in ospf_lsa_new ospfd/ospf_lsa.c:186
        #3 0x564d89f20588 in ospf_lsa_new_and_data ospfd/ospf_lsa.c:205
        #4 0x564d89f56f86 in ospf_ls_upd_list_lsa ospfd/ospf_packet.c:1797
        #5 0x564d89f56f86 in ospf_ls_upd ospfd/ospf_packet.c:1882
        #6 0x564d89f56f86 in ospf_read_helper ospfd/ospf_packet.c:3198
        #7 0x564d89f56f86 in ospf_read ospfd/ospf_packet.c:3229
        #8 0x564d8a152958 in event_call lib/event.c:1995
        #9 0x564d8a0986ce in frr_run lib/libfrr.c:1213
        #10 0x564d89efe6a4 in main ospfd/ospf_main.c:220
        #11 0x7f2fb7617c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    
    SUMMARY: AddressSanitizer: heap-use-after-free ospfd/ospf_lsa.c:262 in ospf_lsa_lock
    Shadow bytes around the buggy address:
      0x0c1880001310: 00 00 00 00 00 00 00 00 fa fa fa fa fa fa fa fa
      0x0c1880001320: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fa
      0x0c1880001330: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00
      0x0c1880001340: 00 00 00 00 00 00 00 00 fa fa fa fa fa fa fa fa
      0x0c1880001350: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fa
    =>0x0c1880001360: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd[fd]
      0x0c1880001370: fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa
      0x0c1880001380: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
      0x0c1880001390: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00
      0x0c18800013a0: 00 00 00 00 00 00 00 00 fa fa fa fa fa fa fa fa
      0x0c18800013b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
    Shadow byte legend (one shadow byte represents 8 application bytes):
      Addressable:           00
      Partially addressable: 01 02 03 04 05 06 07 
      Heap left redzone:       fa
      Freed heap region:       fd
      Stack left redzone:      f1
      Stack mid redzone:       f2
      Stack right redzone:     f3
      Stack after return:      f5
      Stack use after scope:   f8
      Global redzone:          f9
      Global init order:       f6
      Poisoned by user:        f7
      Container overflow:      fc
      Array cookie:            ac
      Intra object redzone:    bb
      ASan internal:           fe
      Left alloca redzone:     ca
      Right alloca redzone:    cb

---------------

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-ASAN9-12149/test

Topology Tests failed for Addresssanitizer topotests part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12149/artifact/ASAN9/TopotestLogs/log_topotests.txt
Addresssanitizer topotests part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12149/artifact/ASAN9/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 7: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 7: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12149/artifact/TOPO7U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 7: No useful log found

Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18AMD64-12149/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12149/artifact/TOPO7U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12149/artifact/TOPO7U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12149/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12149/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12149/artifact/TOPO9U18I386/TopotestDetails/

Topotests debian 10 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7DEB10AMD64-12149/test

Topology Tests failed for Topotests debian 10 amd64 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12149/artifact/TOPO7DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12149/artifact/TOPO7DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18I386-12149/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12149/artifact/TOPO7U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12149/artifact/TOPO7U18I386/TopotestDetails/

Successful on other platforms/tests

Addresssanitizer topotests part 5
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 3
Topotests debian 10 amd64 part 8
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 2
Static analyzer (clang)
Topotests debian 10 amd64 part 0
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 7
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Debian 10 deb pkg check
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 4
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 0
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 1
Topotests debian 10 amd64 part 5
Debian 9 deb pkg check
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 8
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 6

sri-mohan1 · 2023-06-09T06:11:22Z

ci:rerun

ton31337 · 2023-06-09T06:18:41Z

ci:rerun

Won't succeed until #13745 is merged.

sri-mohan1 · 2023-06-09T06:20:57Z

ci:rerun

Won't succeed until #13745 is merged.

Thank you @ton31337 for the update.

NetDEF-CI · 2023-06-09T09:02:57Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12176/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7DEB10AMD64-12176/test

Topology Tests failed for Topotests debian 10 amd64 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12176/artifact/TOPO7DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12176/artifact/TOPO7DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 7: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 7: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12176/artifact/TOPO7U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 7: No useful log found

Topotests Ubuntu 18.04 i386 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18I386-12176/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12176/artifact/TOPO7U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12176/artifact/TOPO7U18I386/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO7U18AMD64-12176/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12176/artifact/TOPO7U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 7: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12176/artifact/TOPO7U18AMD64/TopotestDetails/

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-12176/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12176/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12176/artifact/TOPO9DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12176/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Successful on other platforms/tests

Debian 9 deb pkg check
Topotests Ubuntu 18.04 amd64 part 1
Ubuntu 20.04 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 i386 part 3
Addresssanitizer topotests part 8
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 4
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 1
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 i386 part 9
Topotests debian 10 amd64 part 2
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 3
Static analyzer (clang)
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 2
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 6
Topotests debian 10 amd64 part 6
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 i386 part 2
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 amd64 part 2
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 0
Topotests debian 10 amd64 part 8
Addresssanitizer topotests part 2

sri-mohan1 · 2023-06-12T05:16:06Z

ci:rerun

NetDEF-CI · 2023-06-12T08:07:20Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12219/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-12219/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12219/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12219/artifact/TOPO9DEB10AMD64/TopotestDetails/

Successful on other platforms/tests

Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 i386 part 5
Addresssanitizer topotests part 3
Addresssanitizer topotests part 2
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 4
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 3
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 i386 part 2
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 8
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 2
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 8
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 9
Debian 9 deb pkg check
Addresssanitizer topotests part 4
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 i386 part 9
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 arm8 part 0
Static analyzer (clang)
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 i386 part 6
Addresssanitizer topotests part 7
Ubuntu 20.04 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Debian 10 deb pkg check
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 5

sri-mohan1 · 2023-06-13T05:05:55Z

ci:rerun

NetDEF-CI · 2023-06-13T08:01:59Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12263/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 3: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12263/artifact/TP3U1804AMD64/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TP3U1804AMD64-12263/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12263/artifact/TP3U1804AMD64/TopotestLogs/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 3: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 3: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12263/artifact/TOPO3U18I386/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO3U18I386-12263/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 3
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12263/artifact/TOPO3U18I386/TopotestLogs/log_topotests.txt

Successful on other platforms/tests

Topotests Ubuntu 18.04 i386 part 7
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 9
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 1
Topotests debian 10 amd64 part 8
Debian 10 deb pkg check
Topotests Ubuntu 18.04 i386 part 6
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 0
Ubuntu 20.04 deb pkg check
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 amd64 part 7
Addresssanitizer topotests part 9
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 9
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 arm8 part 2
CentOS 7 rpm pkg check
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 9
Topotests debian 10 amd64 part 1
Static analyzer (clang)
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 8
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 amd64 part 1
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Debian 9 deb pkg check
Addresssanitizer topotests part 4
Addresssanitizer topotests part 8
Topotests debian 10 amd64 part 5

mobash-rasool · 2023-06-13T15:26:24Z

@sri-mohan1 : Please rebase and push the changes. Few failures are fixed in latest code.

these changes are for improving the code maintainability and readability Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>

NetDEF-CI · 2023-06-14T13:56:14Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12323/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

mjstapp

Looks fine

frrbot bot added the ldp label Jun 8, 2023

github-actions bot added master size/M labels Jun 8, 2023

ldpd: changes for code maintainability

8443d11

these changes are for improving the code maintainability and readability Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>

sri-mohan1 force-pushed the srib-ldpd1 branch from 2a377db to 8443d11 Compare June 14, 2023 11:14

mjstapp approved these changes Jun 14, 2023

View reviewed changes

mjstapp merged commit 0fb1630 into FRRouting:master Jun 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ldpd: changes for code maintainability #13742

ldpd: changes for code maintainability #13742

sri-mohan1 commented Jun 8, 2023

NetDEF-CI commented Jun 8, 2023 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

sri-mohan1 commented Jun 9, 2023

ton31337 commented Jun 9, 2023

sri-mohan1 commented Jun 9, 2023

NetDEF-CI commented Jun 9, 2023 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

sri-mohan1 commented Jun 12, 2023

NetDEF-CI commented Jun 12, 2023 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

sri-mohan1 commented Jun 13, 2023

NetDEF-CI commented Jun 13, 2023 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

mobash-rasool commented Jun 13, 2023

NetDEF-CI commented Jun 14, 2023

mjstapp left a comment

ldpd: changes for code maintainability #13742

ldpd: changes for code maintainability #13742

Conversation

sri-mohan1 commented Jun 8, 2023

NetDEF-CI commented Jun 8, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

sri-mohan1 commented Jun 9, 2023

ton31337 commented Jun 9, 2023

sri-mohan1 commented Jun 9, 2023

NetDEF-CI commented Jun 9, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

sri-mohan1 commented Jun 12, 2023

NetDEF-CI commented Jun 12, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

sri-mohan1 commented Jun 13, 2023

NetDEF-CI commented Jun 13, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

mobash-rasool commented Jun 13, 2023

NetDEF-CI commented Jun 14, 2023

Continuous Integration Result: SUCCESSFUL

mjstapp left a comment

Choose a reason for hiding this comment

NetDEF-CI commented Jun 8, 2023 •

edited

Loading

NetDEF-CI commented Jun 9, 2023 •

edited

Loading

NetDEF-CI commented Jun 12, 2023 •

edited

Loading

NetDEF-CI commented Jun 13, 2023 •

edited

Loading