Issue 13732: Check if the advertising router still knows the LSA itself. #13733

rainbowtux · 2023-06-08T11:31:02Z

Possible fix for issue 13732, I tested this and it works.
(lsa->data->type == OSPF_AS_NSSA_LSA): this could possible be valid for other types too, but not sure.

Fixes #13732

ton31337

Please change the commits message to be prefixed with ospfd, like: osfpd: Check if ....

…ssue 13732) Signed-off-by: Erwin Van de Velde <rainbowtux@users.noreply.github.com>

NetDEF-CI · 2023-06-08T14:15:50Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12126/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12126/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-12126/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12126/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12126/artifact/TOPO9DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-12126/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12126/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12126/artifact/TOPO9U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12126/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12126/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12126/artifact/TOPO9U18I386/TopotestDetails/

Successful on other platforms/tests

Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 5
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 7
Debian 10 deb pkg check
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 i386 part 5
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 2
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 amd64 part 4
CentOS 7 rpm pkg check
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 amd64 part 8
Addresssanitizer topotests part 8
Topotests debian 10 amd64 part 2
Static analyzer (clang)
Ubuntu 18.04 deb pkg check
Topotests Ubuntu 18.04 i386 part 0
Addresssanitizer topotests part 6
Ubuntu 20.04 deb pkg check
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 1
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 6
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 4
Debian 9 deb pkg check
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 5
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 4

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12126/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-12126/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12126/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12126/artifact/TOPO9DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-12126/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12126/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12126/artifact/TOPO9U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12126/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12126/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12126/artifact/TOPO9U18I386/TopotestDetails/

<stdin>:11: trailing whitespace.
		
warning: 1 line adds whitespace errors.
Report for ospf_packet.c | 70 issues
===============================================
< WARNING: line over 80 characters
< #2094: FILE: /tmp/f1-2401007/ospf_packet.c:2094:
< ERROR: code indent should use tabs where possible
< #2094: FILE: /tmp/f1-2401007/ospf_packet.c:2094:
< WARNING: line over 80 characters
< #2095: FILE: /tmp/f1-2401007/ospf_packet.c:2095:
< ERROR: code indent should use tabs where possible
< #2095: FILE: /tmp/f1-2401007/ospf_packet.c:2095:
< WARNING: Block comments use a trailing */ on a separate line
< #2095: FILE: /tmp/f1-2401007/ospf_packet.c:2095:
< ERROR: trailing whitespace
< #2096: FILE: /tmp/f1-2401007/ospf_packet.c:2096:
< ERROR: code indent should use tabs where possible
< #2097: FILE: /tmp/f1-2401007/ospf_packet.c:2097:
< WARNING: please, no spaces at the start of a line
< #2097: FILE: /tmp/f1-2401007/ospf_packet.c:2097:
< WARNING: suspect code indent for conditional statements (16, 20)
< #2097: FILE: /tmp/f1-2401007/ospf_packet.c:2097:
< WARNING: line over 80 characters
< #2098: FILE: /tmp/f1-2401007/ospf_packet.c:2098:
< ERROR: code indent should use tabs where possible
< #2098: FILE: /tmp/f1-2401007/ospf_packet.c:2098:
< WARNING: please, no spaces at the start of a line
< #2098: FILE: /tmp/f1-2401007/ospf_packet.c:2098:
< ERROR: code indent should use tabs where possible
< #2099: FILE: /tmp/f1-2401007/ospf_packet.c:2099:
< WARNING: please, no spaces at the start of a line
< #2099: FILE: /tmp/f1-2401007/ospf_packet.c:2099:
< ERROR: code indent should use tabs where possible
< #2100: FILE: /tmp/f1-2401007/ospf_packet.c:2100:
< WARNING: please, no spaces at the start of a line
< #2100: FILE: /tmp/f1-2401007/ospf_packet.c:2100:
< WARNING: space prohibited between function name and open parenthesis '('
< #2100: FILE: /tmp/f1-2401007/ospf_packet.c:2100:
< ERROR: code indent should use tabs where possible
< #2101: FILE: /tmp/f1-2401007/ospf_packet.c:2101:
< WARNING: please, no spaces at the start of a line
< #2101: FILE: /tmp/f1-2401007/ospf_packet.c:2101:
< WARNING: suspect code indent for conditional statements (20, 22)
< #2101: FILE: /tmp/f1-2401007/ospf_packet.c:2101:
< ERROR: space required before the open parenthesis '('
< #2101: FILE: /tmp/f1-2401007/ospf_packet.c:2101:
< ERROR: code indent should use tabs where possible
< #2102: FILE: /tmp/f1-2401007/ospf_packet.c:2102:
< WARNING: please, no spaces at the start of a line
< #2102: FILE: /tmp/f1-2401007/ospf_packet.c:2102:
< WARNING: space prohibited between function name and open parenthesis '('
< #2102: FILE: /tmp/f1-2401007/ospf_packet.c:2102:
< WARNING: Prefer using '"%s...", __func__' to using 'ospf_ls_upd', this function's name, in a string
< #2102: FILE: /tmp/f1-2401007/ospf_packet.c:2102:
< ERROR: code indent should use tabs where possible
< #2103: FILE: /tmp/f1-2401007/ospf_packet.c:2103:
< WARNING: please, no spaces at the start of a line
< #2103: FILE: /tmp/f1-2401007/ospf_packet.c:2103:
< ERROR: code indent should use tabs where possible
< #2104: FILE: /tmp/f1-2401007/ospf_packet.c:2104:
< WARNING: please, no spaces at the start of a line
< #2104: FILE: /tmp/f1-2401007/ospf_packet.c:2104:
< WARNING: space prohibited between function name and open parenthesis '('
< #2104: FILE: /tmp/f1-2401007/ospf_packet.c:2104:
< ERROR: code indent should use tabs where possible
< #2105: FILE: /tmp/f1-2401007/ospf_packet.c:2105:
< WARNING: please, no spaces at the start of a line
< #2105: FILE: /tmp/f1-2401007/ospf_packet.c:2105:
< ERROR: code indent should use tabs where possible
< #2106: FILE: /tmp/f1-2401007/ospf_packet.c:2106:
< WARNING: please, no spaces at the start of a line
< #2106: FILE: /tmp/f1-2401007/ospf_packet.c:2106:
< WARNING: Block comments use * on subsequent lines
< #2109: FILE: /tmp/f1-2401007/ospf_packet.c:2109:

NetDEF-CI · 2023-06-08T14:25:58Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12127/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12127/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-12127/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12127/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12127/artifact/TOPO9DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-12127/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12127/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12127/artifact/TOPO9U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12127/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12127/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12127/artifact/TOPO9U18I386/TopotestDetails/

Addresssanitizer topotests part 4: Incomplete

(check logs for details)

Successful on other platforms/tests

Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 i386 part 2
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 3
Topotests debian 10 amd64 part 8
Debian 10 deb pkg check
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 amd64 part 4
CentOS 7 rpm pkg check
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 arm8 part 0
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 2
Static analyzer (clang)
Addresssanitizer topotests part 6
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 i386 part 5
Ubuntu 18.04 deb pkg check
Ubuntu 20.04 deb pkg check
Topotests debian 10 amd64 part 1
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 6
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 3
Debian 9 deb pkg check
Topotests debian 10 amd64 part 5
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 4

NetDEF-CI · 2023-06-08T16:49:33Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12132/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-12132/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12132/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12132/artifact/TOPO9DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12132/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-12132/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12132/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12132/artifact/TOPO9U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12132/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12132/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12132/artifact/TOPO9U18I386/TopotestDetails/

Successful on other platforms/tests

Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 8
Addresssanitizer topotests part 7
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 amd64 part 3
Addresssanitizer topotests part 5
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 4
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 i386 part 1
Ubuntu 20.04 deb pkg check
Addresssanitizer topotests part 2
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 amd64 part 7
Topotests debian 10 amd64 part 0
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 8
Addresssanitizer topotests part 8
CentOS 7 rpm pkg check
Addresssanitizer topotests part 6
Static analyzer (clang)
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 amd64 part 1
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 i386 part 0
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Addresssanitizer topotests part 0
Ubuntu 18.04 deb pkg check
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 1
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 3
Debian 9 deb pkg check
Addresssanitizer topotests part 4

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-12132/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12132/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12132/artifact/TOPO9DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12132/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-12132/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12132/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12132/artifact/TOPO9U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12132/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12132/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12132/artifact/TOPO9U18I386/TopotestDetails/

Report for ospf_packet.c | 6 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #2097: FILE: /tmp/f1-3404578/ospf_packet.c:2097:
< WARNING: Prefer using '"%s...", __func__' to using 'ospf_ls_upd', this function's name, in a string
< #2106: FILE: /tmp/f1-3404578/ospf_packet.c:2106:
< WARNING: Block comments use * on subsequent lines
< #2113: FILE: /tmp/f1-3404578/ospf_packet.c:2113:

riw777

changes look good, waiting on comment from @ton31337

riw777 · 2023-06-13T15:32:24Z

I'll try rerunning, but it looks like the failure is related

riw777 · 2023-06-13T15:32:31Z

ci:rerun

NetDEF-CI · 2023-06-13T21:17:19Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-12307/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12307/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9U18I386/TopotestDetails/

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-12307/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Successful on other platforms/tests

Static analyzer (clang)
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 2
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Debian 9 deb pkg check
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 i386 part 8
Ubuntu 18.04 deb pkg check
Ubuntu 20.04 deb pkg check
Addresssanitizer topotests part 6
Debian 10 deb pkg check
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 4
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 i386 part 7
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 7
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 2
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 4
Topotests debian 10 amd64 part 8
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 3

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-12307/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12307/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9U18I386/TopotestDetails/

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-12307/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Report for ospf_packet.c | 6 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #2097: FILE: /tmp/f1-164105/ospf_packet.c:2097:
< WARNING: Prefer using '"%s...", __func__' to using 'ospf_ls_upd', this function's name, in a string
< #2106: FILE: /tmp/f1-164105/ospf_packet.c:2106:
< WARNING: Block comments use * on subsequent lines
< #2113: FILE: /tmp/f1-164105/ospf_packet.c:2113:

Commit fixed, dismissing my requests.

NetDEF-CI · 2023-06-27T12:00:50Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-12307/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12307/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9U18I386/TopotestDetails/

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-12307/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Successful on other platforms/tests

Static analyzer (clang)
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 1
Topotests Ubuntu 18.04 amd64 part 8
Topotests debian 10 amd64 part 2
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 0
Debian 9 deb pkg check
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 i386 part 8
Ubuntu 18.04 deb pkg check
Ubuntu 20.04 deb pkg check
Addresssanitizer topotests part 6
Debian 10 deb pkg check
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 arm8 part 3
Addresssanitizer topotests part 5
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 4
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 0
Topotests debian 10 amd64 part 5
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 i386 part 7
Topotests debian 10 amd64 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 amd64 part 7
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 amd64 part 2
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 4
Topotests debian 10 amd64 part 8
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 amd64 part 3

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18AMD64-12307/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9U18I386-12307/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9U18I386/TopotestDetails/

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-12307/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-12307/artifact/TOPO9U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Report for ospf_packet.c | 6 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #2097: FILE: /tmp/f1-164105/ospf_packet.c:2097:
< WARNING: Prefer using '"%s...", __func__' to using 'ospf_ls_upd', this function's name, in a string
< #2106: FILE: /tmp/f1-164105/ospf_packet.c:2106:
< WARNING: Block comments use * on subsequent lines
< #2113: FILE: /tmp/f1-164105/ospf_packet.c:2113:

ton31337 · 2023-07-20T07:38:00Z

Could you fix also CI warnings?

Report for ospf_packet.c | 6 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #2097: FILE: /tmp/f1-164105/ospf_packet.c:2097:
< WARNING: Prefer using '"%s...", __func__' to using 'ospf_ls_upd', this function's name, in a string
< #2106: FILE: /tmp/f1-164105/ospf_packet.c:2106:
< WARNING: Block comments use * on subsequent lines
< #2113: FILE: /tmp/f1-164105/ospf_packet.c:2113:

riw777 · 2023-08-08T13:36:28Z

not certain these failures are still valid after the most recent change ... rerunning
ci:rerun

NetDEF-CI · 2023-08-08T14:35:52Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13372/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: No useful log found

Successful on other platforms/tests

Debian 9 amd64 build
Ubuntu 18.04 arm8 build
Ubuntu 20.04 amd64 build
Ubuntu 18.04 ppc64le build
Ubuntu 22.04 amd64 build
Debian 10 amd64 build
Redhat 9 amd64 build
Ubuntu 18.04 amd64 build
FreeBSD 11 amd64 build
Debian 11 amd64 build
FreeBSD 12 amd64 build
CentOS 7 amd64 build
Ubuntu 18.04 i386 build
Redhat 8 amd64 build
OpenBSD 7 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: No useful log found

Report for ospf_packet.c | 6 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #2097: FILE: /tmp/f1-337974/ospf_packet.c:2097:
< WARNING: Prefer using '"%s...", __func__' to using 'ospf_ls_upd', this function's name, in a string
< #2106: FILE: /tmp/f1-337974/ospf_packet.c:2106:
< WARNING: Block comments use * on subsequent lines
< #2113: FILE: /tmp/f1-337974/ospf_packet.c:2113:

rwestphal · 2023-08-11T21:49:18Z

ospfd/ospf_packet.c

+		/* Added to prevent the router from accepting old LSAs that were
+		sent by it
+		before, were not properly removed (e.g. due to crash) but which
+		have become invalid */


I don't think this is a proper solution to the problem. ospfd already has mechanisms to handle the receipt of self-originated LSAs once the daemon is restarted. Those LSAs are either reoriginated or flushed depending whether they are still valid or not. You can look at ospf_process_self_originated_lsa() and ospf_abr_task_timer() for more details. I think the bug you reported should be fixed within the scope of those functions.

I've commented on #13732 asking for more information so that I can understand the problem better. I couldn't reproduce the reported issue locally.

riw777 · 2024-01-03T12:51:04Z

Is anyone still working on this?

riw777 · 2024-01-16T13:29:58Z

@frrbot autoclose in 1 month

github-actions bot added master size/S labels Jun 8, 2023

rainbowtux force-pushed the issue_13732 branch from 3f65ae5 to b694557 Compare June 8, 2023 11:46

ton31337 previously requested changes Jun 8, 2023

View reviewed changes

ospfd: Check if the advertising router still knows the LSA itself. (I…

42ec50d

…ssue 13732) Signed-off-by: Erwin Van de Velde <rainbowtux@users.noreply.github.com>

rainbowtux force-pushed the issue_13732 branch from b694557 to 42ec50d Compare June 8, 2023 13:59

frrbot bot added the ospf label Jun 8, 2023

riw777 approved these changes Jun 13, 2023

View reviewed changes

eqvinox requested a review from ton31337 June 13, 2023 15:29

rwestphal reviewed Aug 11, 2023

View reviewed changes

riw777 self-requested a review August 15, 2023 13:24

frrbot bot added the autoclose label Jan 16, 2024

github-actions bot added rebase PR needs rebase and removed autoclose labels Jan 16, 2024

frrbot bot closed this Feb 16, 2024

Issue 13732: Check if the advertising router still knows the LSA itself. #13733

Issue 13732: Check if the advertising router still knows the LSA itself. #13733

Conversation

rainbowtux commented Jun 8, 2023 • edited by ton31337 Loading

ton31337 left a comment

Choose a reason for hiding this comment

NetDEF-CI commented Jun 8, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Jun 8, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

NetDEF-CI commented Jun 8, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

riw777 left a comment

Choose a reason for hiding this comment

riw777 commented Jun 13, 2023

riw777 commented Jun 13, 2023

NetDEF-CI commented Jun 13, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

NetDEF-CI commented Jun 27, 2023 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

ton31337 commented Jul 20, 2023

riw777 commented Aug 8, 2023

NetDEF-CI commented Aug 8, 2023

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

rwestphal Aug 11, 2023

Choose a reason for hiding this comment

riw777 commented Jan 3, 2024

riw777 commented Jan 16, 2024

rainbowtux commented Jun 8, 2023 •

edited by ton31337

Loading

NetDEF-CI commented Jun 8, 2023 •

edited

Loading

NetDEF-CI commented Jun 8, 2023 •

edited

Loading

NetDEF-CI commented Jun 8, 2023 •

edited

Loading

NetDEF-CI commented Jun 13, 2023 •

edited

Loading

NetDEF-CI commented Jun 27, 2023 •

edited

Loading