Introduce the centralized management daemon

[choppsv1]

Centralized management daemon for FRR.

Yash Ranjan ranjany@vmware.com
Abhinay Ramesh rabhinay@vmware.com
Ujwal P ujwalp@vmware.com
Pushpasis Sarkar pushpasis@gmail.com

Design team included the above and:
Christian Hopps, Igor Ryzhov, Mark Stapp, Jafar Al-Gharaibeh, Chirag Shah, David Lamparter, et al.

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/CI101BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.10267/frr-source'
lib/mgmt_be_client.c: In function 'mgmt_be_client_handle_msg':
lib/mgmt_be_client.c:878:7: error: '_MGMTD__BE_MESSAGE__MESSAGE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE'?
lib/mgmt_be_client.c:878:7: note: each undeclared identifier is reported only once for each function it appears in
lib/mgmt_be_client.c:835:2: error: enumeration value '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE' not handled in switch [-Werror=switch-enum]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10489: lib/mgmt_be_client.lo] Error 1
lib/mgmt_fe_client.c: In function 'mgmt_fe_client_handle_msg':
lib/mgmt_fe_client.c:651:7: error: '_MGMTD__FE_MESSAGE__MESSAGE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__FE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE'?

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka long int} (strict match required [C]) [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10490: lib/mgmt_msg.lo] Error 1
In file included from ./lib/log.h:17,

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/DEB11AMD64/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/U1604I386/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/U18I386BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/U18I386BUILD/config.log/config.log.gz

Successful on other platforms/tests

• Debian 9 amd64 build
• Ubuntu 20.04 amd64 build
• Ubuntu 18.04 ppc64le build
• Ubuntu 22.04 amd64 build
• FreeBSD 12 amd64 build
• Fedora 29 amd64 build
• Ubuntu 18.04 arm8 build
• Debian 10 amd64 build
• Redhat 9 amd64 build
• Ubuntu 18.04 amd64 build
• Ubuntu 16.04 arm8 build
• Ubuntu 16.04 amd64 build
• OpenBSD 7 amd64 build
• CentOS 7 amd64 build
• Redhat 8 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/CI101BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.10267/frr-source'
lib/mgmt_be_client.c: In function 'mgmt_be_client_handle_msg':
lib/mgmt_be_client.c:878:7: error: '_MGMTD__BE_MESSAGE__MESSAGE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE'?
lib/mgmt_be_client.c:878:7: note: each undeclared identifier is reported only once for each function it appears in
lib/mgmt_be_client.c:835:2: error: enumeration value '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE' not handled in switch [-Werror=switch-enum]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10489: lib/mgmt_be_client.lo] Error 1
lib/mgmt_fe_client.c: In function 'mgmt_fe_client_handle_msg':
lib/mgmt_fe_client.c:651:7: error: '_MGMTD__FE_MESSAGE__MESSAGE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__FE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE'?

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka long int} (strict match required [C]) [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10490: lib/mgmt_msg.lo] Error 1
In file included from ./lib/log.h:17,

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/DEB11AMD64/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/U1604I386/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/U18I386BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10267/artifact/U18I386BUILD/config.log/config.log.gz

<stdin>:18223: trailing whitespace.
    
warning: 1 line adds whitespace errors.
Report for mgmt_be_adapter.c | 29 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#48: FILE: /tmp/f1-3609459/mgmt_be_adapter.c:48:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_be_adapters, &mgmt_be_adapters, (adapter))

ERROR: space required after that close brace '}'
#97: FILE: /tmp/f1-3609459/mgmt_be_adapter.c:97:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#104: FILE: /tmp/f1-3609459/mgmt_be_adapter.c:104:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#113: FILE: /tmp/f1-3609459/mgmt_be_adapter.c:113:
+			 MGMTD_BE_CLIENT_ID_MAX}},

WARNING: line over 80 characters
#363: FILE: /tmp/f1-3609459/mgmt_be_adapter.c:363:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#755: FILE: /tmp/f1-3609459/mgmt_be_adapter.c:755:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#768: FILE: /tmp/f1-3609459/mgmt_be_adapter.c:768:
+				 adapter, adapter->conn_fd, &adapter->conn_write_ev);
Report for mgmt_be_client.c | 23 issues
===============================================
WARNING: line over 80 characters
#40: FILE: /tmp/f1-3609459/mgmt_be_client.c:40:
+			zlog_debug("%s: " fmt, __func__, ##__VA_ARGS__);         \

ERROR: Macros with complex values should be enclosed in parentheses
#113: FILE: /tmp/f1-3609459/mgmt_be_client.c:113:
+#define FOREACH_BE_TXN_BATCH_IN_LIST(txn, batch)                               \
+	frr_each_safe (mgmt_be_batches, &(txn)->cfg_batches, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#116: FILE: /tmp/f1-3609459/mgmt_be_client.c:116:
+#define FOREACH_BE_APPLY_BATCH_IN_LIST(txn, batch)                             \
+	frr_each_safe (mgmt_be_batches, &(txn)->apply_cfgs, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#149: FILE: /tmp/f1-3609459/mgmt_be_client.c:149:
+#define FOREACH_BE_TXN_IN_LIST(client_ctx, txn)                                \
+	frr_each_safe (mgmt_be_txns, &(client_ctx)->txn_head, (txn))

WARNING: line over 80 characters
#613: FILE: /tmp/f1-3609459/mgmt_be_client.c:613:
+			client_ctx->avg_prep_nb_cfg_tm, (uint32_t)num_processed);
Report for mgmt_ds.c | 29 issues
===============================================
WARNING: Missing a blank line after declarations
#205: FILE: /tmp/f1-3609459/mgmt_ds.c:205:
+	struct lyd_node *dnode = mm->candidate_ds->root.cfg_root->dnode;
+	if (dnode)

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#293: FILE: /tmp/f1-3609459/mgmt_ds.c:293:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#295: FILE: /tmp/f1-3609459/mgmt_ds.c:295:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#303: FILE: /tmp/f1-3609459/mgmt_ds.c:303:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#305: FILE: /tmp/f1-3609459/mgmt_ds.c:305:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#313: FILE: /tmp/f1-3609459/mgmt_ds.c:313:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#321: FILE: /tmp/f1-3609459/mgmt_ds.c:321:
+		return EINVAL;
Report for mgmt_fe_adapter.c | 46 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#49: FILE: /tmp/f1-3609459/mgmt_fe_adapter.c:49:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_fe_adapters, &mgmt_fe_adapters, (adapter))

ERROR: Macros with complex values should be enclosed in parentheses
#74: FILE: /tmp/f1-3609459/mgmt_fe_adapter.c:74:
+#define FOREACH_SESSION_IN_LIST(adapter, session)                              \
+	frr_each_safe (mgmt_fe_sessions, &(adapter)->fe_sessions, (session))

WARNING: line over 80 characters
#510: FILE: /tmp/f1-3609459/mgmt_fe_adapter.c:510:
+			gettimeofday(&session->adapter->cmt_stats.last_end, NULL);

WARNING: line over 80 characters
#733: FILE: /tmp/f1-3609459/mgmt_fe_adapter.c:733:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#1126: FILE: /tmp/f1-3609459/mgmt_fe_adapter.c:1126:
+				session, getdata_req->ds_id, getdata_req->req_id,

WARNING: line over 80 characters
#1509: FILE: /tmp/f1-3609459/mgmt_fe_adapter.c:1509:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#1799: FILE: /tmp/f1-3609459/mgmt_fe_adapter.c:1799:
+					&adapter->cmt_stats.apply_cfg_start, buf,

WARNING: line over 80 characters
#1837: FILE: /tmp/f1-3609459/mgmt_fe_adapter.c:1837:
+			mgmt_realtime_to_string(&adapter->setcfg_stats.last_start,

WARNING: line over 80 characters
#1879: FILE: /tmp/f1-3609459/mgmt_fe_adapter.c:1879:
+						session->ds_locked_implict[ds_id]

WARNING: line over 80 characters
#1913: FILE: /tmp/f1-3609459/mgmt_fe_adapter.c:1913:
+		memset(&adapter->setcfg_stats, 0, sizeof(adapter->setcfg_stats));

WARNING: line over 80 characters
#1915: FILE: /tmp/f1-3609459/mgmt_fe_adapter.c:1915:
+			memset(&adapter->cmt_stats, 0, sizeof(adapter->cmt_stats));
Report for mgmt_fe_client.c | 25 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#82: FILE: /tmp/f1-3609459/mgmt_fe_client.c:82:
+#define FOREACH_SESSION_IN_LIST(client_ctx, session)                           \
+	frr_each_safe (mgmt_sessions, &(client_ctx)->client_sessions, (session))

WARNING: line over 80 characters
#125: FILE: /tmp/f1-3609459/mgmt_fe_client.c:125:
+				"Found session %p for session-id %llu.", session,

WARNING: line over 80 characters
#290: FILE: /tmp/f1-3609459/mgmt_fe_client.c:290:
+		lock ? "" : "UN", ds_id, (unsigned long long)session->client_id);

WARNING: line over 80 characters
#330: FILE: /tmp/f1-3609459/mgmt_fe_client.c:330:
+			       Mgmtd__DatastoreId dest_ds_id, bool validate_only,

WARNING: line over 80 characters
#463: FILE: /tmp/f1-3609459/mgmt_fe_client.c:463:
+						->session_reply->client_conn_id);

WARNING: line over 80 characters
#470: FILE: /tmp/f1-3609459/mgmt_fe_client.c:470:
+						->session_reply->client_conn_id);
Report for mgmt_history.c | 30 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#29: FILE: /tmp/f1-3609459/mgmt_history.c:29:
+#define FOREACH_CMT_REC(mm, cmt_info)                                          \
+	frr_each_safe (mgmt_cmt_infos, &mm->cmts, cmt_info)

ERROR: do not initialise statics to NULL
#36: FILE: /tmp/f1-3609459/mgmt_history.c:36:
+static struct vty *rollback_vty = NULL;

WARNING: line over 80 characters
#103: FILE: /tmp/f1-3609459/mgmt_history.c:103:
+static struct mgmt_cmt_info_t *mgmt_history_find_cmt_record(const char *cmtid_str)

WARNING: line over 80 characters
#132: FILE: /tmp/f1-3609459/mgmt_history.c:132:
+			if (!mgmt_history_record_exists(cmt_info.cmt_json_file)) {

WARNING: line over 80 characters
#284: FILE: /tmp/f1-3609459/mgmt_history.c:284:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: line over 80 characters
#323: FILE: /tmp/f1-3609459/mgmt_history.c:323:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: Missing a blank line after declarations
#358: FILE: /tmp/f1-3609459/mgmt_history.c:358:
+	struct mgmt_cmt_info_t *cmt_info = mgmt_history_create_cmt_rec();
+	mgmt_ds_dump_ds_to_file(cmt_info->cmt_json_file, ds_ctx);
Report for mgmt_history.h | 5 issues
===============================================
WARNING: Block comments should align the * on each line
#3: FILE: /tmp/f1-3609459/mgmt_history.h:3:
+/*
+  * Copyright (C) 2021  Vmware, Inc.
Report for mgmt_msg.c | 5 issues
===============================================
WARNING: else is not generally useful after a break or return
#226: FILE: /tmp/f1-3609459/mgmt_msg.c:226:
+				return MSW_SCHED_STREAM;
+			} else
Report for mgmt_txn.c | 20 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#120: FILE: /tmp/f1-3609459/mgmt_txn.c:120:
+#define FOREACH_TXN_CFG_BATCH_IN_LIST(list, batch)                             \
+	frr_each_safe (mgmt_txn_batches, list, batch)

ERROR: Macros with complex values should be enclosed in parentheses
#220: FILE: /tmp/f1-3609459/mgmt_txn.c:220:
+#define FOREACH_TXN_REQ_IN_LIST(list, req)                                     \
+	frr_each_safe (mgmt_txn_reqs, list, req)

ERROR: Macros with complex values should be enclosed in parentheses
#275: FILE: /tmp/f1-3609459/mgmt_txn.c:275:
+#define FOREACH_TXN_IN_LIST(mm, txn)                                           \
+	frr_each_safe (mgmt_txns, &(mm)->txn_list, (txn))

WARNING: Missing a blank line after declarations
#1271: FILE: /tmp/f1-3609459/mgmt_txn.c:1271:
+	char err_buf[1024] = {0};
+	nb_ctx.client = NB_CLIENT_MGMTD_SERVER;
Report for mgmt_vty.c | 10 issues
===============================================
WARNING: Missing a blank line after declarations
#404: FILE: /tmp/f1-3609459/mgmt_vty.c:404:
+	int n = mgmt_debug_be + mgmt_debug_fe + mgmt_debug_ds + mgmt_debug_txn;
+	if (!n)

WARNING: Missing a blank line after declarations
#439: FILE: /tmp/f1-3609459/mgmt_vty.c:439:
+	bool set = !no;
+	if (all)
Report for northbound.h | 2 issues
===============================================
< WARNING: line over 80 characters
< #1009: FILE: /tmp/f1-3609459/northbound.h:1009:
Report for static_vty.c | 20 issues
===============================================
< WARNING: line over 80 characters
< #375: FILE: /tmp/f1-3609459/static_vty.c:375:
< WARNING: line over 80 characters
< #378: FILE: /tmp/f1-3609459/static_vty.c:378:
< WARNING: line over 80 characters
< #380: FILE: /tmp/f1-3609459/static_vty.c:380:
< WARNING: line over 80 characters
< #385: FILE: /tmp/f1-3609459/static_vty.c:385:
< WARNING: line over 80 characters
< #386: FILE: /tmp/f1-3609459/static_vty.c:386:
< WARNING: line over 80 characters
< #389: FILE: /tmp/f1-3609459/static_vty.c:389:
< WARNING: line over 80 characters
< #401: FILE: /tmp/f1-3609459/static_vty.c:401:
< WARNING: line over 80 characters
< #408: FILE: /tmp/f1-3609459/static_vty.c:408:
< WARNING: line over 80 characters
< #412: FILE: /tmp/f1-3609459/static_vty.c:412:
< WARNING: line over 80 characters
< #413: FILE: /tmp/f1-3609459/static_vty.c:413:
Report for vty.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #3366: FILE: /tmp/f1-3609459/vty.c:3366:
< WARNING: line over 80 characters
< #3649: FILE: /tmp/f1-3609459/vty.c:3649:
Report for vty.h | 2 issues
===============================================
< WARNING: line over 80 characters
< #395: FILE: /tmp/f1-3609459/vty.h:395:

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/CI101BUILD/config.status/config.status

Redhat 9 amd64 build: Failed (click for details)

Configure failed for Redhat 9 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/RH9BUILD/ErrorLog/log_configure.txt)

checking for sendmmsg... yes
checking for explicit_bzero... yes
checking for struct mmsghdr.msg_hdr... yes
checking for protoc... no
checking for protoc-c... no
configure: error: in `/home/ci/cibuild.10268/frr-source':
configure: error: protobuf requested but protoc-c not found.  Install protobuf-c.
See `config.log' for more details

Redhat 9 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/RH9BUILD/config.log/config.log

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/U1604I386/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka long int} (strict match required [C]) [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10490: lib/mgmt_msg.lo] Error 1
In file included from ./lib/log.h:17,

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/DEB11AMD64/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.10268/frr-source'
lib/mgmt_be_client.c: In function 'mgmt_be_client_handle_msg':
lib/mgmt_be_client.c:878:7: error: '_MGMTD__BE_MESSAGE__MESSAGE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE'?
lib/mgmt_be_client.c:878:7: note: each undeclared identifier is reported only once for each function it appears in
lib/mgmt_be_client.c:835:2: error: enumeration value '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE' not handled in switch [-Werror=switch-enum]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10489: lib/mgmt_be_client.lo] Error 1
lib/mgmt_fe_client.c: In function 'mgmt_fe_client_handle_msg':
lib/mgmt_fe_client.c:651:7: error: '_MGMTD__FE_MESSAGE__MESSAGE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__FE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE'?

Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/U18I386BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/U18I386BUILD/config.log/config.log.gz

Successful on other platforms/tests

• Ubuntu 18.04 arm8 build
• Debian 9 amd64 build
• Ubuntu 20.04 amd64 build
• Ubuntu 18.04 ppc64le build
• Ubuntu 22.04 amd64 build
• Fedora 29 amd64 build
• Debian 10 amd64 build
• Ubuntu 18.04 amd64 build
• FreeBSD 12 amd64 build
• Ubuntu 16.04 arm8 build
• Ubuntu 16.04 amd64 build
• CentOS 7 amd64 build
• Redhat 8 amd64 build
• OpenBSD 7 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/CI101BUILD/config.status/config.status

Redhat 9 amd64 build: Failed (click for details)

Configure failed for Redhat 9 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/RH9BUILD/ErrorLog/log_configure.txt)

checking for sendmmsg... yes
checking for explicit_bzero... yes
checking for struct mmsghdr.msg_hdr... yes
checking for protoc... no
checking for protoc-c... no
configure: error: in `/home/ci/cibuild.10268/frr-source':
configure: error: protobuf requested but protoc-c not found.  Install protobuf-c.
See `config.log' for more details

Redhat 9 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/RH9BUILD/config.log/config.log

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/U1604I386/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka long int} (strict match required [C]) [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10490: lib/mgmt_msg.lo] Error 1
In file included from ./lib/log.h:17,

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/DEB11AMD64/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.10268/frr-source'
lib/mgmt_be_client.c: In function 'mgmt_be_client_handle_msg':
lib/mgmt_be_client.c:878:7: error: '_MGMTD__BE_MESSAGE__MESSAGE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE'?
lib/mgmt_be_client.c:878:7: note: each undeclared identifier is reported only once for each function it appears in
lib/mgmt_be_client.c:835:2: error: enumeration value '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE' not handled in switch [-Werror=switch-enum]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10489: lib/mgmt_be_client.lo] Error 1
lib/mgmt_fe_client.c: In function 'mgmt_fe_client_handle_msg':
lib/mgmt_fe_client.c:651:7: error: '_MGMTD__FE_MESSAGE__MESSAGE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__FE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE'?

Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/U18I386BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10268/artifact/U18I386BUILD/config.log/config.log.gz

<stdin>:18244: trailing whitespace.
    
warning: 1 line adds whitespace errors.
Report for mgmt_be_adapter.c | 29 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#48: FILE: /tmp/f1-3675327/mgmt_be_adapter.c:48:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_be_adapters, &mgmt_be_adapters, (adapter))

ERROR: space required after that close brace '}'
#97: FILE: /tmp/f1-3675327/mgmt_be_adapter.c:97:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#104: FILE: /tmp/f1-3675327/mgmt_be_adapter.c:104:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#113: FILE: /tmp/f1-3675327/mgmt_be_adapter.c:113:
+			 MGMTD_BE_CLIENT_ID_MAX}},

WARNING: line over 80 characters
#363: FILE: /tmp/f1-3675327/mgmt_be_adapter.c:363:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#755: FILE: /tmp/f1-3675327/mgmt_be_adapter.c:755:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#768: FILE: /tmp/f1-3675327/mgmt_be_adapter.c:768:
+				 adapter, adapter->conn_fd, &adapter->conn_write_ev);
Report for mgmt_be_client.c | 23 issues
===============================================
WARNING: line over 80 characters
#40: FILE: /tmp/f1-3675327/mgmt_be_client.c:40:
+			zlog_debug("%s: " fmt, __func__, ##__VA_ARGS__);         \

ERROR: Macros with complex values should be enclosed in parentheses
#113: FILE: /tmp/f1-3675327/mgmt_be_client.c:113:
+#define FOREACH_BE_TXN_BATCH_IN_LIST(txn, batch)                               \
+	frr_each_safe (mgmt_be_batches, &(txn)->cfg_batches, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#116: FILE: /tmp/f1-3675327/mgmt_be_client.c:116:
+#define FOREACH_BE_APPLY_BATCH_IN_LIST(txn, batch)                             \
+	frr_each_safe (mgmt_be_batches, &(txn)->apply_cfgs, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#149: FILE: /tmp/f1-3675327/mgmt_be_client.c:149:
+#define FOREACH_BE_TXN_IN_LIST(client_ctx, txn)                                \
+	frr_each_safe (mgmt_be_txns, &(client_ctx)->txn_head, (txn))

WARNING: line over 80 characters
#613: FILE: /tmp/f1-3675327/mgmt_be_client.c:613:
+			client_ctx->avg_prep_nb_cfg_tm, (uint32_t)num_processed);
Report for mgmt_ds.c | 29 issues
===============================================
WARNING: Missing a blank line after declarations
#205: FILE: /tmp/f1-3675327/mgmt_ds.c:205:
+	struct lyd_node *dnode = mm->candidate_ds->root.cfg_root->dnode;
+	if (dnode)

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#293: FILE: /tmp/f1-3675327/mgmt_ds.c:293:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#295: FILE: /tmp/f1-3675327/mgmt_ds.c:295:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#303: FILE: /tmp/f1-3675327/mgmt_ds.c:303:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#305: FILE: /tmp/f1-3675327/mgmt_ds.c:305:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#313: FILE: /tmp/f1-3675327/mgmt_ds.c:313:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#321: FILE: /tmp/f1-3675327/mgmt_ds.c:321:
+		return EINVAL;
Report for mgmt_fe_adapter.c | 46 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#49: FILE: /tmp/f1-3675327/mgmt_fe_adapter.c:49:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_fe_adapters, &mgmt_fe_adapters, (adapter))

ERROR: Macros with complex values should be enclosed in parentheses
#74: FILE: /tmp/f1-3675327/mgmt_fe_adapter.c:74:
+#define FOREACH_SESSION_IN_LIST(adapter, session)                              \
+	frr_each_safe (mgmt_fe_sessions, &(adapter)->fe_sessions, (session))

WARNING: line over 80 characters
#510: FILE: /tmp/f1-3675327/mgmt_fe_adapter.c:510:
+			gettimeofday(&session->adapter->cmt_stats.last_end, NULL);

WARNING: line over 80 characters
#733: FILE: /tmp/f1-3675327/mgmt_fe_adapter.c:733:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#1126: FILE: /tmp/f1-3675327/mgmt_fe_adapter.c:1126:
+				session, getdata_req->ds_id, getdata_req->req_id,

WARNING: line over 80 characters
#1509: FILE: /tmp/f1-3675327/mgmt_fe_adapter.c:1509:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#1799: FILE: /tmp/f1-3675327/mgmt_fe_adapter.c:1799:
+					&adapter->cmt_stats.apply_cfg_start, buf,

WARNING: line over 80 characters
#1837: FILE: /tmp/f1-3675327/mgmt_fe_adapter.c:1837:
+			mgmt_realtime_to_string(&adapter->setcfg_stats.last_start,

WARNING: line over 80 characters
#1879: FILE: /tmp/f1-3675327/mgmt_fe_adapter.c:1879:
+						session->ds_locked_implict[ds_id]

WARNING: line over 80 characters
#1913: FILE: /tmp/f1-3675327/mgmt_fe_adapter.c:1913:
+		memset(&adapter->setcfg_stats, 0, sizeof(adapter->setcfg_stats));

WARNING: line over 80 characters
#1915: FILE: /tmp/f1-3675327/mgmt_fe_adapter.c:1915:
+			memset(&adapter->cmt_stats, 0, sizeof(adapter->cmt_stats));
Report for mgmt_fe_client.c | 25 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#82: FILE: /tmp/f1-3675327/mgmt_fe_client.c:82:
+#define FOREACH_SESSION_IN_LIST(client_ctx, session)                           \
+	frr_each_safe (mgmt_sessions, &(client_ctx)->client_sessions, (session))

WARNING: line over 80 characters
#125: FILE: /tmp/f1-3675327/mgmt_fe_client.c:125:
+				"Found session %p for session-id %llu.", session,

WARNING: line over 80 characters
#290: FILE: /tmp/f1-3675327/mgmt_fe_client.c:290:
+		lock ? "" : "UN", ds_id, (unsigned long long)session->client_id);

WARNING: line over 80 characters
#330: FILE: /tmp/f1-3675327/mgmt_fe_client.c:330:
+			       Mgmtd__DatastoreId dest_ds_id, bool validate_only,

WARNING: line over 80 characters
#463: FILE: /tmp/f1-3675327/mgmt_fe_client.c:463:
+						->session_reply->client_conn_id);

WARNING: line over 80 characters
#470: FILE: /tmp/f1-3675327/mgmt_fe_client.c:470:
+						->session_reply->client_conn_id);
Report for mgmt_history.c | 30 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#29: FILE: /tmp/f1-3675327/mgmt_history.c:29:
+#define FOREACH_CMT_REC(mm, cmt_info)                                          \
+	frr_each_safe (mgmt_cmt_infos, &mm->cmts, cmt_info)

ERROR: do not initialise statics to NULL
#36: FILE: /tmp/f1-3675327/mgmt_history.c:36:
+static struct vty *rollback_vty = NULL;

WARNING: line over 80 characters
#103: FILE: /tmp/f1-3675327/mgmt_history.c:103:
+static struct mgmt_cmt_info_t *mgmt_history_find_cmt_record(const char *cmtid_str)

WARNING: line over 80 characters
#132: FILE: /tmp/f1-3675327/mgmt_history.c:132:
+			if (!mgmt_history_record_exists(cmt_info.cmt_json_file)) {

WARNING: line over 80 characters
#284: FILE: /tmp/f1-3675327/mgmt_history.c:284:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: line over 80 characters
#323: FILE: /tmp/f1-3675327/mgmt_history.c:323:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: Missing a blank line after declarations
#358: FILE: /tmp/f1-3675327/mgmt_history.c:358:
+	struct mgmt_cmt_info_t *cmt_info = mgmt_history_create_cmt_rec();
+	mgmt_ds_dump_ds_to_file(cmt_info->cmt_json_file, ds_ctx);
Report for mgmt_history.h | 5 issues
===============================================
WARNING: Block comments should align the * on each line
#3: FILE: /tmp/f1-3675327/mgmt_history.h:3:
+/*
+  * Copyright (C) 2021  Vmware, Inc.
Report for mgmt_msg.c | 5 issues
===============================================
WARNING: else is not generally useful after a break or return
#226: FILE: /tmp/f1-3675327/mgmt_msg.c:226:
+				return MSW_SCHED_STREAM;
+			} else
Report for mgmt_txn.c | 20 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#120: FILE: /tmp/f1-3675327/mgmt_txn.c:120:
+#define FOREACH_TXN_CFG_BATCH_IN_LIST(list, batch)                             \
+	frr_each_safe (mgmt_txn_batches, list, batch)

ERROR: Macros with complex values should be enclosed in parentheses
#220: FILE: /tmp/f1-3675327/mgmt_txn.c:220:
+#define FOREACH_TXN_REQ_IN_LIST(list, req)                                     \
+	frr_each_safe (mgmt_txn_reqs, list, req)

ERROR: Macros with complex values should be enclosed in parentheses
#275: FILE: /tmp/f1-3675327/mgmt_txn.c:275:
+#define FOREACH_TXN_IN_LIST(mm, txn)                                           \
+	frr_each_safe (mgmt_txns, &(mm)->txn_list, (txn))

WARNING: Missing a blank line after declarations
#1271: FILE: /tmp/f1-3675327/mgmt_txn.c:1271:
+	char err_buf[1024] = {0};
+	nb_ctx.client = NB_CLIENT_MGMTD_SERVER;
Report for mgmt_vty.c | 10 issues
===============================================
WARNING: Missing a blank line after declarations
#404: FILE: /tmp/f1-3675327/mgmt_vty.c:404:
+	int n = mgmt_debug_be + mgmt_debug_fe + mgmt_debug_ds + mgmt_debug_txn;
+	if (!n)

WARNING: Missing a blank line after declarations
#439: FILE: /tmp/f1-3675327/mgmt_vty.c:439:
+	bool set = !no;
+	if (all)
Report for static_vty.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #385: FILE: /tmp/f1-3675327/static_vty.c:385:
< WARNING: line over 80 characters
< #407: FILE: /tmp/f1-3675327/static_vty.c:407:
Report for vty.c | 8 issues
===============================================
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3491: FILE: /tmp/f1-3675327/vty.c:3491:
< WARNING: line over 80 characters
< #3506: FILE: /tmp/f1-3675327/vty.c:3506:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3592: FILE: /tmp/f1-3675327/vty.c:3592:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3628: FILE: /tmp/f1-3675327/vty.c:3628:

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.10269/frr-source'
lib/mgmt_be_client.c: In function 'mgmt_be_client_handle_msg':
lib/mgmt_be_client.c:878:7: error: '_MGMTD__BE_MESSAGE__MESSAGE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE'?
lib/mgmt_be_client.c:878:7: note: each undeclared identifier is reported only once for each function it appears in
lib/mgmt_be_client.c:835:2: error: enumeration value '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE' not handled in switch [-Werror=switch-enum]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10489: lib/mgmt_be_client.lo] Error 1
lib/mgmt_fe_client.c: In function 'mgmt_fe_client_handle_msg':
lib/mgmt_fe_client.c:651:7: error: '_MGMTD__FE_MESSAGE__MESSAGE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__FE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE'?

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/CI101BUILD/config.status/config.status

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka long int} (strict match required [C]) [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10490: lib/mgmt_msg.lo] Error 1
In file included from ./lib/log.h:17,

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/DEB11AMD64/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/U1604I386/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/U18I386BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/U18I386BUILD/config.log/config.log.gz

Successful on other platforms/tests

• Ubuntu 22.04 amd64 build
• Ubuntu 20.04 amd64 build
• Ubuntu 18.04 arm8 build
• Debian 9 amd64 build
• Ubuntu 18.04 ppc64le build
• Fedora 29 amd64 build
• Debian 10 amd64 build
• CentOS 7 amd64 build
• Redhat 9 amd64 build
• Ubuntu 18.04 amd64 build
• Ubuntu 16.04 amd64 build
• FreeBSD 12 amd64 build
• Ubuntu 16.04 arm8 build
• Redhat 8 amd64 build
• OpenBSD 7 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.10269/frr-source'
lib/mgmt_be_client.c: In function 'mgmt_be_client_handle_msg':
lib/mgmt_be_client.c:878:7: error: '_MGMTD__BE_MESSAGE__MESSAGE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE'?
lib/mgmt_be_client.c:878:7: note: each undeclared identifier is reported only once for each function it appears in
lib/mgmt_be_client.c:835:2: error: enumeration value '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE' not handled in switch [-Werror=switch-enum]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10489: lib/mgmt_be_client.lo] Error 1
lib/mgmt_fe_client.c: In function 'mgmt_fe_client_handle_msg':
lib/mgmt_fe_client.c:651:7: error: '_MGMTD__FE_MESSAGE__MESSAGE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__FE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE'?

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/CI101BUILD/config.status/config.status

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka long int} (strict match required [C]) [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10490: lib/mgmt_msg.lo] Error 1
In file included from ./lib/log.h:17,

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/DEB11AMD64/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/U1604I386/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/U18I386BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10269/artifact/U18I386BUILD/config.log/config.log.gz

<stdin>:18244: trailing whitespace.
    
warning: 1 line adds whitespace errors.
Report for mgmt_be_adapter.c | 29 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#48: FILE: /tmp/f1-3710293/mgmt_be_adapter.c:48:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_be_adapters, &mgmt_be_adapters, (adapter))

ERROR: space required after that close brace '}'
#97: FILE: /tmp/f1-3710293/mgmt_be_adapter.c:97:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#104: FILE: /tmp/f1-3710293/mgmt_be_adapter.c:104:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#113: FILE: /tmp/f1-3710293/mgmt_be_adapter.c:113:
+			 MGMTD_BE_CLIENT_ID_MAX}},

WARNING: line over 80 characters
#363: FILE: /tmp/f1-3710293/mgmt_be_adapter.c:363:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#755: FILE: /tmp/f1-3710293/mgmt_be_adapter.c:755:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#768: FILE: /tmp/f1-3710293/mgmt_be_adapter.c:768:
+				 adapter, adapter->conn_fd, &adapter->conn_write_ev);
Report for mgmt_be_client.c | 23 issues
===============================================
WARNING: line over 80 characters
#40: FILE: /tmp/f1-3710293/mgmt_be_client.c:40:
+			zlog_debug("%s: " fmt, __func__, ##__VA_ARGS__);         \

ERROR: Macros with complex values should be enclosed in parentheses
#113: FILE: /tmp/f1-3710293/mgmt_be_client.c:113:
+#define FOREACH_BE_TXN_BATCH_IN_LIST(txn, batch)                               \
+	frr_each_safe (mgmt_be_batches, &(txn)->cfg_batches, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#116: FILE: /tmp/f1-3710293/mgmt_be_client.c:116:
+#define FOREACH_BE_APPLY_BATCH_IN_LIST(txn, batch)                             \
+	frr_each_safe (mgmt_be_batches, &(txn)->apply_cfgs, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#149: FILE: /tmp/f1-3710293/mgmt_be_client.c:149:
+#define FOREACH_BE_TXN_IN_LIST(client_ctx, txn)                                \
+	frr_each_safe (mgmt_be_txns, &(client_ctx)->txn_head, (txn))

WARNING: line over 80 characters
#613: FILE: /tmp/f1-3710293/mgmt_be_client.c:613:
+			client_ctx->avg_prep_nb_cfg_tm, (uint32_t)num_processed);
Report for mgmt_ds.c | 29 issues
===============================================
WARNING: Missing a blank line after declarations
#205: FILE: /tmp/f1-3710293/mgmt_ds.c:205:
+	struct lyd_node *dnode = mm->candidate_ds->root.cfg_root->dnode;
+	if (dnode)

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#293: FILE: /tmp/f1-3710293/mgmt_ds.c:293:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#295: FILE: /tmp/f1-3710293/mgmt_ds.c:295:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#303: FILE: /tmp/f1-3710293/mgmt_ds.c:303:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#305: FILE: /tmp/f1-3710293/mgmt_ds.c:305:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#313: FILE: /tmp/f1-3710293/mgmt_ds.c:313:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#321: FILE: /tmp/f1-3710293/mgmt_ds.c:321:
+		return EINVAL;
Report for mgmt_fe_adapter.c | 46 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#49: FILE: /tmp/f1-3710293/mgmt_fe_adapter.c:49:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_fe_adapters, &mgmt_fe_adapters, (adapter))

ERROR: Macros with complex values should be enclosed in parentheses
#74: FILE: /tmp/f1-3710293/mgmt_fe_adapter.c:74:
+#define FOREACH_SESSION_IN_LIST(adapter, session)                              \
+	frr_each_safe (mgmt_fe_sessions, &(adapter)->fe_sessions, (session))

WARNING: line over 80 characters
#510: FILE: /tmp/f1-3710293/mgmt_fe_adapter.c:510:
+			gettimeofday(&session->adapter->cmt_stats.last_end, NULL);

WARNING: line over 80 characters
#733: FILE: /tmp/f1-3710293/mgmt_fe_adapter.c:733:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#1126: FILE: /tmp/f1-3710293/mgmt_fe_adapter.c:1126:
+				session, getdata_req->ds_id, getdata_req->req_id,

WARNING: line over 80 characters
#1509: FILE: /tmp/f1-3710293/mgmt_fe_adapter.c:1509:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#1799: FILE: /tmp/f1-3710293/mgmt_fe_adapter.c:1799:
+					&adapter->cmt_stats.apply_cfg_start, buf,

WARNING: line over 80 characters
#1837: FILE: /tmp/f1-3710293/mgmt_fe_adapter.c:1837:
+			mgmt_realtime_to_string(&adapter->setcfg_stats.last_start,

WARNING: line over 80 characters
#1879: FILE: /tmp/f1-3710293/mgmt_fe_adapter.c:1879:
+						session->ds_locked_implict[ds_id]

WARNING: line over 80 characters
#1913: FILE: /tmp/f1-3710293/mgmt_fe_adapter.c:1913:
+		memset(&adapter->setcfg_stats, 0, sizeof(adapter->setcfg_stats));

WARNING: line over 80 characters
#1915: FILE: /tmp/f1-3710293/mgmt_fe_adapter.c:1915:
+			memset(&adapter->cmt_stats, 0, sizeof(adapter->cmt_stats));
Report for mgmt_fe_client.c | 25 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#82: FILE: /tmp/f1-3710293/mgmt_fe_client.c:82:
+#define FOREACH_SESSION_IN_LIST(client_ctx, session)                           \
+	frr_each_safe (mgmt_sessions, &(client_ctx)->client_sessions, (session))

WARNING: line over 80 characters
#125: FILE: /tmp/f1-3710293/mgmt_fe_client.c:125:
+				"Found session %p for session-id %llu.", session,

WARNING: line over 80 characters
#290: FILE: /tmp/f1-3710293/mgmt_fe_client.c:290:
+		lock ? "" : "UN", ds_id, (unsigned long long)session->client_id);

WARNING: line over 80 characters
#330: FILE: /tmp/f1-3710293/mgmt_fe_client.c:330:
+			       Mgmtd__DatastoreId dest_ds_id, bool validate_only,

WARNING: line over 80 characters
#463: FILE: /tmp/f1-3710293/mgmt_fe_client.c:463:
+						->session_reply->client_conn_id);

WARNING: line over 80 characters
#470: FILE: /tmp/f1-3710293/mgmt_fe_client.c:470:
+						->session_reply->client_conn_id);
Report for mgmt_history.c | 30 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#29: FILE: /tmp/f1-3710293/mgmt_history.c:29:
+#define FOREACH_CMT_REC(mm, cmt_info)                                          \
+	frr_each_safe (mgmt_cmt_infos, &mm->cmts, cmt_info)

ERROR: do not initialise statics to NULL
#36: FILE: /tmp/f1-3710293/mgmt_history.c:36:
+static struct vty *rollback_vty = NULL;

WARNING: line over 80 characters
#103: FILE: /tmp/f1-3710293/mgmt_history.c:103:
+static struct mgmt_cmt_info_t *mgmt_history_find_cmt_record(const char *cmtid_str)

WARNING: line over 80 characters
#132: FILE: /tmp/f1-3710293/mgmt_history.c:132:
+			if (!mgmt_history_record_exists(cmt_info.cmt_json_file)) {

WARNING: line over 80 characters
#284: FILE: /tmp/f1-3710293/mgmt_history.c:284:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: line over 80 characters
#323: FILE: /tmp/f1-3710293/mgmt_history.c:323:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: Missing a blank line after declarations
#358: FILE: /tmp/f1-3710293/mgmt_history.c:358:
+	struct mgmt_cmt_info_t *cmt_info = mgmt_history_create_cmt_rec();
+	mgmt_ds_dump_ds_to_file(cmt_info->cmt_json_file, ds_ctx);
Report for mgmt_history.h | 5 issues
===============================================
WARNING: Block comments should align the * on each line
#3: FILE: /tmp/f1-3710293/mgmt_history.h:3:
+/*
+  * Copyright (C) 2021  Vmware, Inc.
Report for mgmt_msg.c | 5 issues
===============================================
WARNING: else is not generally useful after a break or return
#226: FILE: /tmp/f1-3710293/mgmt_msg.c:226:
+				return MSW_SCHED_STREAM;
+			} else
Report for mgmt_txn.c | 20 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#120: FILE: /tmp/f1-3710293/mgmt_txn.c:120:
+#define FOREACH_TXN_CFG_BATCH_IN_LIST(list, batch)                             \
+	frr_each_safe (mgmt_txn_batches, list, batch)

ERROR: Macros with complex values should be enclosed in parentheses
#220: FILE: /tmp/f1-3710293/mgmt_txn.c:220:
+#define FOREACH_TXN_REQ_IN_LIST(list, req)                                     \
+	frr_each_safe (mgmt_txn_reqs, list, req)

ERROR: Macros with complex values should be enclosed in parentheses
#275: FILE: /tmp/f1-3710293/mgmt_txn.c:275:
+#define FOREACH_TXN_IN_LIST(mm, txn)                                           \
+	frr_each_safe (mgmt_txns, &(mm)->txn_list, (txn))

WARNING: Missing a blank line after declarations
#1271: FILE: /tmp/f1-3710293/mgmt_txn.c:1271:
+	char err_buf[1024] = {0};
+	nb_ctx.client = NB_CLIENT_MGMTD_SERVER;
Report for mgmt_vty.c | 10 issues
===============================================
WARNING: Missing a blank line after declarations
#404: FILE: /tmp/f1-3710293/mgmt_vty.c:404:
+	int n = mgmt_debug_be + mgmt_debug_fe + mgmt_debug_ds + mgmt_debug_txn;
+	if (!n)

WARNING: Missing a blank line after declarations
#439: FILE: /tmp/f1-3710293/mgmt_vty.c:439:
+	bool set = !no;
+	if (all)
Report for static_vty.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #385: FILE: /tmp/f1-3710293/static_vty.c:385:
< WARNING: line over 80 characters
< #407: FILE: /tmp/f1-3710293/static_vty.c:407:
Report for vty.c | 8 issues
===============================================
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3491: FILE: /tmp/f1-3710293/vty.c:3491:
< WARNING: line over 80 characters
< #3506: FILE: /tmp/f1-3710293/vty.c:3506:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3592: FILE: /tmp/f1-3710293/vty.c:3592:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3628: FILE: /tmp/f1-3710293/vty.c:3628:

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/CI101BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.10270/frr-source'
lib/mgmt_be_client.c: In function 'mgmt_be_client_handle_msg':
lib/mgmt_be_client.c:878:7: error: '_MGMTD__BE_MESSAGE__MESSAGE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE'?
lib/mgmt_be_client.c:878:7: note: each undeclared identifier is reported only once for each function it appears in
lib/mgmt_be_client.c:835:2: error: enumeration value '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE' not handled in switch [-Werror=switch-enum]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10489: lib/mgmt_be_client.lo] Error 1
lib/mgmt_fe_client.c: In function 'mgmt_fe_client_handle_msg':
lib/mgmt_fe_client.c:651:7: error: '_MGMTD__FE_MESSAGE__MESSAGE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__FE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE'?

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/U1604I386/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka long int} (strict match required [C]) [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10490: lib/mgmt_msg.lo] Error 1
In file included from ./lib/log.h:17,

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/DEB11AMD64/config.status/config.status

Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/U18I386BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/U18I386BUILD/config.log/config.log.gz

Successful on other platforms/tests

• Ubuntu 20.04 amd64 build
• Ubuntu 22.04 amd64 build
• Ubuntu 18.04 arm8 build
• Debian 9 amd64 build
• Ubuntu 18.04 ppc64le build
• Fedora 29 amd64 build
• Debian 10 amd64 build
• CentOS 7 amd64 build
• Ubuntu 16.04 arm8 build
• Ubuntu 18.04 amd64 build
• Redhat 9 amd64 build
• OpenBSD 7 amd64 build
• Ubuntu 16.04 amd64 build
• FreeBSD 12 amd64 build
• Redhat 8 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/CI101BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.10270/frr-source'
lib/mgmt_be_client.c: In function 'mgmt_be_client_handle_msg':
lib/mgmt_be_client.c:878:7: error: '_MGMTD__BE_MESSAGE__MESSAGE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE'?
lib/mgmt_be_client.c:878:7: note: each undeclared identifier is reported only once for each function it appears in
lib/mgmt_be_client.c:835:2: error: enumeration value '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE' not handled in switch [-Werror=switch-enum]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10489: lib/mgmt_be_client.lo] Error 1
lib/mgmt_fe_client.c: In function 'mgmt_fe_client_handle_msg':
lib/mgmt_fe_client.c:651:7: error: '_MGMTD__FE_MESSAGE__MESSAGE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__FE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE'?

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/U1604I386/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka long int} (strict match required [C]) [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10490: lib/mgmt_msg.lo] Error 1
In file included from ./lib/log.h:17,

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/DEB11AMD64/config.status/config.status

Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/U18I386BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10270/artifact/U18I386BUILD/config.log/config.log.gz

<stdin>:18244: trailing whitespace.
    
warning: 1 line adds whitespace errors.
Report for mgmt_be_adapter.c | 29 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#48: FILE: /tmp/f1-3809953/mgmt_be_adapter.c:48:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_be_adapters, &mgmt_be_adapters, (adapter))

ERROR: space required after that close brace '}'
#97: FILE: /tmp/f1-3809953/mgmt_be_adapter.c:97:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#104: FILE: /tmp/f1-3809953/mgmt_be_adapter.c:104:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#113: FILE: /tmp/f1-3809953/mgmt_be_adapter.c:113:
+			 MGMTD_BE_CLIENT_ID_MAX}},

WARNING: line over 80 characters
#363: FILE: /tmp/f1-3809953/mgmt_be_adapter.c:363:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#755: FILE: /tmp/f1-3809953/mgmt_be_adapter.c:755:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#768: FILE: /tmp/f1-3809953/mgmt_be_adapter.c:768:
+				 adapter, adapter->conn_fd, &adapter->conn_write_ev);
Report for mgmt_be_client.c | 23 issues
===============================================
WARNING: line over 80 characters
#40: FILE: /tmp/f1-3809953/mgmt_be_client.c:40:
+			zlog_debug("%s: " fmt, __func__, ##__VA_ARGS__);         \

ERROR: Macros with complex values should be enclosed in parentheses
#113: FILE: /tmp/f1-3809953/mgmt_be_client.c:113:
+#define FOREACH_BE_TXN_BATCH_IN_LIST(txn, batch)                               \
+	frr_each_safe (mgmt_be_batches, &(txn)->cfg_batches, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#116: FILE: /tmp/f1-3809953/mgmt_be_client.c:116:
+#define FOREACH_BE_APPLY_BATCH_IN_LIST(txn, batch)                             \
+	frr_each_safe (mgmt_be_batches, &(txn)->apply_cfgs, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#149: FILE: /tmp/f1-3809953/mgmt_be_client.c:149:
+#define FOREACH_BE_TXN_IN_LIST(client_ctx, txn)                                \
+	frr_each_safe (mgmt_be_txns, &(client_ctx)->txn_head, (txn))

WARNING: line over 80 characters
#613: FILE: /tmp/f1-3809953/mgmt_be_client.c:613:
+			client_ctx->avg_prep_nb_cfg_tm, (uint32_t)num_processed);
Report for mgmt_ds.c | 29 issues
===============================================
WARNING: Missing a blank line after declarations
#205: FILE: /tmp/f1-3809953/mgmt_ds.c:205:
+	struct lyd_node *dnode = mm->candidate_ds->root.cfg_root->dnode;
+	if (dnode)

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#293: FILE: /tmp/f1-3809953/mgmt_ds.c:293:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#295: FILE: /tmp/f1-3809953/mgmt_ds.c:295:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#303: FILE: /tmp/f1-3809953/mgmt_ds.c:303:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#305: FILE: /tmp/f1-3809953/mgmt_ds.c:305:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#313: FILE: /tmp/f1-3809953/mgmt_ds.c:313:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#321: FILE: /tmp/f1-3809953/mgmt_ds.c:321:
+		return EINVAL;
Report for mgmt_fe_adapter.c | 46 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#49: FILE: /tmp/f1-3809953/mgmt_fe_adapter.c:49:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_fe_adapters, &mgmt_fe_adapters, (adapter))

ERROR: Macros with complex values should be enclosed in parentheses
#74: FILE: /tmp/f1-3809953/mgmt_fe_adapter.c:74:
+#define FOREACH_SESSION_IN_LIST(adapter, session)                              \
+	frr_each_safe (mgmt_fe_sessions, &(adapter)->fe_sessions, (session))

WARNING: line over 80 characters
#510: FILE: /tmp/f1-3809953/mgmt_fe_adapter.c:510:
+			gettimeofday(&session->adapter->cmt_stats.last_end, NULL);

WARNING: line over 80 characters
#733: FILE: /tmp/f1-3809953/mgmt_fe_adapter.c:733:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#1126: FILE: /tmp/f1-3809953/mgmt_fe_adapter.c:1126:
+				session, getdata_req->ds_id, getdata_req->req_id,

WARNING: line over 80 characters
#1509: FILE: /tmp/f1-3809953/mgmt_fe_adapter.c:1509:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#1799: FILE: /tmp/f1-3809953/mgmt_fe_adapter.c:1799:
+					&adapter->cmt_stats.apply_cfg_start, buf,

WARNING: line over 80 characters
#1837: FILE: /tmp/f1-3809953/mgmt_fe_adapter.c:1837:
+			mgmt_realtime_to_string(&adapter->setcfg_stats.last_start,

WARNING: line over 80 characters
#1879: FILE: /tmp/f1-3809953/mgmt_fe_adapter.c:1879:
+						session->ds_locked_implict[ds_id]

WARNING: line over 80 characters
#1913: FILE: /tmp/f1-3809953/mgmt_fe_adapter.c:1913:
+		memset(&adapter->setcfg_stats, 0, sizeof(adapter->setcfg_stats));

WARNING: line over 80 characters
#1915: FILE: /tmp/f1-3809953/mgmt_fe_adapter.c:1915:
+			memset(&adapter->cmt_stats, 0, sizeof(adapter->cmt_stats));
Report for mgmt_fe_client.c | 25 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#82: FILE: /tmp/f1-3809953/mgmt_fe_client.c:82:
+#define FOREACH_SESSION_IN_LIST(client_ctx, session)                           \
+	frr_each_safe (mgmt_sessions, &(client_ctx)->client_sessions, (session))

WARNING: line over 80 characters
#125: FILE: /tmp/f1-3809953/mgmt_fe_client.c:125:
+				"Found session %p for session-id %llu.", session,

WARNING: line over 80 characters
#290: FILE: /tmp/f1-3809953/mgmt_fe_client.c:290:
+		lock ? "" : "UN", ds_id, (unsigned long long)session->client_id);

WARNING: line over 80 characters
#330: FILE: /tmp/f1-3809953/mgmt_fe_client.c:330:
+			       Mgmtd__DatastoreId dest_ds_id, bool validate_only,

WARNING: line over 80 characters
#463: FILE: /tmp/f1-3809953/mgmt_fe_client.c:463:
+						->session_reply->client_conn_id);

WARNING: line over 80 characters
#470: FILE: /tmp/f1-3809953/mgmt_fe_client.c:470:
+						->session_reply->client_conn_id);
Report for mgmt_history.c | 30 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#29: FILE: /tmp/f1-3809953/mgmt_history.c:29:
+#define FOREACH_CMT_REC(mm, cmt_info)                                          \
+	frr_each_safe (mgmt_cmt_infos, &mm->cmts, cmt_info)

ERROR: do not initialise statics to NULL
#36: FILE: /tmp/f1-3809953/mgmt_history.c:36:
+static struct vty *rollback_vty = NULL;

WARNING: line over 80 characters
#103: FILE: /tmp/f1-3809953/mgmt_history.c:103:
+static struct mgmt_cmt_info_t *mgmt_history_find_cmt_record(const char *cmtid_str)

WARNING: line over 80 characters
#132: FILE: /tmp/f1-3809953/mgmt_history.c:132:
+			if (!mgmt_history_record_exists(cmt_info.cmt_json_file)) {

WARNING: line over 80 characters
#284: FILE: /tmp/f1-3809953/mgmt_history.c:284:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: line over 80 characters
#323: FILE: /tmp/f1-3809953/mgmt_history.c:323:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: Missing a blank line after declarations
#358: FILE: /tmp/f1-3809953/mgmt_history.c:358:
+	struct mgmt_cmt_info_t *cmt_info = mgmt_history_create_cmt_rec();
+	mgmt_ds_dump_ds_to_file(cmt_info->cmt_json_file, ds_ctx);
Report for mgmt_history.h | 5 issues
===============================================
WARNING: Block comments should align the * on each line
#3: FILE: /tmp/f1-3809953/mgmt_history.h:3:
+/*
+  * Copyright (C) 2021  Vmware, Inc.
Report for mgmt_msg.c | 5 issues
===============================================
WARNING: else is not generally useful after a break or return
#226: FILE: /tmp/f1-3809953/mgmt_msg.c:226:
+				return MSW_SCHED_STREAM;
+			} else
Report for mgmt_txn.c | 20 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#120: FILE: /tmp/f1-3809953/mgmt_txn.c:120:
+#define FOREACH_TXN_CFG_BATCH_IN_LIST(list, batch)                             \
+	frr_each_safe (mgmt_txn_batches, list, batch)

ERROR: Macros with complex values should be enclosed in parentheses
#220: FILE: /tmp/f1-3809953/mgmt_txn.c:220:
+#define FOREACH_TXN_REQ_IN_LIST(list, req)                                     \
+	frr_each_safe (mgmt_txn_reqs, list, req)

ERROR: Macros with complex values should be enclosed in parentheses
#275: FILE: /tmp/f1-3809953/mgmt_txn.c:275:
+#define FOREACH_TXN_IN_LIST(mm, txn)                                           \
+	frr_each_safe (mgmt_txns, &(mm)->txn_list, (txn))

WARNING: Missing a blank line after declarations
#1271: FILE: /tmp/f1-3809953/mgmt_txn.c:1271:
+	char err_buf[1024] = {0};
+	nb_ctx.client = NB_CLIENT_MGMTD_SERVER;
Report for mgmt_vty.c | 10 issues
===============================================
WARNING: Missing a blank line after declarations
#404: FILE: /tmp/f1-3809953/mgmt_vty.c:404:
+	int n = mgmt_debug_be + mgmt_debug_fe + mgmt_debug_ds + mgmt_debug_txn;
+	if (!n)

WARNING: Missing a blank line after declarations
#439: FILE: /tmp/f1-3809953/mgmt_vty.c:439:
+	bool set = !no;
+	if (all)
Report for static_vty.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #385: FILE: /tmp/f1-3809953/static_vty.c:385:
< WARNING: line over 80 characters
< #407: FILE: /tmp/f1-3809953/static_vty.c:407:
Report for vty.c | 8 issues
===============================================
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3491: FILE: /tmp/f1-3809953/vty.c:3491:
< WARNING: line over 80 characters
< #3506: FILE: /tmp/f1-3809953/vty.c:3506:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3592: FILE: /tmp/f1-3809953/vty.c:3592:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3628: FILE: /tmp/f1-3809953/vty.c:3628:

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/CI101BUILD/config.status/config.status

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka long int} (strict match required [C]) [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10490: lib/mgmt_msg.lo] Error 1
In file included from ./lib/log.h:17,

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/DEB11AMD64/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.10271/frr-source'
lib/mgmt_be_client.c: In function 'mgmt_be_client_handle_msg':
lib/mgmt_be_client.c:878:7: error: '_MGMTD__BE_MESSAGE__MESSAGE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE'?
lib/mgmt_be_client.c:878:7: note: each undeclared identifier is reported only once for each function it appears in
lib/mgmt_be_client.c:835:2: error: enumeration value '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE' not handled in switch [-Werror=switch-enum]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10489: lib/mgmt_be_client.lo] Error 1
lib/mgmt_fe_client.c: In function 'mgmt_fe_client_handle_msg':
lib/mgmt_fe_client.c:651:7: error: '_MGMTD__FE_MESSAGE__MESSAGE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__FE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE'?

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/U1604I386/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/U18I386BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/U18I386BUILD/config.log/config.log.gz

Successful on other platforms/tests

• Ubuntu 22.04 amd64 build
• Fedora 29 amd64 build
• Ubuntu 18.04 arm8 build
• Debian 9 amd64 build
• Ubuntu 20.04 amd64 build
• Ubuntu 18.04 ppc64le build
• Debian 10 amd64 build
• CentOS 7 amd64 build
• Ubuntu 18.04 amd64 build
• Ubuntu 16.04 arm8 build
• Ubuntu 16.04 amd64 build
• Redhat 9 amd64 build
• OpenBSD 7 amd64 build
• Redhat 8 amd64 build
• FreeBSD 12 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 16.04 arm7 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/CI101BUILD/config.log/config.log.gz
Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/CI101BUILD/config.status/config.status

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka long int} (strict match required [C]) [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10490: lib/mgmt_msg.lo] Error 1
In file included from ./lib/log.h:17,

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/DEB11AMD64/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.10271/frr-source'
lib/mgmt_be_client.c: In function 'mgmt_be_client_handle_msg':
lib/mgmt_be_client.c:878:7: error: '_MGMTD__BE_MESSAGE__MESSAGE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE'?
lib/mgmt_be_client.c:878:7: note: each undeclared identifier is reported only once for each function it appears in
lib/mgmt_be_client.c:835:2: error: enumeration value '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE' not handled in switch [-Werror=switch-enum]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10489: lib/mgmt_be_client.lo] Error 1
lib/mgmt_fe_client.c: In function 'mgmt_fe_client_handle_msg':
lib/mgmt_fe_client.c:651:7: error: '_MGMTD__FE_MESSAGE__MESSAGE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__FE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE'?

Ubuntu 18.04 arm7 build: Failed (click for details)

Ubuntu 18.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/U18ARM7BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/U18ARM7BUILD/config.log/config.log.gz

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/U1604I386/config.log/config.log.gz Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/U1604I386/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 18.04 i386 build: Failed (click for details)

Make failed for Ubuntu 18.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/U18I386BUILD/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17:0,
lib/mgmt_msg.c: In function mgmt_msg_read:
./lib/zlog.h:109:20: error: format %ld expects argument of type long int, but argument 5 has type ssize_t {aka int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
 #define zlog_debug(...)  _zlog_ecref(0, LOG_DEBUG, __VA_ARGS__)
lib/mgmt_msg.c:21:4: note: in expansion of macro zlog_debug
lib/mgmt_msg.c:60:3: note: in expansion of macro MGMT_MSG_DBG
lib/mgmt_msg.c:89:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors

Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/U18I386BUILD/config.status/config.status
Ubuntu 18.04 i386 build: Unknown Log <config.log.gz>
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10271/artifact/U18I386BUILD/config.log/config.log.gz

<stdin>:18219: trailing whitespace.
    
warning: 1 line adds whitespace errors.
Report for mgmt_be_adapter.c | 29 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#48: FILE: /tmp/f1-4003666/mgmt_be_adapter.c:48:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_be_adapters, &mgmt_be_adapters, (adapter))

ERROR: space required after that close brace '}'
#97: FILE: /tmp/f1-4003666/mgmt_be_adapter.c:97:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#104: FILE: /tmp/f1-4003666/mgmt_be_adapter.c:104:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#113: FILE: /tmp/f1-4003666/mgmt_be_adapter.c:113:
+			 MGMTD_BE_CLIENT_ID_MAX}},

WARNING: line over 80 characters
#363: FILE: /tmp/f1-4003666/mgmt_be_adapter.c:363:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#755: FILE: /tmp/f1-4003666/mgmt_be_adapter.c:755:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#768: FILE: /tmp/f1-4003666/mgmt_be_adapter.c:768:
+				 adapter, adapter->conn_fd, &adapter->conn_write_ev);
Report for mgmt_be_client.c | 23 issues
===============================================
WARNING: line over 80 characters
#40: FILE: /tmp/f1-4003666/mgmt_be_client.c:40:
+			zlog_debug("%s: " fmt, __func__, ##__VA_ARGS__);         \

ERROR: Macros with complex values should be enclosed in parentheses
#113: FILE: /tmp/f1-4003666/mgmt_be_client.c:113:
+#define FOREACH_BE_TXN_BATCH_IN_LIST(txn, batch)                               \
+	frr_each_safe (mgmt_be_batches, &(txn)->cfg_batches, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#116: FILE: /tmp/f1-4003666/mgmt_be_client.c:116:
+#define FOREACH_BE_APPLY_BATCH_IN_LIST(txn, batch)                             \
+	frr_each_safe (mgmt_be_batches, &(txn)->apply_cfgs, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#149: FILE: /tmp/f1-4003666/mgmt_be_client.c:149:
+#define FOREACH_BE_TXN_IN_LIST(client_ctx, txn)                                \
+	frr_each_safe (mgmt_be_txns, &(client_ctx)->txn_head, (txn))

WARNING: line over 80 characters
#613: FILE: /tmp/f1-4003666/mgmt_be_client.c:613:
+			client_ctx->avg_prep_nb_cfg_tm, (uint32_t)num_processed);
Report for mgmt_ds.c | 29 issues
===============================================
WARNING: Missing a blank line after declarations
#205: FILE: /tmp/f1-4003666/mgmt_ds.c:205:
+	struct lyd_node *dnode = mm->candidate_ds->root.cfg_root->dnode;
+	if (dnode)

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#293: FILE: /tmp/f1-4003666/mgmt_ds.c:293:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#295: FILE: /tmp/f1-4003666/mgmt_ds.c:295:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#303: FILE: /tmp/f1-4003666/mgmt_ds.c:303:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#305: FILE: /tmp/f1-4003666/mgmt_ds.c:305:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#313: FILE: /tmp/f1-4003666/mgmt_ds.c:313:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#321: FILE: /tmp/f1-4003666/mgmt_ds.c:321:
+		return EINVAL;
Report for mgmt_fe_adapter.c | 46 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#49: FILE: /tmp/f1-4003666/mgmt_fe_adapter.c:49:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_fe_adapters, &mgmt_fe_adapters, (adapter))

ERROR: Macros with complex values should be enclosed in parentheses
#74: FILE: /tmp/f1-4003666/mgmt_fe_adapter.c:74:
+#define FOREACH_SESSION_IN_LIST(adapter, session)                              \
+	frr_each_safe (mgmt_fe_sessions, &(adapter)->fe_sessions, (session))

WARNING: line over 80 characters
#510: FILE: /tmp/f1-4003666/mgmt_fe_adapter.c:510:
+			gettimeofday(&session->adapter->cmt_stats.last_end, NULL);

WARNING: line over 80 characters
#733: FILE: /tmp/f1-4003666/mgmt_fe_adapter.c:733:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#1126: FILE: /tmp/f1-4003666/mgmt_fe_adapter.c:1126:
+				session, getdata_req->ds_id, getdata_req->req_id,

WARNING: line over 80 characters
#1509: FILE: /tmp/f1-4003666/mgmt_fe_adapter.c:1509:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#1799: FILE: /tmp/f1-4003666/mgmt_fe_adapter.c:1799:
+					&adapter->cmt_stats.apply_cfg_start, buf,

WARNING: line over 80 characters
#1837: FILE: /tmp/f1-4003666/mgmt_fe_adapter.c:1837:
+			mgmt_realtime_to_string(&adapter->setcfg_stats.last_start,

WARNING: line over 80 characters
#1879: FILE: /tmp/f1-4003666/mgmt_fe_adapter.c:1879:
+						session->ds_locked_implict[ds_id]

WARNING: line over 80 characters
#1913: FILE: /tmp/f1-4003666/mgmt_fe_adapter.c:1913:
+		memset(&adapter->setcfg_stats, 0, sizeof(adapter->setcfg_stats));

WARNING: line over 80 characters
#1915: FILE: /tmp/f1-4003666/mgmt_fe_adapter.c:1915:
+			memset(&adapter->cmt_stats, 0, sizeof(adapter->cmt_stats));
Report for mgmt_fe_client.c | 25 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#82: FILE: /tmp/f1-4003666/mgmt_fe_client.c:82:
+#define FOREACH_SESSION_IN_LIST(client_ctx, session)                           \
+	frr_each_safe (mgmt_sessions, &(client_ctx)->client_sessions, (session))

WARNING: line over 80 characters
#125: FILE: /tmp/f1-4003666/mgmt_fe_client.c:125:
+				"Found session %p for session-id %llu.", session,

WARNING: line over 80 characters
#290: FILE: /tmp/f1-4003666/mgmt_fe_client.c:290:
+		lock ? "" : "UN", ds_id, (unsigned long long)session->client_id);

WARNING: line over 80 characters
#330: FILE: /tmp/f1-4003666/mgmt_fe_client.c:330:
+			       Mgmtd__DatastoreId dest_ds_id, bool validate_only,

WARNING: line over 80 characters
#463: FILE: /tmp/f1-4003666/mgmt_fe_client.c:463:
+						->session_reply->client_conn_id);

WARNING: line over 80 characters
#470: FILE: /tmp/f1-4003666/mgmt_fe_client.c:470:
+						->session_reply->client_conn_id);
Report for mgmt_history.c | 30 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#29: FILE: /tmp/f1-4003666/mgmt_history.c:29:
+#define FOREACH_CMT_REC(mm, cmt_info)                                          \
+	frr_each_safe (mgmt_cmt_infos, &mm->cmts, cmt_info)

ERROR: do not initialise statics to NULL
#36: FILE: /tmp/f1-4003666/mgmt_history.c:36:
+static struct vty *rollback_vty = NULL;

WARNING: line over 80 characters
#103: FILE: /tmp/f1-4003666/mgmt_history.c:103:
+static struct mgmt_cmt_info_t *mgmt_history_find_cmt_record(const char *cmtid_str)

WARNING: line over 80 characters
#132: FILE: /tmp/f1-4003666/mgmt_history.c:132:
+			if (!mgmt_history_record_exists(cmt_info.cmt_json_file)) {

WARNING: line over 80 characters
#284: FILE: /tmp/f1-4003666/mgmt_history.c:284:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: line over 80 characters
#323: FILE: /tmp/f1-4003666/mgmt_history.c:323:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: Missing a blank line after declarations
#358: FILE: /tmp/f1-4003666/mgmt_history.c:358:
+	struct mgmt_cmt_info_t *cmt_info = mgmt_history_create_cmt_rec();
+	mgmt_ds_dump_ds_to_file(cmt_info->cmt_json_file, ds_ctx);
Report for mgmt_history.h | 5 issues
===============================================
WARNING: Block comments should align the * on each line
#3: FILE: /tmp/f1-4003666/mgmt_history.h:3:
+/*
+  * Copyright (C) 2021  Vmware, Inc.
Report for mgmt_msg.c | 5 issues
===============================================
WARNING: else is not generally useful after a break or return
#226: FILE: /tmp/f1-4003666/mgmt_msg.c:226:
+				return MSW_SCHED_STREAM;
+			} else
Report for mgmt_txn.c | 20 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#120: FILE: /tmp/f1-4003666/mgmt_txn.c:120:
+#define FOREACH_TXN_CFG_BATCH_IN_LIST(list, batch)                             \
+	frr_each_safe (mgmt_txn_batches, list, batch)

ERROR: Macros with complex values should be enclosed in parentheses
#220: FILE: /tmp/f1-4003666/mgmt_txn.c:220:
+#define FOREACH_TXN_REQ_IN_LIST(list, req)                                     \
+	frr_each_safe (mgmt_txn_reqs, list, req)

ERROR: Macros with complex values should be enclosed in parentheses
#275: FILE: /tmp/f1-4003666/mgmt_txn.c:275:
+#define FOREACH_TXN_IN_LIST(mm, txn)                                           \
+	frr_each_safe (mgmt_txns, &(mm)->txn_list, (txn))

WARNING: Missing a blank line after declarations
#1271: FILE: /tmp/f1-4003666/mgmt_txn.c:1271:
+	char err_buf[1024] = {0};
+	nb_ctx.client = NB_CLIENT_MGMTD_SERVER;
Report for mgmt_vty.c | 10 issues
===============================================
WARNING: Missing a blank line after declarations
#404: FILE: /tmp/f1-4003666/mgmt_vty.c:404:
+	int n = mgmt_debug_be + mgmt_debug_fe + mgmt_debug_ds + mgmt_debug_txn;
+	if (!n)

WARNING: Missing a blank line after declarations
#439: FILE: /tmp/f1-4003666/mgmt_vty.c:439:
+	bool set = !no;
+	if (all)
Report for static_vty.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #385: FILE: /tmp/f1-4003666/static_vty.c:385:
< WARNING: line over 80 characters
< #407: FILE: /tmp/f1-4003666/static_vty.c:407:
Report for vty.c | 8 issues
===============================================
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3491: FILE: /tmp/f1-4003666/vty.c:3491:
< WARNING: line over 80 characters
< #3506: FILE: /tmp/f1-4003666/vty.c:3506:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3592: FILE: /tmp/f1-4003666/vty.c:3592:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3628: FILE: /tmp/f1-4003666/vty.c:3628:

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10279/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10279/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10279/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10279/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.10279/frr-source'
lib/mgmt_be_client.c: In function 'mgmt_be_client_handle_msg':
lib/mgmt_be_client.c:879:7: error: '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__BE_MESSAGE__MESSAGE_IS_INT_SIZE'?
lib/mgmt_be_client.c:879:7: note: each undeclared identifier is reported only once for each function it appears in
lib/mgmt_be_client.c:835:2: error: enumeration value '_MGMTD__BE_MESSAGE__MESSAGE_IS_INT_SIZE' not handled in switch [-Werror=switch-enum]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10486: lib/mgmt_be_client.lo] Error 1
lib/mgmt_fe_client.c: In function 'mgmt_fe_client_handle_msg':
lib/mgmt_fe_client.c:652:7: error: '_MGMTD__FE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__FE_MESSAGE__MESSAGE_IS_INT_SIZE'?

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10279/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10279/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
mgmtd/mgmt_fe_adapter.c: In function mgmt_fe_session_handle_commit_config_req_msg:
./lib/zlog.h:109:20: error: format %llu expects argument of type long long unsigned int, but argument 4 has type uint64_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
mgmtd/mgmt_fe_adapter.c:43:4: note: in expansion of macro zlog_debug
mgmtd/mgmt_fe_adapter.c:1237:3: note: in expansion of macro MGMTD_FE_ADAPTER_DBG
 1237 |   MGMTD_FE_ADAPTER_DBG(
./lib/zlog.h:109:20: error: format %llu expects argument of type long long unsigned int, but argument 5 has type uint64_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10279/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests

• OpenBSD 7 amd64 build
• Redhat 8 amd64 build
• Debian 10 amd64 build
• CentOS 7 amd64 build
• Ubuntu 16.04 arm7 build
• FreeBSD 11 amd64 build
• Ubuntu 22.04 amd64 build
• Debian 9 amd64 build
• Ubuntu 18.04 amd64 build
• Ubuntu 16.04 arm8 build
• Ubuntu 16.04 amd64 build
• Ubuntu 20.04 amd64 build
• Redhat 9 amd64 build
• Ubuntu 18.04 ppc64le build
• Ubuntu 18.04 i386 build
• Ubuntu 18.04 arm7 build
• Fedora 29 amd64 build
• Ubuntu 16.04 i386 build
• Ubuntu 18.04 arm8 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10279/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10279/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10279/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.10279/frr-source'
lib/mgmt_be_client.c: In function 'mgmt_be_client_handle_msg':
lib/mgmt_be_client.c:879:7: error: '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__BE_MESSAGE__MESSAGE_IS_INT_SIZE'?
lib/mgmt_be_client.c:879:7: note: each undeclared identifier is reported only once for each function it appears in
lib/mgmt_be_client.c:835:2: error: enumeration value '_MGMTD__BE_MESSAGE__MESSAGE_IS_INT_SIZE' not handled in switch [-Werror=switch-enum]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10486: lib/mgmt_be_client.lo] Error 1
lib/mgmt_fe_client.c: In function 'mgmt_fe_client_handle_msg':
lib/mgmt_fe_client.c:652:7: error: '_MGMTD__FE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__FE_MESSAGE__MESSAGE_IS_INT_SIZE'?

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10279/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10279/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
mgmtd/mgmt_fe_adapter.c: In function mgmt_fe_session_handle_commit_config_req_msg:
./lib/zlog.h:109:20: error: format %llu expects argument of type long long unsigned int, but argument 4 has type uint64_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
mgmtd/mgmt_fe_adapter.c:43:4: note: in expansion of macro zlog_debug
mgmtd/mgmt_fe_adapter.c:1237:3: note: in expansion of macro MGMTD_FE_ADAPTER_DBG
 1237 |   MGMTD_FE_ADAPTER_DBG(
./lib/zlog.h:109:20: error: format %llu expects argument of type long long unsigned int, but argument 5 has type uint64_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10279/artifact/DEB11AMD64/config.status/config.status

<stdin>:18235: trailing whitespace.
    
warning: 1 line adds whitespace errors.
Report for mgmt_be_adapter.c | 29 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#48: FILE: /tmp/f1-1256641/mgmt_be_adapter.c:48:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_be_adapters, &mgmt_be_adapters, (adapter))

ERROR: space required after that close brace '}'
#97: FILE: /tmp/f1-1256641/mgmt_be_adapter.c:97:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#104: FILE: /tmp/f1-1256641/mgmt_be_adapter.c:104:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#113: FILE: /tmp/f1-1256641/mgmt_be_adapter.c:113:
+			 MGMTD_BE_CLIENT_ID_MAX}},

WARNING: line over 80 characters
#363: FILE: /tmp/f1-1256641/mgmt_be_adapter.c:363:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#759: FILE: /tmp/f1-1256641/mgmt_be_adapter.c:759:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#772: FILE: /tmp/f1-1256641/mgmt_be_adapter.c:772:
+				 adapter, adapter->conn_fd, &adapter->conn_write_ev);
Report for mgmt_be_client.c | 23 issues
===============================================
WARNING: line over 80 characters
#40: FILE: /tmp/f1-1256641/mgmt_be_client.c:40:
+			zlog_debug("%s: " fmt, __func__, ##__VA_ARGS__);         \

ERROR: Macros with complex values should be enclosed in parentheses
#113: FILE: /tmp/f1-1256641/mgmt_be_client.c:113:
+#define FOREACH_BE_TXN_BATCH_IN_LIST(txn, batch)                               \
+	frr_each_safe (mgmt_be_batches, &(txn)->cfg_batches, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#116: FILE: /tmp/f1-1256641/mgmt_be_client.c:116:
+#define FOREACH_BE_APPLY_BATCH_IN_LIST(txn, batch)                             \
+	frr_each_safe (mgmt_be_batches, &(txn)->apply_cfgs, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#149: FILE: /tmp/f1-1256641/mgmt_be_client.c:149:
+#define FOREACH_BE_TXN_IN_LIST(client_ctx, txn)                                \
+	frr_each_safe (mgmt_be_txns, &(client_ctx)->txn_head, (txn))

WARNING: line over 80 characters
#613: FILE: /tmp/f1-1256641/mgmt_be_client.c:613:
+			client_ctx->avg_prep_nb_cfg_tm, (uint32_t)num_processed);
Report for mgmt_ds.c | 29 issues
===============================================
WARNING: Missing a blank line after declarations
#205: FILE: /tmp/f1-1256641/mgmt_ds.c:205:
+	struct lyd_node *dnode = mm->candidate_ds->root.cfg_root->dnode;
+	if (dnode)

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#293: FILE: /tmp/f1-1256641/mgmt_ds.c:293:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#295: FILE: /tmp/f1-1256641/mgmt_ds.c:295:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#303: FILE: /tmp/f1-1256641/mgmt_ds.c:303:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#305: FILE: /tmp/f1-1256641/mgmt_ds.c:305:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#313: FILE: /tmp/f1-1256641/mgmt_ds.c:313:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#321: FILE: /tmp/f1-1256641/mgmt_ds.c:321:
+		return EINVAL;
Report for mgmt_fe_adapter.c | 46 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#49: FILE: /tmp/f1-1256641/mgmt_fe_adapter.c:49:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_fe_adapters, &mgmt_fe_adapters, (adapter))

ERROR: Macros with complex values should be enclosed in parentheses
#74: FILE: /tmp/f1-1256641/mgmt_fe_adapter.c:74:
+#define FOREACH_SESSION_IN_LIST(adapter, session)                              \
+	frr_each_safe (mgmt_fe_sessions, &(adapter)->fe_sessions, (session))

WARNING: line over 80 characters
#510: FILE: /tmp/f1-1256641/mgmt_fe_adapter.c:510:
+			gettimeofday(&session->adapter->cmt_stats.last_end, NULL);

WARNING: line over 80 characters
#733: FILE: /tmp/f1-1256641/mgmt_fe_adapter.c:733:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#1126: FILE: /tmp/f1-1256641/mgmt_fe_adapter.c:1126:
+				session, getdata_req->ds_id, getdata_req->req_id,

WARNING: line over 80 characters
#1513: FILE: /tmp/f1-1256641/mgmt_fe_adapter.c:1513:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#1803: FILE: /tmp/f1-1256641/mgmt_fe_adapter.c:1803:
+					&adapter->cmt_stats.apply_cfg_start, buf,

WARNING: line over 80 characters
#1841: FILE: /tmp/f1-1256641/mgmt_fe_adapter.c:1841:
+			mgmt_realtime_to_string(&adapter->setcfg_stats.last_start,

WARNING: line over 80 characters
#1883: FILE: /tmp/f1-1256641/mgmt_fe_adapter.c:1883:
+						session->ds_locked_implict[ds_id]

WARNING: line over 80 characters
#1917: FILE: /tmp/f1-1256641/mgmt_fe_adapter.c:1917:
+		memset(&adapter->setcfg_stats, 0, sizeof(adapter->setcfg_stats));

WARNING: line over 80 characters
#1919: FILE: /tmp/f1-1256641/mgmt_fe_adapter.c:1919:
+			memset(&adapter->cmt_stats, 0, sizeof(adapter->cmt_stats));
Report for mgmt_fe_client.c | 25 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#82: FILE: /tmp/f1-1256641/mgmt_fe_client.c:82:
+#define FOREACH_SESSION_IN_LIST(client_ctx, session)                           \
+	frr_each_safe (mgmt_sessions, &(client_ctx)->client_sessions, (session))

WARNING: line over 80 characters
#125: FILE: /tmp/f1-1256641/mgmt_fe_client.c:125:
+				"Found session %p for session-id %llu.", session,

WARNING: line over 80 characters
#290: FILE: /tmp/f1-1256641/mgmt_fe_client.c:290:
+		lock ? "" : "UN", ds_id, (unsigned long long)session->client_id);

WARNING: line over 80 characters
#330: FILE: /tmp/f1-1256641/mgmt_fe_client.c:330:
+			       Mgmtd__DatastoreId dest_ds_id, bool validate_only,

WARNING: line over 80 characters
#463: FILE: /tmp/f1-1256641/mgmt_fe_client.c:463:
+						->session_reply->client_conn_id);

WARNING: line over 80 characters
#470: FILE: /tmp/f1-1256641/mgmt_fe_client.c:470:
+						->session_reply->client_conn_id);
Report for mgmt_history.c | 30 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#29: FILE: /tmp/f1-1256641/mgmt_history.c:29:
+#define FOREACH_CMT_REC(mm, cmt_info)                                          \
+	frr_each_safe (mgmt_cmt_infos, &mm->cmts, cmt_info)

ERROR: do not initialise statics to NULL
#36: FILE: /tmp/f1-1256641/mgmt_history.c:36:
+static struct vty *rollback_vty = NULL;

WARNING: line over 80 characters
#103: FILE: /tmp/f1-1256641/mgmt_history.c:103:
+static struct mgmt_cmt_info_t *mgmt_history_find_cmt_record(const char *cmtid_str)

WARNING: line over 80 characters
#132: FILE: /tmp/f1-1256641/mgmt_history.c:132:
+			if (!mgmt_history_record_exists(cmt_info.cmt_json_file)) {

WARNING: line over 80 characters
#284: FILE: /tmp/f1-1256641/mgmt_history.c:284:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: line over 80 characters
#323: FILE: /tmp/f1-1256641/mgmt_history.c:323:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: Missing a blank line after declarations
#358: FILE: /tmp/f1-1256641/mgmt_history.c:358:
+	struct mgmt_cmt_info_t *cmt_info = mgmt_history_create_cmt_rec();
+	mgmt_ds_dump_ds_to_file(cmt_info->cmt_json_file, ds_ctx);
Report for mgmt_history.h | 5 issues
===============================================
WARNING: Block comments should align the * on each line
#3: FILE: /tmp/f1-1256641/mgmt_history.h:3:
+/*
+  * Copyright (C) 2021  Vmware, Inc.
Report for mgmt_msg.c | 5 issues
===============================================
WARNING: else is not generally useful after a break or return
#226: FILE: /tmp/f1-1256641/mgmt_msg.c:226:
+				return MSW_SCHED_STREAM;
+			} else
Report for mgmt_txn.c | 20 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#120: FILE: /tmp/f1-1256641/mgmt_txn.c:120:
+#define FOREACH_TXN_CFG_BATCH_IN_LIST(list, batch)                             \
+	frr_each_safe (mgmt_txn_batches, list, batch)

ERROR: Macros with complex values should be enclosed in parentheses
#220: FILE: /tmp/f1-1256641/mgmt_txn.c:220:
+#define FOREACH_TXN_REQ_IN_LIST(list, req)                                     \
+	frr_each_safe (mgmt_txn_reqs, list, req)

ERROR: Macros with complex values should be enclosed in parentheses
#275: FILE: /tmp/f1-1256641/mgmt_txn.c:275:
+#define FOREACH_TXN_IN_LIST(mm, txn)                                           \
+	frr_each_safe (mgmt_txns, &(mm)->txn_list, (txn))

WARNING: Missing a blank line after declarations
#1271: FILE: /tmp/f1-1256641/mgmt_txn.c:1271:
+	char err_buf[1024] = {0};
+	nb_ctx.client = NB_CLIENT_MGMTD_SERVER;
Report for mgmt_vty.c | 10 issues
===============================================
WARNING: Missing a blank line after declarations
#404: FILE: /tmp/f1-1256641/mgmt_vty.c:404:
+	int n = mgmt_debug_be + mgmt_debug_fe + mgmt_debug_ds + mgmt_debug_txn;
+	if (!n)

WARNING: Missing a blank line after declarations
#439: FILE: /tmp/f1-1256641/mgmt_vty.c:439:
+	bool set = !no;
+	if (all)
Report for static_vty.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #385: FILE: /tmp/f1-1256641/static_vty.c:385:
< WARNING: line over 80 characters
< #407: FILE: /tmp/f1-1256641/static_vty.c:407:
Report for vty.c | 8 issues
===============================================
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3491: FILE: /tmp/f1-1256641/vty.c:3491:
< WARNING: line over 80 characters
< #3506: FILE: /tmp/f1-1256641/vty.c:3506:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3592: FILE: /tmp/f1-1256641/vty.c:3592:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3628: FILE: /tmp/f1-1256641/vty.c:3628:

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10280/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Redhat 9 amd64 build: Failed (click for details)

Configure failed for Redhat 9 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10280/artifact/RH9BUILD/ErrorLog/log_configure.txt)

checking for sendmmsg... yes
checking for explicit_bzero... yes
checking for struct mmsghdr.msg_hdr... yes
checking for protoc... no
checking for protoc-c... no
configure: error: in `/home/ci/cibuild.10280/frr-source':
configure: error: protobuf requested but protoc-c not found.  Install protobuf-c.
See `config.log' for more details

Redhat 9 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10280/artifact/RH9BUILD/config.log/config.log

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10280/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10280/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10280/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.10280/frr-source'
lib/mgmt_be_client.c: In function 'mgmt_be_client_handle_msg':
lib/mgmt_be_client.c:879:7: error: '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__BE_MESSAGE__MESSAGE_IS_INT_SIZE'?
lib/mgmt_be_client.c:879:7: note: each undeclared identifier is reported only once for each function it appears in
lib/mgmt_be_client.c:835:2: error: enumeration value '_MGMTD__BE_MESSAGE__MESSAGE_IS_INT_SIZE' not handled in switch [-Werror=switch-enum]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10486: lib/mgmt_be_client.lo] Error 1
lib/mgmt_fe_client.c: In function 'mgmt_fe_client_handle_msg':
lib/mgmt_fe_client.c:652:7: error: '_MGMTD__FE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__FE_MESSAGE__MESSAGE_IS_INT_SIZE'?

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10280/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10280/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
mgmtd/mgmt_fe_adapter.c: In function mgmt_fe_session_handle_commit_config_req_msg:
./lib/zlog.h:109:20: error: format %llu expects argument of type long long unsigned int, but argument 4 has type uint64_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
mgmtd/mgmt_fe_adapter.c:43:4: note: in expansion of macro zlog_debug
mgmtd/mgmt_fe_adapter.c:1237:3: note: in expansion of macro MGMTD_FE_ADAPTER_DBG
 1237 |   MGMTD_FE_ADAPTER_DBG(
./lib/zlog.h:109:20: error: format %llu expects argument of type long long unsigned int, but argument 5 has type uint64_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10280/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests

• Redhat 8 amd64 build
• OpenBSD 7 amd64 build
• Debian 10 amd64 build
• Ubuntu 16.04 arm7 build
• CentOS 7 amd64 build
• Ubuntu 18.04 i386 build
• Ubuntu 18.04 amd64 build
• FreeBSD 11 amd64 build
• Ubuntu 22.04 amd64 build
• Debian 9 amd64 build
• Ubuntu 20.04 amd64 build
• Ubuntu 16.04 arm8 build
• Ubuntu 16.04 amd64 build
• Ubuntu 18.04 ppc64le build
• Ubuntu 16.04 i386 build
• Fedora 29 amd64 build
• Ubuntu 18.04 arm7 build
• Ubuntu 18.04 arm8 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Redhat 9 amd64 build: Failed (click for details)

Configure failed for Redhat 9 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10280/artifact/RH9BUILD/ErrorLog/log_configure.txt)

checking for sendmmsg... yes
checking for explicit_bzero... yes
checking for struct mmsghdr.msg_hdr... yes
checking for protoc... no
checking for protoc-c... no
configure: error: in `/home/ci/cibuild.10280/frr-source':
configure: error: protobuf requested but protoc-c not found.  Install protobuf-c.
See `config.log' for more details

Redhat 9 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10280/artifact/RH9BUILD/config.log/config.log

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10280/artifact/FBSD12AMD64/config.log/config.log.gz FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10280/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10280/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.10280/frr-source'
lib/mgmt_be_client.c: In function 'mgmt_be_client_handle_msg':
lib/mgmt_be_client.c:879:7: error: '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__BE_MESSAGE__MESSAGE_IS_INT_SIZE'?
lib/mgmt_be_client.c:879:7: note: each undeclared identifier is reported only once for each function it appears in
lib/mgmt_be_client.c:835:2: error: enumeration value '_MGMTD__BE_MESSAGE__MESSAGE_IS_INT_SIZE' not handled in switch [-Werror=switch-enum]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10486: lib/mgmt_be_client.lo] Error 1
lib/mgmt_fe_client.c: In function 'mgmt_fe_client_handle_msg':
lib/mgmt_fe_client.c:652:7: error: '_MGMTD__FE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__FE_MESSAGE__MESSAGE_IS_INT_SIZE'?

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10280/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10280/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
mgmtd/mgmt_fe_adapter.c: In function mgmt_fe_session_handle_commit_config_req_msg:
./lib/zlog.h:109:20: error: format %llu expects argument of type long long unsigned int, but argument 4 has type uint64_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
mgmtd/mgmt_fe_adapter.c:43:4: note: in expansion of macro zlog_debug
mgmtd/mgmt_fe_adapter.c:1237:3: note: in expansion of macro MGMTD_FE_ADAPTER_DBG
 1237 |   MGMTD_FE_ADAPTER_DBG(
./lib/zlog.h:109:20: error: format %llu expects argument of type long long unsigned int, but argument 5 has type uint64_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10280/artifact/DEB11AMD64/config.status/config.status

<stdin>:18235: trailing whitespace.
    
warning: 1 line adds whitespace errors.
Report for mgmt_be_adapter.c | 29 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#48: FILE: /tmp/f1-1291873/mgmt_be_adapter.c:48:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_be_adapters, &mgmt_be_adapters, (adapter))

ERROR: space required after that close brace '}'
#97: FILE: /tmp/f1-1291873/mgmt_be_adapter.c:97:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#104: FILE: /tmp/f1-1291873/mgmt_be_adapter.c:104:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#113: FILE: /tmp/f1-1291873/mgmt_be_adapter.c:113:
+			 MGMTD_BE_CLIENT_ID_MAX}},

WARNING: line over 80 characters
#363: FILE: /tmp/f1-1291873/mgmt_be_adapter.c:363:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#759: FILE: /tmp/f1-1291873/mgmt_be_adapter.c:759:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#772: FILE: /tmp/f1-1291873/mgmt_be_adapter.c:772:
+				 adapter, adapter->conn_fd, &adapter->conn_write_ev);
Report for mgmt_be_client.c | 23 issues
===============================================
WARNING: line over 80 characters
#40: FILE: /tmp/f1-1291873/mgmt_be_client.c:40:
+			zlog_debug("%s: " fmt, __func__, ##__VA_ARGS__);         \

ERROR: Macros with complex values should be enclosed in parentheses
#113: FILE: /tmp/f1-1291873/mgmt_be_client.c:113:
+#define FOREACH_BE_TXN_BATCH_IN_LIST(txn, batch)                               \
+	frr_each_safe (mgmt_be_batches, &(txn)->cfg_batches, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#116: FILE: /tmp/f1-1291873/mgmt_be_client.c:116:
+#define FOREACH_BE_APPLY_BATCH_IN_LIST(txn, batch)                             \
+	frr_each_safe (mgmt_be_batches, &(txn)->apply_cfgs, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#149: FILE: /tmp/f1-1291873/mgmt_be_client.c:149:
+#define FOREACH_BE_TXN_IN_LIST(client_ctx, txn)                                \
+	frr_each_safe (mgmt_be_txns, &(client_ctx)->txn_head, (txn))

WARNING: line over 80 characters
#613: FILE: /tmp/f1-1291873/mgmt_be_client.c:613:
+			client_ctx->avg_prep_nb_cfg_tm, (uint32_t)num_processed);
Report for mgmt_ds.c | 29 issues
===============================================
WARNING: Missing a blank line after declarations
#205: FILE: /tmp/f1-1291873/mgmt_ds.c:205:
+	struct lyd_node *dnode = mm->candidate_ds->root.cfg_root->dnode;
+	if (dnode)

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#293: FILE: /tmp/f1-1291873/mgmt_ds.c:293:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#295: FILE: /tmp/f1-1291873/mgmt_ds.c:295:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#303: FILE: /tmp/f1-1291873/mgmt_ds.c:303:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#305: FILE: /tmp/f1-1291873/mgmt_ds.c:305:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#313: FILE: /tmp/f1-1291873/mgmt_ds.c:313:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#321: FILE: /tmp/f1-1291873/mgmt_ds.c:321:
+		return EINVAL;
Report for mgmt_fe_adapter.c | 46 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#49: FILE: /tmp/f1-1291873/mgmt_fe_adapter.c:49:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_fe_adapters, &mgmt_fe_adapters, (adapter))

ERROR: Macros with complex values should be enclosed in parentheses
#74: FILE: /tmp/f1-1291873/mgmt_fe_adapter.c:74:
+#define FOREACH_SESSION_IN_LIST(adapter, session)                              \
+	frr_each_safe (mgmt_fe_sessions, &(adapter)->fe_sessions, (session))

WARNING: line over 80 characters
#510: FILE: /tmp/f1-1291873/mgmt_fe_adapter.c:510:
+			gettimeofday(&session->adapter->cmt_stats.last_end, NULL);

WARNING: line over 80 characters
#733: FILE: /tmp/f1-1291873/mgmt_fe_adapter.c:733:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#1126: FILE: /tmp/f1-1291873/mgmt_fe_adapter.c:1126:
+				session, getdata_req->ds_id, getdata_req->req_id,

WARNING: line over 80 characters
#1513: FILE: /tmp/f1-1291873/mgmt_fe_adapter.c:1513:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#1803: FILE: /tmp/f1-1291873/mgmt_fe_adapter.c:1803:
+					&adapter->cmt_stats.apply_cfg_start, buf,

WARNING: line over 80 characters
#1841: FILE: /tmp/f1-1291873/mgmt_fe_adapter.c:1841:
+			mgmt_realtime_to_string(&adapter->setcfg_stats.last_start,

WARNING: line over 80 characters
#1883: FILE: /tmp/f1-1291873/mgmt_fe_adapter.c:1883:
+						session->ds_locked_implict[ds_id]

WARNING: line over 80 characters
#1917: FILE: /tmp/f1-1291873/mgmt_fe_adapter.c:1917:
+		memset(&adapter->setcfg_stats, 0, sizeof(adapter->setcfg_stats));

WARNING: line over 80 characters
#1919: FILE: /tmp/f1-1291873/mgmt_fe_adapter.c:1919:
+			memset(&adapter->cmt_stats, 0, sizeof(adapter->cmt_stats));
Report for mgmt_fe_client.c | 25 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#82: FILE: /tmp/f1-1291873/mgmt_fe_client.c:82:
+#define FOREACH_SESSION_IN_LIST(client_ctx, session)                           \
+	frr_each_safe (mgmt_sessions, &(client_ctx)->client_sessions, (session))

WARNING: line over 80 characters
#125: FILE: /tmp/f1-1291873/mgmt_fe_client.c:125:
+				"Found session %p for session-id %llu.", session,

WARNING: line over 80 characters
#290: FILE: /tmp/f1-1291873/mgmt_fe_client.c:290:
+		lock ? "" : "UN", ds_id, (unsigned long long)session->client_id);

WARNING: line over 80 characters
#330: FILE: /tmp/f1-1291873/mgmt_fe_client.c:330:
+			       Mgmtd__DatastoreId dest_ds_id, bool validate_only,

WARNING: line over 80 characters
#463: FILE: /tmp/f1-1291873/mgmt_fe_client.c:463:
+						->session_reply->client_conn_id);

WARNING: line over 80 characters
#470: FILE: /tmp/f1-1291873/mgmt_fe_client.c:470:
+						->session_reply->client_conn_id);
Report for mgmt_history.c | 30 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#29: FILE: /tmp/f1-1291873/mgmt_history.c:29:
+#define FOREACH_CMT_REC(mm, cmt_info)                                          \
+	frr_each_safe (mgmt_cmt_infos, &mm->cmts, cmt_info)

ERROR: do not initialise statics to NULL
#36: FILE: /tmp/f1-1291873/mgmt_history.c:36:
+static struct vty *rollback_vty = NULL;

WARNING: line over 80 characters
#103: FILE: /tmp/f1-1291873/mgmt_history.c:103:
+static struct mgmt_cmt_info_t *mgmt_history_find_cmt_record(const char *cmtid_str)

WARNING: line over 80 characters
#132: FILE: /tmp/f1-1291873/mgmt_history.c:132:
+			if (!mgmt_history_record_exists(cmt_info.cmt_json_file)) {

WARNING: line over 80 characters
#284: FILE: /tmp/f1-1291873/mgmt_history.c:284:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: line over 80 characters
#323: FILE: /tmp/f1-1291873/mgmt_history.c:323:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: Missing a blank line after declarations
#358: FILE: /tmp/f1-1291873/mgmt_history.c:358:
+	struct mgmt_cmt_info_t *cmt_info = mgmt_history_create_cmt_rec();
+	mgmt_ds_dump_ds_to_file(cmt_info->cmt_json_file, ds_ctx);
Report for mgmt_history.h | 5 issues
===============================================
WARNING: Block comments should align the * on each line
#3: FILE: /tmp/f1-1291873/mgmt_history.h:3:
+/*
+  * Copyright (C) 2021  Vmware, Inc.
Report for mgmt_msg.c | 5 issues
===============================================
WARNING: else is not generally useful after a break or return
#226: FILE: /tmp/f1-1291873/mgmt_msg.c:226:
+				return MSW_SCHED_STREAM;
+			} else
Report for mgmt_txn.c | 20 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#120: FILE: /tmp/f1-1291873/mgmt_txn.c:120:
+#define FOREACH_TXN_CFG_BATCH_IN_LIST(list, batch)                             \
+	frr_each_safe (mgmt_txn_batches, list, batch)

ERROR: Macros with complex values should be enclosed in parentheses
#220: FILE: /tmp/f1-1291873/mgmt_txn.c:220:
+#define FOREACH_TXN_REQ_IN_LIST(list, req)                                     \
+	frr_each_safe (mgmt_txn_reqs, list, req)

ERROR: Macros with complex values should be enclosed in parentheses
#275: FILE: /tmp/f1-1291873/mgmt_txn.c:275:
+#define FOREACH_TXN_IN_LIST(mm, txn)                                           \
+	frr_each_safe (mgmt_txns, &(mm)->txn_list, (txn))

WARNING: Missing a blank line after declarations
#1271: FILE: /tmp/f1-1291873/mgmt_txn.c:1271:
+	char err_buf[1024] = {0};
+	nb_ctx.client = NB_CLIENT_MGMTD_SERVER;
Report for mgmt_vty.c | 10 issues
===============================================
WARNING: Missing a blank line after declarations
#404: FILE: /tmp/f1-1291873/mgmt_vty.c:404:
+	int n = mgmt_debug_be + mgmt_debug_fe + mgmt_debug_ds + mgmt_debug_txn;
+	if (!n)

WARNING: Missing a blank line after declarations
#439: FILE: /tmp/f1-1291873/mgmt_vty.c:439:
+	bool set = !no;
+	if (all)
Report for static_vty.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #385: FILE: /tmp/f1-1291873/static_vty.c:385:
< WARNING: line over 80 characters
< #407: FILE: /tmp/f1-1291873/static_vty.c:407:
Report for vty.c | 8 issues
===============================================
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3491: FILE: /tmp/f1-1291873/vty.c:3491:
< WARNING: line over 80 characters
< #3506: FILE: /tmp/f1-1291873/vty.c:3506:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3592: FILE: /tmp/f1-1291873/vty.c:3592:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3628: FILE: /tmp/f1-1291873/vty.c:3628:

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10281/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10281/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10281/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10281/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.10281/frr-source'
lib/mgmt_be_client.c: In function 'mgmt_be_client_handle_msg':
lib/mgmt_be_client.c:878:7: error: '_MGMTD__BE_MESSAGE__MESSAGE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE'?
lib/mgmt_be_client.c:878:7: note: each undeclared identifier is reported only once for each function it appears in
lib/mgmt_be_client.c:835:2: error: enumeration value '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE' not handled in switch [-Werror=switch-enum]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10489: lib/mgmt_be_client.lo] Error 1
lib/mgmt_fe_client.c: In function 'mgmt_fe_client_handle_msg':
lib/mgmt_fe_client.c:651:7: error: '_MGMTD__FE_MESSAGE__MESSAGE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__FE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE'?

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10281/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10281/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
mgmtd/mgmt_fe_adapter.c: In function mgmt_fe_session_handle_commit_config_req_msg:
./lib/zlog.h:109:20: error: format %llu expects argument of type long long unsigned int, but argument 5 has type uint64_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
mgmtd/mgmt_fe_adapter.c:43:4: note: in expansion of macro zlog_debug
mgmtd/mgmt_fe_adapter.c:1237:3: note: in expansion of macro MGMTD_FE_ADAPTER_DBG
 1237 |   MGMTD_FE_ADAPTER_DBG("Created txn %" PRIu64
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10474: mgmtd/mgmt_fe_adapter.o] Error 1

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10281/artifact/DEB11AMD64/config.status/config.status

Successful on other platforms/tests

• Redhat 8 amd64 build
• Redhat 9 amd64 build
• OpenBSD 7 amd64 build
• Debian 10 amd64 build
• Ubuntu 16.04 arm7 build
• Ubuntu 18.04 i386 build
• Ubuntu 18.04 amd64 build
• Ubuntu 16.04 amd64 build
• Ubuntu 20.04 amd64 build
• Debian 9 amd64 build
• CentOS 7 amd64 build
• Ubuntu 16.04 arm8 build
• Ubuntu 18.04 ppc64le build
• Ubuntu 22.04 amd64 build
• FreeBSD 12 amd64 build
• Fedora 29 amd64 build
• Ubuntu 16.04 i386 build
• Ubuntu 18.04 arm7 build
• Ubuntu 18.04 arm8 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10281/artifact/CI009BUILD/config.log/config.log.gz FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10281/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10281/artifact/CI009BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/usr/home/ci/cibuild.10281/frr-source'
lib/mgmt_be_client.c: In function 'mgmt_be_client_handle_msg':
lib/mgmt_be_client.c:878:7: error: '_MGMTD__BE_MESSAGE__MESSAGE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE'?
lib/mgmt_be_client.c:878:7: note: each undeclared identifier is reported only once for each function it appears in
lib/mgmt_be_client.c:835:2: error: enumeration value '_MGMTD__BE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE' not handled in switch [-Werror=switch-enum]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:10489: lib/mgmt_be_client.lo] Error 1
lib/mgmt_fe_client.c: In function 'mgmt_fe_client_handle_msg':
lib/mgmt_fe_client.c:651:7: error: '_MGMTD__FE_MESSAGE__MESSAGE_IS_INT_SIZE' undeclared (first use in this function); did you mean '_MGMTD__FE_MESSAGE__MESSAGE__CASE_IS_INT_SIZE'?

Debian 11 amd64 build: Failed (click for details)

Debian 11 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10281/artifact/DEB11AMD64/config.log/config.log.gz

Make failed for Debian 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10281/artifact/DEB11AMD64/ErrorLog/log_make.txt)

In file included from ./lib/log.h:17,
mgmtd/mgmt_fe_adapter.c: In function mgmt_fe_session_handle_commit_config_req_msg:
./lib/zlog.h:109:20: error: format %llu expects argument of type long long unsigned int, but argument 5 has type uint64_t {aka long unsigned int} [-Werror=format=]
./lib/zlog.h:116:26: note: in expansion of macro _zlog_ecref
mgmtd/mgmt_fe_adapter.c:43:4: note: in expansion of macro zlog_debug
mgmtd/mgmt_fe_adapter.c:1237:3: note: in expansion of macro MGMTD_FE_ADAPTER_DBG
 1237 |   MGMTD_FE_ADAPTER_DBG("Created txn %" PRIu64
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10474: mgmtd/mgmt_fe_adapter.o] Error 1

Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10281/artifact/DEB11AMD64/config.status/config.status

<stdin>:18220: trailing whitespace.
    
warning: 1 line adds whitespace errors.
Report for mgmt_be_adapter.c | 29 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#48: FILE: /tmp/f1-1409169/mgmt_be_adapter.c:48:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_be_adapters, &mgmt_be_adapters, (adapter))

ERROR: space required after that close brace '}'
#97: FILE: /tmp/f1-1409169/mgmt_be_adapter.c:97:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#104: FILE: /tmp/f1-1409169/mgmt_be_adapter.c:104:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#113: FILE: /tmp/f1-1409169/mgmt_be_adapter.c:113:
+			 MGMTD_BE_CLIENT_ID_MAX}},

WARNING: line over 80 characters
#363: FILE: /tmp/f1-1409169/mgmt_be_adapter.c:363:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#755: FILE: /tmp/f1-1409169/mgmt_be_adapter.c:755:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#768: FILE: /tmp/f1-1409169/mgmt_be_adapter.c:768:
+				 adapter, adapter->conn_fd, &adapter->conn_write_ev);
Report for mgmt_be_client.c | 23 issues
===============================================
WARNING: line over 80 characters
#40: FILE: /tmp/f1-1409169/mgmt_be_client.c:40:
+			zlog_debug("%s: " fmt, __func__, ##__VA_ARGS__);         \

ERROR: Macros with complex values should be enclosed in parentheses
#113: FILE: /tmp/f1-1409169/mgmt_be_client.c:113:
+#define FOREACH_BE_TXN_BATCH_IN_LIST(txn, batch)                               \
+	frr_each_safe (mgmt_be_batches, &(txn)->cfg_batches, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#116: FILE: /tmp/f1-1409169/mgmt_be_client.c:116:
+#define FOREACH_BE_APPLY_BATCH_IN_LIST(txn, batch)                             \
+	frr_each_safe (mgmt_be_batches, &(txn)->apply_cfgs, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#149: FILE: /tmp/f1-1409169/mgmt_be_client.c:149:
+#define FOREACH_BE_TXN_IN_LIST(client_ctx, txn)                                \
+	frr_each_safe (mgmt_be_txns, &(client_ctx)->txn_head, (txn))

WARNING: line over 80 characters
#613: FILE: /tmp/f1-1409169/mgmt_be_client.c:613:
+			client_ctx->avg_prep_nb_cfg_tm, (uint32_t)num_processed);
Report for mgmt_ds.c | 29 issues
===============================================
WARNING: Missing a blank line after declarations
#205: FILE: /tmp/f1-1409169/mgmt_ds.c:205:
+	struct lyd_node *dnode = mm->candidate_ds->root.cfg_root->dnode;
+	if (dnode)

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#293: FILE: /tmp/f1-1409169/mgmt_ds.c:293:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#295: FILE: /tmp/f1-1409169/mgmt_ds.c:295:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#303: FILE: /tmp/f1-1409169/mgmt_ds.c:303:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#305: FILE: /tmp/f1-1409169/mgmt_ds.c:305:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#313: FILE: /tmp/f1-1409169/mgmt_ds.c:313:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#321: FILE: /tmp/f1-1409169/mgmt_ds.c:321:
+		return EINVAL;
Report for mgmt_fe_adapter.c | 46 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#49: FILE: /tmp/f1-1409169/mgmt_fe_adapter.c:49:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_fe_adapters, &mgmt_fe_adapters, (adapter))

ERROR: Macros with complex values should be enclosed in parentheses
#74: FILE: /tmp/f1-1409169/mgmt_fe_adapter.c:74:
+#define FOREACH_SESSION_IN_LIST(adapter, session)                              \
+	frr_each_safe (mgmt_fe_sessions, &(adapter)->fe_sessions, (session))

WARNING: line over 80 characters
#510: FILE: /tmp/f1-1409169/mgmt_fe_adapter.c:510:
+			gettimeofday(&session->adapter->cmt_stats.last_end, NULL);

WARNING: line over 80 characters
#733: FILE: /tmp/f1-1409169/mgmt_fe_adapter.c:733:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#1126: FILE: /tmp/f1-1409169/mgmt_fe_adapter.c:1126:
+				session, getdata_req->ds_id, getdata_req->req_id,

WARNING: line over 80 characters
#1509: FILE: /tmp/f1-1409169/mgmt_fe_adapter.c:1509:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#1799: FILE: /tmp/f1-1409169/mgmt_fe_adapter.c:1799:
+					&adapter->cmt_stats.apply_cfg_start, buf,

WARNING: line over 80 characters
#1837: FILE: /tmp/f1-1409169/mgmt_fe_adapter.c:1837:
+			mgmt_realtime_to_string(&adapter->setcfg_stats.last_start,

WARNING: line over 80 characters
#1879: FILE: /tmp/f1-1409169/mgmt_fe_adapter.c:1879:
+						session->ds_locked_implict[ds_id]

WARNING: line over 80 characters
#1913: FILE: /tmp/f1-1409169/mgmt_fe_adapter.c:1913:
+		memset(&adapter->setcfg_stats, 0, sizeof(adapter->setcfg_stats));

WARNING: line over 80 characters
#1915: FILE: /tmp/f1-1409169/mgmt_fe_adapter.c:1915:
+			memset(&adapter->cmt_stats, 0, sizeof(adapter->cmt_stats));
Report for mgmt_fe_client.c | 25 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#82: FILE: /tmp/f1-1409169/mgmt_fe_client.c:82:
+#define FOREACH_SESSION_IN_LIST(client_ctx, session)                           \
+	frr_each_safe (mgmt_sessions, &(client_ctx)->client_sessions, (session))

WARNING: line over 80 characters
#125: FILE: /tmp/f1-1409169/mgmt_fe_client.c:125:
+				"Found session %p for session-id %llu.", session,

WARNING: line over 80 characters
#290: FILE: /tmp/f1-1409169/mgmt_fe_client.c:290:
+		lock ? "" : "UN", ds_id, (unsigned long long)session->client_id);

WARNING: line over 80 characters
#330: FILE: /tmp/f1-1409169/mgmt_fe_client.c:330:
+			       Mgmtd__DatastoreId dest_ds_id, bool validate_only,

WARNING: line over 80 characters
#463: FILE: /tmp/f1-1409169/mgmt_fe_client.c:463:
+						->session_reply->client_conn_id);

WARNING: line over 80 characters
#470: FILE: /tmp/f1-1409169/mgmt_fe_client.c:470:
+						->session_reply->client_conn_id);
Report for mgmt_history.c | 30 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#29: FILE: /tmp/f1-1409169/mgmt_history.c:29:
+#define FOREACH_CMT_REC(mm, cmt_info)                                          \
+	frr_each_safe (mgmt_cmt_infos, &mm->cmts, cmt_info)

ERROR: do not initialise statics to NULL
#36: FILE: /tmp/f1-1409169/mgmt_history.c:36:
+static struct vty *rollback_vty = NULL;

WARNING: line over 80 characters
#103: FILE: /tmp/f1-1409169/mgmt_history.c:103:
+static struct mgmt_cmt_info_t *mgmt_history_find_cmt_record(const char *cmtid_str)

WARNING: line over 80 characters
#132: FILE: /tmp/f1-1409169/mgmt_history.c:132:
+			if (!mgmt_history_record_exists(cmt_info.cmt_json_file)) {

WARNING: line over 80 characters
#284: FILE: /tmp/f1-1409169/mgmt_history.c:284:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: line over 80 characters
#323: FILE: /tmp/f1-1409169/mgmt_history.c:323:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: Missing a blank line after declarations
#358: FILE: /tmp/f1-1409169/mgmt_history.c:358:
+	struct mgmt_cmt_info_t *cmt_info = mgmt_history_create_cmt_rec();
+	mgmt_ds_dump_ds_to_file(cmt_info->cmt_json_file, ds_ctx);
Report for mgmt_history.h | 5 issues
===============================================
WARNING: Block comments should align the * on each line
#3: FILE: /tmp/f1-1409169/mgmt_history.h:3:
+/*
+  * Copyright (C) 2021  Vmware, Inc.
Report for mgmt_msg.c | 5 issues
===============================================
WARNING: else is not generally useful after a break or return
#226: FILE: /tmp/f1-1409169/mgmt_msg.c:226:
+				return MSW_SCHED_STREAM;
+			} else
Report for mgmt_txn.c | 20 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#120: FILE: /tmp/f1-1409169/mgmt_txn.c:120:
+#define FOREACH_TXN_CFG_BATCH_IN_LIST(list, batch)                             \
+	frr_each_safe (mgmt_txn_batches, list, batch)

ERROR: Macros with complex values should be enclosed in parentheses
#220: FILE: /tmp/f1-1409169/mgmt_txn.c:220:
+#define FOREACH_TXN_REQ_IN_LIST(list, req)                                     \
+	frr_each_safe (mgmt_txn_reqs, list, req)

ERROR: Macros with complex values should be enclosed in parentheses
#275: FILE: /tmp/f1-1409169/mgmt_txn.c:275:
+#define FOREACH_TXN_IN_LIST(mm, txn)                                           \
+	frr_each_safe (mgmt_txns, &(mm)->txn_list, (txn))

WARNING: Missing a blank line after declarations
#1271: FILE: /tmp/f1-1409169/mgmt_txn.c:1271:
+	char err_buf[1024] = {0};
+	nb_ctx.client = NB_CLIENT_MGMTD_SERVER;
Report for mgmt_vty.c | 10 issues
===============================================
WARNING: Missing a blank line after declarations
#404: FILE: /tmp/f1-1409169/mgmt_vty.c:404:
+	int n = mgmt_debug_be + mgmt_debug_fe + mgmt_debug_ds + mgmt_debug_txn;
+	if (!n)

WARNING: Missing a blank line after declarations
#439: FILE: /tmp/f1-1409169/mgmt_vty.c:439:
+	bool set = !no;
+	if (all)
Report for static_vty.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #385: FILE: /tmp/f1-1409169/static_vty.c:385:
< WARNING: line over 80 characters
< #407: FILE: /tmp/f1-1409169/static_vty.c:407:
Report for vty.c | 8 issues
===============================================
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3491: FILE: /tmp/f1-1409169/vty.c:3491:
< WARNING: line over 80 characters
< #3506: FILE: /tmp/f1-1409169/vty.c:3506:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3592: FILE: /tmp/f1-1409169/vty.c:3592:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3628: FILE: /tmp/f1-1409169/vty.c:3628:

[Jafaral]

license headers need to be updated in all new files to conform with the new format. ex:

// SPDX-License-Identifier: GPL-2.0-or-later
/*
 * OSPF ABR functions.
 * Copyright (C) 1999, 2000 Alex Zinin, Toshiaki Takada
 */

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10301/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Redhat 9 amd64 build: Failed (click for details)

Configure failed for Redhat 9 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10301/artifact/RH9BUILD/ErrorLog/log_configure.txt)

checking for sendmmsg... yes
checking for explicit_bzero... yes
checking for struct mmsghdr.msg_hdr... yes
checking for protoc... no
checking for protoc-c... no
configure: error: in `/home/ci/cibuild.10301/frr-source':
configure: error: protobuf requested but protoc-c not found.  Install protobuf-c.
See `config.log' for more details

Redhat 9 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10301/artifact/RH9BUILD/config.log/config.log

Successful on other platforms/tests

• Ubuntu 22.04 amd64 build
• Ubuntu 20.04 amd64 build
• Ubuntu 18.04 arm8 build
• Debian 9 amd64 build
• Ubuntu 18.04 ppc64le build
• Fedora 29 amd64 build
• Debian 10 amd64 build
• Ubuntu 18.04 arm7 build
• FreeBSD 11 amd64 build
• CentOS 7 amd64 build
• Ubuntu 16.04 arm7 build
• Debian 11 amd64 build
• Ubuntu 16.04 i386 build
• Ubuntu 18.04 amd64 build
• Ubuntu 16.04 amd64 build
• FreeBSD 12 amd64 build
• Ubuntu 16.04 arm8 build
• Redhat 8 amd64 build
• Ubuntu 18.04 i386 build
• OpenBSD 7 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Redhat 9 amd64 build: Failed (click for details)

Configure failed for Redhat 9 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10301/artifact/RH9BUILD/ErrorLog/log_configure.txt)

checking for sendmmsg... yes
checking for explicit_bzero... yes
checking for struct mmsghdr.msg_hdr... yes
checking for protoc... no
checking for protoc-c... no
configure: error: in `/home/ci/cibuild.10301/frr-source':
configure: error: protobuf requested but protoc-c not found.  Install protobuf-c.
See `config.log' for more details

Redhat 9 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10301/artifact/RH9BUILD/config.log/config.log

<stdin>:18225: trailing whitespace.
    
warning: 1 line adds whitespace errors.
Report for mgmt_be_adapter.c | 29 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#48: FILE: /tmp/f1-2876355/mgmt_be_adapter.c:48:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_be_adapters, &mgmt_be_adapters, (adapter))

ERROR: space required after that close brace '}'
#97: FILE: /tmp/f1-2876355/mgmt_be_adapter.c:97:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#104: FILE: /tmp/f1-2876355/mgmt_be_adapter.c:104:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#113: FILE: /tmp/f1-2876355/mgmt_be_adapter.c:113:
+			 MGMTD_BE_CLIENT_ID_MAX}},

WARNING: line over 80 characters
#363: FILE: /tmp/f1-2876355/mgmt_be_adapter.c:363:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#756: FILE: /tmp/f1-2876355/mgmt_be_adapter.c:756:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#769: FILE: /tmp/f1-2876355/mgmt_be_adapter.c:769:
+				 adapter, adapter->conn_fd, &adapter->conn_write_ev);
Report for mgmt_be_client.c | 23 issues
===============================================
WARNING: line over 80 characters
#40: FILE: /tmp/f1-2876355/mgmt_be_client.c:40:
+			zlog_debug("%s: " fmt, __func__, ##__VA_ARGS__);         \

ERROR: Macros with complex values should be enclosed in parentheses
#113: FILE: /tmp/f1-2876355/mgmt_be_client.c:113:
+#define FOREACH_BE_TXN_BATCH_IN_LIST(txn, batch)                               \
+	frr_each_safe (mgmt_be_batches, &(txn)->cfg_batches, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#116: FILE: /tmp/f1-2876355/mgmt_be_client.c:116:
+#define FOREACH_BE_APPLY_BATCH_IN_LIST(txn, batch)                             \
+	frr_each_safe (mgmt_be_batches, &(txn)->apply_cfgs, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#149: FILE: /tmp/f1-2876355/mgmt_be_client.c:149:
+#define FOREACH_BE_TXN_IN_LIST(client_ctx, txn)                                \
+	frr_each_safe (mgmt_be_txns, &(client_ctx)->txn_head, (txn))

WARNING: line over 80 characters
#613: FILE: /tmp/f1-2876355/mgmt_be_client.c:613:
+			client_ctx->avg_prep_nb_cfg_tm, (uint32_t)num_processed);
Report for mgmt_ds.c | 29 issues
===============================================
WARNING: Missing a blank line after declarations
#205: FILE: /tmp/f1-2876355/mgmt_ds.c:205:
+	struct lyd_node *dnode = mm->candidate_ds->root.cfg_root->dnode;
+	if (dnode)

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#293: FILE: /tmp/f1-2876355/mgmt_ds.c:293:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#295: FILE: /tmp/f1-2876355/mgmt_ds.c:295:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#303: FILE: /tmp/f1-2876355/mgmt_ds.c:303:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#305: FILE: /tmp/f1-2876355/mgmt_ds.c:305:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#313: FILE: /tmp/f1-2876355/mgmt_ds.c:313:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#321: FILE: /tmp/f1-2876355/mgmt_ds.c:321:
+		return EINVAL;
Report for mgmt_fe_adapter.c | 46 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#49: FILE: /tmp/f1-2876355/mgmt_fe_adapter.c:49:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_fe_adapters, &mgmt_fe_adapters, (adapter))

ERROR: Macros with complex values should be enclosed in parentheses
#74: FILE: /tmp/f1-2876355/mgmt_fe_adapter.c:74:
+#define FOREACH_SESSION_IN_LIST(adapter, session)                              \
+	frr_each_safe (mgmt_fe_sessions, &(adapter)->fe_sessions, (session))

WARNING: line over 80 characters
#510: FILE: /tmp/f1-2876355/mgmt_fe_adapter.c:510:
+			gettimeofday(&session->adapter->cmt_stats.last_end, NULL);

WARNING: line over 80 characters
#733: FILE: /tmp/f1-2876355/mgmt_fe_adapter.c:733:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#1126: FILE: /tmp/f1-2876355/mgmt_fe_adapter.c:1126:
+				session, getdata_req->ds_id, getdata_req->req_id,

WARNING: line over 80 characters
#1511: FILE: /tmp/f1-2876355/mgmt_fe_adapter.c:1511:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#1801: FILE: /tmp/f1-2876355/mgmt_fe_adapter.c:1801:
+					&adapter->cmt_stats.apply_cfg_start, buf,

WARNING: line over 80 characters
#1839: FILE: /tmp/f1-2876355/mgmt_fe_adapter.c:1839:
+			mgmt_realtime_to_string(&adapter->setcfg_stats.last_start,

WARNING: line over 80 characters
#1881: FILE: /tmp/f1-2876355/mgmt_fe_adapter.c:1881:
+						session->ds_locked_implict[ds_id]

WARNING: line over 80 characters
#1915: FILE: /tmp/f1-2876355/mgmt_fe_adapter.c:1915:
+		memset(&adapter->setcfg_stats, 0, sizeof(adapter->setcfg_stats));

WARNING: line over 80 characters
#1917: FILE: /tmp/f1-2876355/mgmt_fe_adapter.c:1917:
+			memset(&adapter->cmt_stats, 0, sizeof(adapter->cmt_stats));
Report for mgmt_fe_client.c | 25 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#82: FILE: /tmp/f1-2876355/mgmt_fe_client.c:82:
+#define FOREACH_SESSION_IN_LIST(client_ctx, session)                           \
+	frr_each_safe (mgmt_sessions, &(client_ctx)->client_sessions, (session))

WARNING: line over 80 characters
#125: FILE: /tmp/f1-2876355/mgmt_fe_client.c:125:
+				"Found session %p for session-id %llu.", session,

WARNING: line over 80 characters
#290: FILE: /tmp/f1-2876355/mgmt_fe_client.c:290:
+		lock ? "" : "UN", ds_id, (unsigned long long)session->client_id);

WARNING: line over 80 characters
#330: FILE: /tmp/f1-2876355/mgmt_fe_client.c:330:
+			       Mgmtd__DatastoreId dest_ds_id, bool validate_only,

WARNING: line over 80 characters
#467: FILE: /tmp/f1-2876355/mgmt_fe_client.c:467:
+						->session_reply->client_conn_id);

WARNING: line over 80 characters
#474: FILE: /tmp/f1-2876355/mgmt_fe_client.c:474:
+						->session_reply->client_conn_id);
Report for mgmt_history.c | 30 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#29: FILE: /tmp/f1-2876355/mgmt_history.c:29:
+#define FOREACH_CMT_REC(mm, cmt_info)                                          \
+	frr_each_safe (mgmt_cmt_infos, &mm->cmts, cmt_info)

ERROR: do not initialise statics to NULL
#36: FILE: /tmp/f1-2876355/mgmt_history.c:36:
+static struct vty *rollback_vty = NULL;

WARNING: line over 80 characters
#103: FILE: /tmp/f1-2876355/mgmt_history.c:103:
+static struct mgmt_cmt_info_t *mgmt_history_find_cmt_record(const char *cmtid_str)

WARNING: line over 80 characters
#132: FILE: /tmp/f1-2876355/mgmt_history.c:132:
+			if (!mgmt_history_record_exists(cmt_info.cmt_json_file)) {

WARNING: line over 80 characters
#284: FILE: /tmp/f1-2876355/mgmt_history.c:284:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: line over 80 characters
#323: FILE: /tmp/f1-2876355/mgmt_history.c:323:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: Missing a blank line after declarations
#358: FILE: /tmp/f1-2876355/mgmt_history.c:358:
+	struct mgmt_cmt_info_t *cmt_info = mgmt_history_create_cmt_rec();
+	mgmt_ds_dump_ds_to_file(cmt_info->cmt_json_file, ds_ctx);
Report for mgmt_history.h | 5 issues
===============================================
WARNING: Block comments should align the * on each line
#3: FILE: /tmp/f1-2876355/mgmt_history.h:3:
+/*
+  * Copyright (C) 2021  Vmware, Inc.
Report for mgmt_msg.c | 5 issues
===============================================
WARNING: else is not generally useful after a break or return
#226: FILE: /tmp/f1-2876355/mgmt_msg.c:226:
+				return MSW_SCHED_STREAM;
+			} else
Report for mgmt_txn.c | 20 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#120: FILE: /tmp/f1-2876355/mgmt_txn.c:120:
+#define FOREACH_TXN_CFG_BATCH_IN_LIST(list, batch)                             \
+	frr_each_safe (mgmt_txn_batches, list, batch)

ERROR: Macros with complex values should be enclosed in parentheses
#220: FILE: /tmp/f1-2876355/mgmt_txn.c:220:
+#define FOREACH_TXN_REQ_IN_LIST(list, req)                                     \
+	frr_each_safe (mgmt_txn_reqs, list, req)

ERROR: Macros with complex values should be enclosed in parentheses
#275: FILE: /tmp/f1-2876355/mgmt_txn.c:275:
+#define FOREACH_TXN_IN_LIST(mm, txn)                                           \
+	frr_each_safe (mgmt_txns, &(mm)->txn_list, (txn))

WARNING: Missing a blank line after declarations
#1271: FILE: /tmp/f1-2876355/mgmt_txn.c:1271:
+	char err_buf[1024] = {0};
+	nb_ctx.client = NB_CLIENT_MGMTD_SERVER;
Report for mgmt_vty.c | 10 issues
===============================================
WARNING: Missing a blank line after declarations
#404: FILE: /tmp/f1-2876355/mgmt_vty.c:404:
+	int n = mgmt_debug_be + mgmt_debug_fe + mgmt_debug_ds + mgmt_debug_txn;
+	if (!n)

WARNING: Missing a blank line after declarations
#439: FILE: /tmp/f1-2876355/mgmt_vty.c:439:
+	bool set = !no;
+	if (all)
Report for static_vty.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #385: FILE: /tmp/f1-2876355/static_vty.c:385:
< WARNING: line over 80 characters
< #407: FILE: /tmp/f1-2876355/static_vty.c:407:
Report for vty.c | 8 issues
===============================================
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3491: FILE: /tmp/f1-2876355/vty.c:3491:
< WARNING: line over 80 characters
< #3506: FILE: /tmp/f1-2876355/vty.c:3506:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3592: FILE: /tmp/f1-2876355/vty.c:3592:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3628: FILE: /tmp/f1-2876355/vty.c:3628:

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10306/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Redhat 9 amd64 build: Failed (click for details)

Configure failed for Redhat 9 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10306/artifact/RH9BUILD/ErrorLog/log_configure.txt)

checking for sendmmsg... yes
checking for explicit_bzero... yes
checking for struct mmsghdr.msg_hdr... yes
checking for protoc... no
checking for protoc-c... no
configure: error: in `/home/ci/cibuild.10306/frr-source':
configure: error: protobuf requested but protoc-c not found.  Install protobuf-c.
See `config.log' for more details

Redhat 9 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10306/artifact/RH9BUILD/config.log/config.log

Successful on other platforms/tests

• Fedora 29 amd64 build
• Ubuntu 20.04 amd64 build
• OpenBSD 7 amd64 build
• Ubuntu 18.04 arm8 build
• Redhat 8 amd64 build
• Debian 9 amd64 build
• Debian 10 amd64 build
• Ubuntu 18.04 ppc64le build
• Ubuntu 16.04 arm7 build
• FreeBSD 11 amd64 build
• Ubuntu 22.04 amd64 build
• Ubuntu 16.04 arm8 build
• Ubuntu 18.04 amd64 build
• Debian 11 amd64 build
• Ubuntu 18.04 i386 build
• Ubuntu 16.04 amd64 build
• Ubuntu 18.04 arm7 build
• CentOS 7 amd64 build
• FreeBSD 12 amd64 build
• Ubuntu 16.04 i386 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Redhat 9 amd64 build: Failed (click for details)

Configure failed for Redhat 9 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10306/artifact/RH9BUILD/ErrorLog/log_configure.txt)

checking for sendmmsg... yes
checking for explicit_bzero... yes
checking for struct mmsghdr.msg_hdr... yes
checking for protoc... no
checking for protoc-c... no
configure: error: in `/home/ci/cibuild.10306/frr-source':
configure: error: protobuf requested but protoc-c not found.  Install protobuf-c.
See `config.log' for more details

Redhat 9 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10306/artifact/RH9BUILD/config.log/config.log

<stdin>:17923: trailing whitespace.
    
warning: 1 line adds whitespace errors.
Report for mgmt_be_adapter.c | 29 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#36: FILE: /tmp/f1-3187773/mgmt_be_adapter.c:36:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_be_adapters, &mgmt_be_adapters, (adapter))

ERROR: space required after that close brace '}'
#85: FILE: /tmp/f1-3187773/mgmt_be_adapter.c:85:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#92: FILE: /tmp/f1-3187773/mgmt_be_adapter.c:92:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#101: FILE: /tmp/f1-3187773/mgmt_be_adapter.c:101:
+			 MGMTD_BE_CLIENT_ID_MAX}},

WARNING: line over 80 characters
#351: FILE: /tmp/f1-3187773/mgmt_be_adapter.c:351:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#744: FILE: /tmp/f1-3187773/mgmt_be_adapter.c:744:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#757: FILE: /tmp/f1-3187773/mgmt_be_adapter.c:757:
+				 adapter, adapter->conn_fd, &adapter->conn_write_ev);
Report for mgmt_be_client.c | 23 issues
===============================================
WARNING: line over 80 characters
#27: FILE: /tmp/f1-3187773/mgmt_be_client.c:27:
+			zlog_debug("%s: " fmt, __func__, ##__VA_ARGS__);         \

ERROR: Macros with complex values should be enclosed in parentheses
#100: FILE: /tmp/f1-3187773/mgmt_be_client.c:100:
+#define FOREACH_BE_TXN_BATCH_IN_LIST(txn, batch)                               \
+	frr_each_safe (mgmt_be_batches, &(txn)->cfg_batches, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#103: FILE: /tmp/f1-3187773/mgmt_be_client.c:103:
+#define FOREACH_BE_APPLY_BATCH_IN_LIST(txn, batch)                             \
+	frr_each_safe (mgmt_be_batches, &(txn)->apply_cfgs, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#136: FILE: /tmp/f1-3187773/mgmt_be_client.c:136:
+#define FOREACH_BE_TXN_IN_LIST(client_ctx, txn)                                \
+	frr_each_safe (mgmt_be_txns, &(client_ctx)->txn_head, (txn))

WARNING: line over 80 characters
#600: FILE: /tmp/f1-3187773/mgmt_be_client.c:600:
+			client_ctx->avg_prep_nb_cfg_tm, (uint32_t)num_processed);
Report for mgmt_ds.c | 29 issues
===============================================
WARNING: Missing a blank line after declarations
#193: FILE: /tmp/f1-3187773/mgmt_ds.c:193:
+	struct lyd_node *dnode = mm->candidate_ds->root.cfg_root->dnode;
+	if (dnode)

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#281: FILE: /tmp/f1-3187773/mgmt_ds.c:281:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#283: FILE: /tmp/f1-3187773/mgmt_ds.c:283:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#291: FILE: /tmp/f1-3187773/mgmt_ds.c:291:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#293: FILE: /tmp/f1-3187773/mgmt_ds.c:293:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#301: FILE: /tmp/f1-3187773/mgmt_ds.c:301:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#309: FILE: /tmp/f1-3187773/mgmt_ds.c:309:
+		return EINVAL;
Report for mgmt_fe_adapter.c | 46 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#37: FILE: /tmp/f1-3187773/mgmt_fe_adapter.c:37:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_fe_adapters, &mgmt_fe_adapters, (adapter))

ERROR: Macros with complex values should be enclosed in parentheses
#62: FILE: /tmp/f1-3187773/mgmt_fe_adapter.c:62:
+#define FOREACH_SESSION_IN_LIST(adapter, session)                              \
+	frr_each_safe (mgmt_fe_sessions, &(adapter)->fe_sessions, (session))

WARNING: line over 80 characters
#498: FILE: /tmp/f1-3187773/mgmt_fe_adapter.c:498:
+			gettimeofday(&session->adapter->cmt_stats.last_end, NULL);

WARNING: line over 80 characters
#721: FILE: /tmp/f1-3187773/mgmt_fe_adapter.c:721:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#1114: FILE: /tmp/f1-3187773/mgmt_fe_adapter.c:1114:
+				session, getdata_req->ds_id, getdata_req->req_id,

WARNING: line over 80 characters
#1499: FILE: /tmp/f1-3187773/mgmt_fe_adapter.c:1499:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#1789: FILE: /tmp/f1-3187773/mgmt_fe_adapter.c:1789:
+					&adapter->cmt_stats.apply_cfg_start, buf,

WARNING: line over 80 characters
#1827: FILE: /tmp/f1-3187773/mgmt_fe_adapter.c:1827:
+			mgmt_realtime_to_string(&adapter->setcfg_stats.last_start,

WARNING: line over 80 characters
#1869: FILE: /tmp/f1-3187773/mgmt_fe_adapter.c:1869:
+						session->ds_locked_implict[ds_id]

WARNING: line over 80 characters
#1903: FILE: /tmp/f1-3187773/mgmt_fe_adapter.c:1903:
+		memset(&adapter->setcfg_stats, 0, sizeof(adapter->setcfg_stats));

WARNING: line over 80 characters
#1905: FILE: /tmp/f1-3187773/mgmt_fe_adapter.c:1905:
+			memset(&adapter->cmt_stats, 0, sizeof(adapter->cmt_stats));
Report for mgmt_fe_client.c | 25 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#69: FILE: /tmp/f1-3187773/mgmt_fe_client.c:69:
+#define FOREACH_SESSION_IN_LIST(client_ctx, session)                           \
+	frr_each_safe (mgmt_sessions, &(client_ctx)->client_sessions, (session))

WARNING: line over 80 characters
#112: FILE: /tmp/f1-3187773/mgmt_fe_client.c:112:
+				"Found session %p for session-id %llu.", session,

WARNING: line over 80 characters
#277: FILE: /tmp/f1-3187773/mgmt_fe_client.c:277:
+		lock ? "" : "UN", ds_id, (unsigned long long)session->client_id);

WARNING: line over 80 characters
#317: FILE: /tmp/f1-3187773/mgmt_fe_client.c:317:
+			       Mgmtd__DatastoreId dest_ds_id, bool validate_only,

WARNING: line over 80 characters
#454: FILE: /tmp/f1-3187773/mgmt_fe_client.c:454:
+						->session_reply->client_conn_id);

WARNING: line over 80 characters
#461: FILE: /tmp/f1-3187773/mgmt_fe_client.c:461:
+						->session_reply->client_conn_id);
Report for mgmt_history.c | 30 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#29: FILE: /tmp/f1-3187773/mgmt_history.c:29:
+#define FOREACH_CMT_REC(mm, cmt_info)                                          \
+	frr_each_safe (mgmt_cmt_infos, &mm->cmts, cmt_info)

ERROR: do not initialise statics to NULL
#36: FILE: /tmp/f1-3187773/mgmt_history.c:36:
+static struct vty *rollback_vty = NULL;

WARNING: line over 80 characters
#103: FILE: /tmp/f1-3187773/mgmt_history.c:103:
+static struct mgmt_cmt_info_t *mgmt_history_find_cmt_record(const char *cmtid_str)

WARNING: line over 80 characters
#132: FILE: /tmp/f1-3187773/mgmt_history.c:132:
+			if (!mgmt_history_record_exists(cmt_info.cmt_json_file)) {

WARNING: line over 80 characters
#284: FILE: /tmp/f1-3187773/mgmt_history.c:284:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: line over 80 characters
#323: FILE: /tmp/f1-3187773/mgmt_history.c:323:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: Missing a blank line after declarations
#358: FILE: /tmp/f1-3187773/mgmt_history.c:358:
+	struct mgmt_cmt_info_t *cmt_info = mgmt_history_create_cmt_rec();
+	mgmt_ds_dump_ds_to_file(cmt_info->cmt_json_file, ds_ctx);
Report for mgmt_history.h | 5 issues
===============================================
WARNING: Block comments should align the * on each line
#3: FILE: /tmp/f1-3187773/mgmt_history.h:3:
+/*
+  * Copyright (C) 2021  Vmware, Inc.
Report for mgmt_msg.c | 5 issues
===============================================
WARNING: else is not generally useful after a break or return
#225: FILE: /tmp/f1-3187773/mgmt_msg.c:225:
+				return MSW_SCHED_STREAM;
+			} else
Report for mgmt_txn.c | 20 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#108: FILE: /tmp/f1-3187773/mgmt_txn.c:108:
+#define FOREACH_TXN_CFG_BATCH_IN_LIST(list, batch)                             \
+	frr_each_safe (mgmt_txn_batches, list, batch)

ERROR: Macros with complex values should be enclosed in parentheses
#208: FILE: /tmp/f1-3187773/mgmt_txn.c:208:
+#define FOREACH_TXN_REQ_IN_LIST(list, req)                                     \
+	frr_each_safe (mgmt_txn_reqs, list, req)

ERROR: Macros with complex values should be enclosed in parentheses
#263: FILE: /tmp/f1-3187773/mgmt_txn.c:263:
+#define FOREACH_TXN_IN_LIST(mm, txn)                                           \
+	frr_each_safe (mgmt_txns, &(mm)->txn_list, (txn))

WARNING: Missing a blank line after declarations
#1259: FILE: /tmp/f1-3187773/mgmt_txn.c:1259:
+	char err_buf[1024] = {0};
+	nb_ctx.client = NB_CLIENT_MGMTD_SERVER;
Report for mgmt_vty.c | 10 issues
===============================================
WARNING: Missing a blank line after declarations
#392: FILE: /tmp/f1-3187773/mgmt_vty.c:392:
+	int n = mgmt_debug_be + mgmt_debug_fe + mgmt_debug_ds + mgmt_debug_txn;
+	if (!n)

WARNING: Missing a blank line after declarations
#427: FILE: /tmp/f1-3187773/mgmt_vty.c:427:
+	bool set = !no;
+	if (all)
Report for static_vty.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #385: FILE: /tmp/f1-3187773/static_vty.c:385:
< WARNING: line over 80 characters
< #407: FILE: /tmp/f1-3187773/static_vty.c:407:
Report for vty.c | 8 issues
===============================================
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3491: FILE: /tmp/f1-3187773/vty.c:3491:
< WARNING: line over 80 characters
< #3506: FILE: /tmp/f1-3187773/vty.c:3506:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3592: FILE: /tmp/f1-3187773/vty.c:3592:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3628: FILE: /tmp/f1-3187773/vty.c:3628:

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10308/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Redhat 9 amd64 build: Failed (click for details)

Configure failed for Redhat 9 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10308/artifact/RH9BUILD/ErrorLog/log_configure.txt)

checking for sendmmsg... yes
checking for explicit_bzero... yes
checking for struct mmsghdr.msg_hdr... yes
checking for protoc... no
checking for protoc-c... no
configure: error: in `/home/ci/cibuild.10308/frr-source':
configure: error: protobuf requested but protoc-c not found.  Install protobuf-c.
See `config.log' for more details

Redhat 9 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10308/artifact/RH9BUILD/config.log/config.log

Successful on other platforms/tests

• Redhat 8 amd64 build
• Fedora 29 amd64 build
• OpenBSD 7 amd64 build
• Debian 10 amd64 build
• Debian 9 amd64 build
• Ubuntu 16.04 arm7 build
• Ubuntu 20.04 amd64 build
• Ubuntu 18.04 ppc64le build
• Ubuntu 18.04 amd64 build
• FreeBSD 11 amd64 build
• Ubuntu 22.04 amd64 build
• FreeBSD 12 amd64 build
• Ubuntu 16.04 arm8 build
• Ubuntu 16.04 amd64 build
• CentOS 7 amd64 build
• Ubuntu 18.04 i386 build
• Ubuntu 18.04 arm7 build
• Ubuntu 18.04 arm8 build
• Ubuntu 16.04 i386 build
• Debian 11 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Redhat 9 amd64 build: Failed (click for details)

Configure failed for Redhat 9 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10308/artifact/RH9BUILD/ErrorLog/log_configure.txt)

checking for sendmmsg... yes
checking for explicit_bzero... yes
checking for struct mmsghdr.msg_hdr... yes
checking for protoc... no
checking for protoc-c... no
configure: error: in `/home/ci/cibuild.10308/frr-source':
configure: error: protobuf requested but protoc-c not found.  Install protobuf-c.
See `config.log' for more details

Redhat 9 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-PULLREQ2-10308/artifact/RH9BUILD/config.log/config.log

<stdin>:17923: trailing whitespace.
    
warning: 1 line adds whitespace errors.
Report for mgmt_be_adapter.c | 29 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#36: FILE: /tmp/f1-3284739/mgmt_be_adapter.c:36:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_be_adapters, &mgmt_be_adapters, (adapter))

ERROR: space required after that close brace '}'
#85: FILE: /tmp/f1-3284739/mgmt_be_adapter.c:85:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#92: FILE: /tmp/f1-3284739/mgmt_be_adapter.c:92:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#101: FILE: /tmp/f1-3284739/mgmt_be_adapter.c:101:
+			 MGMTD_BE_CLIENT_ID_MAX}},

WARNING: line over 80 characters
#351: FILE: /tmp/f1-3284739/mgmt_be_adapter.c:351:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#744: FILE: /tmp/f1-3284739/mgmt_be_adapter.c:744:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#757: FILE: /tmp/f1-3284739/mgmt_be_adapter.c:757:
+				 adapter, adapter->conn_fd, &adapter->conn_write_ev);
Report for mgmt_be_client.c | 23 issues
===============================================
WARNING: line over 80 characters
#27: FILE: /tmp/f1-3284739/mgmt_be_client.c:27:
+			zlog_debug("%s: " fmt, __func__, ##__VA_ARGS__);         \

ERROR: Macros with complex values should be enclosed in parentheses
#100: FILE: /tmp/f1-3284739/mgmt_be_client.c:100:
+#define FOREACH_BE_TXN_BATCH_IN_LIST(txn, batch)                               \
+	frr_each_safe (mgmt_be_batches, &(txn)->cfg_batches, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#103: FILE: /tmp/f1-3284739/mgmt_be_client.c:103:
+#define FOREACH_BE_APPLY_BATCH_IN_LIST(txn, batch)                             \
+	frr_each_safe (mgmt_be_batches, &(txn)->apply_cfgs, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#136: FILE: /tmp/f1-3284739/mgmt_be_client.c:136:
+#define FOREACH_BE_TXN_IN_LIST(client_ctx, txn)                                \
+	frr_each_safe (mgmt_be_txns, &(client_ctx)->txn_head, (txn))

WARNING: line over 80 characters
#600: FILE: /tmp/f1-3284739/mgmt_be_client.c:600:
+			client_ctx->avg_prep_nb_cfg_tm, (uint32_t)num_processed);
Report for mgmt_ds.c | 29 issues
===============================================
WARNING: Missing a blank line after declarations
#193: FILE: /tmp/f1-3284739/mgmt_ds.c:193:
+	struct lyd_node *dnode = mm->candidate_ds->root.cfg_root->dnode;
+	if (dnode)

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#281: FILE: /tmp/f1-3284739/mgmt_ds.c:281:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#283: FILE: /tmp/f1-3284739/mgmt_ds.c:283:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#291: FILE: /tmp/f1-3284739/mgmt_ds.c:291:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#293: FILE: /tmp/f1-3284739/mgmt_ds.c:293:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#301: FILE: /tmp/f1-3284739/mgmt_ds.c:301:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#309: FILE: /tmp/f1-3284739/mgmt_ds.c:309:
+		return EINVAL;
Report for mgmt_fe_adapter.c | 46 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#37: FILE: /tmp/f1-3284739/mgmt_fe_adapter.c:37:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_fe_adapters, &mgmt_fe_adapters, (adapter))

ERROR: Macros with complex values should be enclosed in parentheses
#62: FILE: /tmp/f1-3284739/mgmt_fe_adapter.c:62:
+#define FOREACH_SESSION_IN_LIST(adapter, session)                              \
+	frr_each_safe (mgmt_fe_sessions, &(adapter)->fe_sessions, (session))

WARNING: line over 80 characters
#498: FILE: /tmp/f1-3284739/mgmt_fe_adapter.c:498:
+			gettimeofday(&session->adapter->cmt_stats.last_end, NULL);

WARNING: line over 80 characters
#721: FILE: /tmp/f1-3284739/mgmt_fe_adapter.c:721:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#1114: FILE: /tmp/f1-3284739/mgmt_fe_adapter.c:1114:
+				session, getdata_req->ds_id, getdata_req->req_id,

WARNING: line over 80 characters
#1499: FILE: /tmp/f1-3284739/mgmt_fe_adapter.c:1499:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#1789: FILE: /tmp/f1-3284739/mgmt_fe_adapter.c:1789:
+					&adapter->cmt_stats.apply_cfg_start, buf,

WARNING: line over 80 characters
#1827: FILE: /tmp/f1-3284739/mgmt_fe_adapter.c:1827:
+			mgmt_realtime_to_string(&adapter->setcfg_stats.last_start,

WARNING: line over 80 characters
#1869: FILE: /tmp/f1-3284739/mgmt_fe_adapter.c:1869:
+						session->ds_locked_implict[ds_id]

WARNING: line over 80 characters
#1903: FILE: /tmp/f1-3284739/mgmt_fe_adapter.c:1903:
+		memset(&adapter->setcfg_stats, 0, sizeof(adapter->setcfg_stats));

WARNING: line over 80 characters
#1905: FILE: /tmp/f1-3284739/mgmt_fe_adapter.c:1905:
+			memset(&adapter->cmt_stats, 0, sizeof(adapter->cmt_stats));
Report for mgmt_fe_client.c | 25 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#69: FILE: /tmp/f1-3284739/mgmt_fe_client.c:69:
+#define FOREACH_SESSION_IN_LIST(client_ctx, session)                           \
+	frr_each_safe (mgmt_sessions, &(client_ctx)->client_sessions, (session))

WARNING: line over 80 characters
#112: FILE: /tmp/f1-3284739/mgmt_fe_client.c:112:
+				"Found session %p for session-id %llu.", session,

WARNING: line over 80 characters
#277: FILE: /tmp/f1-3284739/mgmt_fe_client.c:277:
+		lock ? "" : "UN", ds_id, (unsigned long long)session->client_id);

WARNING: line over 80 characters
#317: FILE: /tmp/f1-3284739/mgmt_fe_client.c:317:
+			       Mgmtd__DatastoreId dest_ds_id, bool validate_only,

WARNING: line over 80 characters
#454: FILE: /tmp/f1-3284739/mgmt_fe_client.c:454:
+						->session_reply->client_conn_id);

WARNING: line over 80 characters
#461: FILE: /tmp/f1-3284739/mgmt_fe_client.c:461:
+						->session_reply->client_conn_id);
Report for mgmt_history.c | 30 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#29: FILE: /tmp/f1-3284739/mgmt_history.c:29:
+#define FOREACH_CMT_REC(mm, cmt_info)                                          \
+	frr_each_safe (mgmt_cmt_infos, &mm->cmts, cmt_info)

ERROR: do not initialise statics to NULL
#36: FILE: /tmp/f1-3284739/mgmt_history.c:36:
+static struct vty *rollback_vty = NULL;

WARNING: line over 80 characters
#103: FILE: /tmp/f1-3284739/mgmt_history.c:103:
+static struct mgmt_cmt_info_t *mgmt_history_find_cmt_record(const char *cmtid_str)

WARNING: line over 80 characters
#132: FILE: /tmp/f1-3284739/mgmt_history.c:132:
+			if (!mgmt_history_record_exists(cmt_info.cmt_json_file)) {

WARNING: line over 80 characters
#284: FILE: /tmp/f1-3284739/mgmt_history.c:284:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: line over 80 characters
#323: FILE: /tmp/f1-3284739/mgmt_history.c:323:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: Missing a blank line after declarations
#358: FILE: /tmp/f1-3284739/mgmt_history.c:358:
+	struct mgmt_cmt_info_t *cmt_info = mgmt_history_create_cmt_rec();
+	mgmt_ds_dump_ds_to_file(cmt_info->cmt_json_file, ds_ctx);
Report for mgmt_history.h | 5 issues
===============================================
WARNING: Block comments should align the * on each line
#3: FILE: /tmp/f1-3284739/mgmt_history.h:3:
+/*
+  * Copyright (C) 2021  Vmware, Inc.
Report for mgmt_msg.c | 5 issues
===============================================
WARNING: else is not generally useful after a break or return
#225: FILE: /tmp/f1-3284739/mgmt_msg.c:225:
+				return MSW_SCHED_STREAM;
+			} else
Report for mgmt_txn.c | 20 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#108: FILE: /tmp/f1-3284739/mgmt_txn.c:108:
+#define FOREACH_TXN_CFG_BATCH_IN_LIST(list, batch)                             \
+	frr_each_safe (mgmt_txn_batches, list, batch)

ERROR: Macros with complex values should be enclosed in parentheses
#208: FILE: /tmp/f1-3284739/mgmt_txn.c:208:
+#define FOREACH_TXN_REQ_IN_LIST(list, req)                                     \
+	frr_each_safe (mgmt_txn_reqs, list, req)

ERROR: Macros with complex values should be enclosed in parentheses
#263: FILE: /tmp/f1-3284739/mgmt_txn.c:263:
+#define FOREACH_TXN_IN_LIST(mm, txn)                                           \
+	frr_each_safe (mgmt_txns, &(mm)->txn_list, (txn))

WARNING: Missing a blank line after declarations
#1259: FILE: /tmp/f1-3284739/mgmt_txn.c:1259:
+	char err_buf[1024] = {0};
+	nb_ctx.client = NB_CLIENT_MGMTD_SERVER;
Report for mgmt_vty.c | 10 issues
===============================================
WARNING: Missing a blank line after declarations
#392: FILE: /tmp/f1-3284739/mgmt_vty.c:392:
+	int n = mgmt_debug_be + mgmt_debug_fe + mgmt_debug_ds + mgmt_debug_txn;
+	if (!n)

WARNING: Missing a blank line after declarations
#427: FILE: /tmp/f1-3284739/mgmt_vty.c:427:
+	bool set = !no;
+	if (all)
Report for static_vty.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #385: FILE: /tmp/f1-3284739/static_vty.c:385:
< WARNING: line over 80 characters
< #407: FILE: /tmp/f1-3284739/static_vty.c:407:
Report for vty.c | 8 issues
===============================================
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3491: FILE: /tmp/f1-3284739/vty.c:3491:
< WARNING: line over 80 characters
< #3506: FILE: /tmp/f1-3284739/vty.c:3506:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3592: FILE: /tmp/f1-3284739/vty.c:3592:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3628: FILE: /tmp/f1-3284739/vty.c:3628:

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Jafaral]

New conflicts it seems. With how big this PR is, we are going to see merge conflicts often.

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10323/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: No useful log found

Successful on other platforms/tests

• Ubuntu 18.04 amd64 build
• Ubuntu 16.04 arm8 build
• Ubuntu 16.04 amd64 build
• Ubuntu 18.04 i386 build
• CentOS 7 amd64 build
• Ubuntu 18.04 arm7 build
• Debian 11 amd64 build
• FreeBSD 12 amd64 build
• Ubuntu 16.04 i386 build
• OpenBSD 7 amd64 build
• Redhat 8 amd64 build
• Fedora 29 amd64 build
• Ubuntu 18.04 arm8 build
• Debian 9 amd64 build
• Ubuntu 20.04 amd64 build
• Ubuntu 18.04 ppc64le build
• Redhat 9 amd64 build
• Ubuntu 16.04 arm7 build
• Ubuntu 22.04 amd64 build
• FreeBSD 11 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: No useful log found

<stdin>:17923: trailing whitespace.
    
warning: 1 line adds whitespace errors.
Report for mgmt_be_adapter.c | 29 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#36: FILE: /tmp/f1-3515089/mgmt_be_adapter.c:36:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_be_adapters, &mgmt_be_adapters, (adapter))

ERROR: space required after that close brace '}'
#85: FILE: /tmp/f1-3515089/mgmt_be_adapter.c:85:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#92: FILE: /tmp/f1-3515089/mgmt_be_adapter.c:92:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#101: FILE: /tmp/f1-3515089/mgmt_be_adapter.c:101:
+			 MGMTD_BE_CLIENT_ID_MAX}},

WARNING: line over 80 characters
#351: FILE: /tmp/f1-3515089/mgmt_be_adapter.c:351:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#744: FILE: /tmp/f1-3515089/mgmt_be_adapter.c:744:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#757: FILE: /tmp/f1-3515089/mgmt_be_adapter.c:757:
+				 adapter, adapter->conn_fd, &adapter->conn_write_ev);
Report for mgmt_be_client.c | 23 issues
===============================================
WARNING: line over 80 characters
#27: FILE: /tmp/f1-3515089/mgmt_be_client.c:27:
+			zlog_debug("%s: " fmt, __func__, ##__VA_ARGS__);         \

ERROR: Macros with complex values should be enclosed in parentheses
#100: FILE: /tmp/f1-3515089/mgmt_be_client.c:100:
+#define FOREACH_BE_TXN_BATCH_IN_LIST(txn, batch)                               \
+	frr_each_safe (mgmt_be_batches, &(txn)->cfg_batches, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#103: FILE: /tmp/f1-3515089/mgmt_be_client.c:103:
+#define FOREACH_BE_APPLY_BATCH_IN_LIST(txn, batch)                             \
+	frr_each_safe (mgmt_be_batches, &(txn)->apply_cfgs, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#136: FILE: /tmp/f1-3515089/mgmt_be_client.c:136:
+#define FOREACH_BE_TXN_IN_LIST(client_ctx, txn)                                \
+	frr_each_safe (mgmt_be_txns, &(client_ctx)->txn_head, (txn))

WARNING: line over 80 characters
#600: FILE: /tmp/f1-3515089/mgmt_be_client.c:600:
+			client_ctx->avg_prep_nb_cfg_tm, (uint32_t)num_processed);
Report for mgmt_ds.c | 29 issues
===============================================
WARNING: Missing a blank line after declarations
#193: FILE: /tmp/f1-3515089/mgmt_ds.c:193:
+	struct lyd_node *dnode = mm->candidate_ds->root.cfg_root->dnode;
+	if (dnode)

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#281: FILE: /tmp/f1-3515089/mgmt_ds.c:281:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#283: FILE: /tmp/f1-3515089/mgmt_ds.c:283:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#291: FILE: /tmp/f1-3515089/mgmt_ds.c:291:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#293: FILE: /tmp/f1-3515089/mgmt_ds.c:293:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#301: FILE: /tmp/f1-3515089/mgmt_ds.c:301:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#309: FILE: /tmp/f1-3515089/mgmt_ds.c:309:
+		return EINVAL;
Report for mgmt_fe_adapter.c | 46 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#37: FILE: /tmp/f1-3515089/mgmt_fe_adapter.c:37:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_fe_adapters, &mgmt_fe_adapters, (adapter))

ERROR: Macros with complex values should be enclosed in parentheses
#62: FILE: /tmp/f1-3515089/mgmt_fe_adapter.c:62:
+#define FOREACH_SESSION_IN_LIST(adapter, session)                              \
+	frr_each_safe (mgmt_fe_sessions, &(adapter)->fe_sessions, (session))

WARNING: line over 80 characters
#498: FILE: /tmp/f1-3515089/mgmt_fe_adapter.c:498:
+			gettimeofday(&session->adapter->cmt_stats.last_end, NULL);

WARNING: line over 80 characters
#721: FILE: /tmp/f1-3515089/mgmt_fe_adapter.c:721:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#1114: FILE: /tmp/f1-3515089/mgmt_fe_adapter.c:1114:
+				session, getdata_req->ds_id, getdata_req->req_id,

WARNING: line over 80 characters
#1499: FILE: /tmp/f1-3515089/mgmt_fe_adapter.c:1499:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#1789: FILE: /tmp/f1-3515089/mgmt_fe_adapter.c:1789:
+					&adapter->cmt_stats.apply_cfg_start, buf,

WARNING: line over 80 characters
#1827: FILE: /tmp/f1-3515089/mgmt_fe_adapter.c:1827:
+			mgmt_realtime_to_string(&adapter->setcfg_stats.last_start,

WARNING: line over 80 characters
#1869: FILE: /tmp/f1-3515089/mgmt_fe_adapter.c:1869:
+						session->ds_locked_implict[ds_id]

WARNING: line over 80 characters
#1903: FILE: /tmp/f1-3515089/mgmt_fe_adapter.c:1903:
+		memset(&adapter->setcfg_stats, 0, sizeof(adapter->setcfg_stats));

WARNING: line over 80 characters
#1905: FILE: /tmp/f1-3515089/mgmt_fe_adapter.c:1905:
+			memset(&adapter->cmt_stats, 0, sizeof(adapter->cmt_stats));
Report for mgmt_fe_client.c | 25 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#69: FILE: /tmp/f1-3515089/mgmt_fe_client.c:69:
+#define FOREACH_SESSION_IN_LIST(client_ctx, session)                           \
+	frr_each_safe (mgmt_sessions, &(client_ctx)->client_sessions, (session))

WARNING: line over 80 characters
#112: FILE: /tmp/f1-3515089/mgmt_fe_client.c:112:
+				"Found session %p for session-id %llu.", session,

WARNING: line over 80 characters
#277: FILE: /tmp/f1-3515089/mgmt_fe_client.c:277:
+		lock ? "" : "UN", ds_id, (unsigned long long)session->client_id);

WARNING: line over 80 characters
#317: FILE: /tmp/f1-3515089/mgmt_fe_client.c:317:
+			       Mgmtd__DatastoreId dest_ds_id, bool validate_only,

WARNING: line over 80 characters
#454: FILE: /tmp/f1-3515089/mgmt_fe_client.c:454:
+						->session_reply->client_conn_id);

WARNING: line over 80 characters
#461: FILE: /tmp/f1-3515089/mgmt_fe_client.c:461:
+						->session_reply->client_conn_id);
Report for mgmt_history.c | 30 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#29: FILE: /tmp/f1-3515089/mgmt_history.c:29:
+#define FOREACH_CMT_REC(mm, cmt_info)                                          \
+	frr_each_safe (mgmt_cmt_infos, &mm->cmts, cmt_info)

ERROR: do not initialise statics to NULL
#36: FILE: /tmp/f1-3515089/mgmt_history.c:36:
+static struct vty *rollback_vty = NULL;

WARNING: line over 80 characters
#103: FILE: /tmp/f1-3515089/mgmt_history.c:103:
+static struct mgmt_cmt_info_t *mgmt_history_find_cmt_record(const char *cmtid_str)

WARNING: line over 80 characters
#132: FILE: /tmp/f1-3515089/mgmt_history.c:132:
+			if (!mgmt_history_record_exists(cmt_info.cmt_json_file)) {

WARNING: line over 80 characters
#284: FILE: /tmp/f1-3515089/mgmt_history.c:284:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: line over 80 characters
#323: FILE: /tmp/f1-3515089/mgmt_history.c:323:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: Missing a blank line after declarations
#358: FILE: /tmp/f1-3515089/mgmt_history.c:358:
+	struct mgmt_cmt_info_t *cmt_info = mgmt_history_create_cmt_rec();
+	mgmt_ds_dump_ds_to_file(cmt_info->cmt_json_file, ds_ctx);
Report for mgmt_history.h | 5 issues
===============================================
WARNING: Block comments should align the * on each line
#3: FILE: /tmp/f1-3515089/mgmt_history.h:3:
+/*
+  * Copyright (C) 2021  Vmware, Inc.
Report for mgmt_msg.c | 5 issues
===============================================
WARNING: else is not generally useful after a break or return
#225: FILE: /tmp/f1-3515089/mgmt_msg.c:225:
+				return MSW_SCHED_STREAM;
+			} else
Report for mgmt_txn.c | 20 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#108: FILE: /tmp/f1-3515089/mgmt_txn.c:108:
+#define FOREACH_TXN_CFG_BATCH_IN_LIST(list, batch)                             \
+	frr_each_safe (mgmt_txn_batches, list, batch)

ERROR: Macros with complex values should be enclosed in parentheses
#208: FILE: /tmp/f1-3515089/mgmt_txn.c:208:
+#define FOREACH_TXN_REQ_IN_LIST(list, req)                                     \
+	frr_each_safe (mgmt_txn_reqs, list, req)

ERROR: Macros with complex values should be enclosed in parentheses
#263: FILE: /tmp/f1-3515089/mgmt_txn.c:263:
+#define FOREACH_TXN_IN_LIST(mm, txn)                                           \
+	frr_each_safe (mgmt_txns, &(mm)->txn_list, (txn))

WARNING: Missing a blank line after declarations
#1259: FILE: /tmp/f1-3515089/mgmt_txn.c:1259:
+	char err_buf[1024] = {0};
+	nb_ctx.client = NB_CLIENT_MGMTD_SERVER;
Report for mgmt_vty.c | 10 issues
===============================================
WARNING: Missing a blank line after declarations
#392: FILE: /tmp/f1-3515089/mgmt_vty.c:392:
+	int n = mgmt_debug_be + mgmt_debug_fe + mgmt_debug_ds + mgmt_debug_txn;
+	if (!n)

WARNING: Missing a blank line after declarations
#427: FILE: /tmp/f1-3515089/mgmt_vty.c:427:
+	bool set = !no;
+	if (all)
Report for static_vty.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #385: FILE: /tmp/f1-3515089/static_vty.c:385:
< WARNING: line over 80 characters
< #407: FILE: /tmp/f1-3515089/static_vty.c:407:
Report for vty.c | 8 issues
===============================================
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3491: FILE: /tmp/f1-3515089/vty.c:3491:
< WARNING: line over 80 characters
< #3506: FILE: /tmp/f1-3515089/vty.c:3506:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3592: FILE: /tmp/f1-3515089/vty.c:3592:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3628: FILE: /tmp/f1-3515089/vty.c:3628:

[pushpasis]

@ci:rerun debian buildsystem problem.

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10325/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-10325/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10325/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt

Successful on other platforms/tests

• Topotests Ubuntu 18.04 arm8 part 2
• Topotests debian 10 amd64 part 0
• Addresssanitizer topotests part 9
• Topotests Ubuntu 18.04 i386 part 6
• Topotests debian 10 amd64 part 5
• Topotests Ubuntu 18.04 arm8 part 7
• Ubuntu 16.04 deb pkg check
• Topotests Ubuntu 18.04 i386 part 7
• Topotests Ubuntu 18.04 i386 part 1
• Addresssanitizer topotests part 7
• Topotests Ubuntu 18.04 arm8 part 8
• Topotests Ubuntu 18.04 amd64 part 5
• Topotests Ubuntu 18.04 i386 part 2
• Topotests Ubuntu 18.04 arm8 part 1
• Topotests debian 10 amd64 part 6
• Topotests Ubuntu 18.04 arm8 part 6
• Addresssanitizer topotests part 3
• Topotests Ubuntu 18.04 amd64 part 7
• Fedora 29 rpm pkg check
• Topotests Ubuntu 18.04 i386 part 5
• Topotests Ubuntu 18.04 i386 part 0
• Topotests Ubuntu 18.04 amd64 part 2
• Topotests Ubuntu 18.04 i386 part 8
• Topotests Ubuntu 18.04 i386 part 3
• Topotests debian 10 amd64 part 8
• CentOS 7 rpm pkg check
• Topotests Ubuntu 18.04 amd64 part 4
• Topotests Ubuntu 18.04 arm8 part 4
• Topotests Ubuntu 18.04 arm8 part 9
• Addresssanitizer topotests part 2
• Topotests Ubuntu 18.04 amd64 part 3
• Topotests Ubuntu 18.04 amd64 part 0
• Addresssanitizer topotests part 1
• Static analyzer (clang)
• Topotests Ubuntu 18.04 i386 part 4
• Topotests Ubuntu 18.04 amd64 part 1
• Topotests debian 10 amd64 part 2
• Topotests debian 10 amd64 part 7
• Topotests Ubuntu 18.04 amd64 part 9
• Topotests Ubuntu 18.04 arm8 part 0
• Topotests Ubuntu 18.04 amd64 part 8
• Debian 9 deb pkg check
• Addresssanitizer topotests part 8
• Topotests Ubuntu 18.04 amd64 part 6
• Topotests Ubuntu 18.04 arm8 part 5
• Ubuntu 18.04 deb pkg check
• Ubuntu 20.04 deb pkg check
• Addresssanitizer topotests part 6
• Debian 10 deb pkg check
• Topotests debian 10 amd64 part 1
• Addresssanitizer topotests part 5
• Addresssanitizer topotests part 4
• Addresssanitizer topotests part 0
• Topotests debian 10 amd64 part 3
• Topotests debian 10 amd64 part 4
• Topotests Ubuntu 18.04 arm8 part 3
• Topotests Ubuntu 18.04 i386 part 9

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-10325/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-10325/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt

<stdin>:17923: trailing whitespace.
    
warning: 1 line adds whitespace errors.
Report for mgmt_be_adapter.c | 29 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#36: FILE: /tmp/f1-4132900/mgmt_be_adapter.c:36:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_be_adapters, &mgmt_be_adapters, (adapter))

ERROR: space required after that close brace '}'
#85: FILE: /tmp/f1-4132900/mgmt_be_adapter.c:85:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#92: FILE: /tmp/f1-4132900/mgmt_be_adapter.c:92:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#101: FILE: /tmp/f1-4132900/mgmt_be_adapter.c:101:
+			 MGMTD_BE_CLIENT_ID_MAX}},

WARNING: line over 80 characters
#351: FILE: /tmp/f1-4132900/mgmt_be_adapter.c:351:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#744: FILE: /tmp/f1-4132900/mgmt_be_adapter.c:744:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#757: FILE: /tmp/f1-4132900/mgmt_be_adapter.c:757:
+				 adapter, adapter->conn_fd, &adapter->conn_write_ev);
Report for mgmt_be_client.c | 23 issues
===============================================
WARNING: line over 80 characters
#27: FILE: /tmp/f1-4132900/mgmt_be_client.c:27:
+			zlog_debug("%s: " fmt, __func__, ##__VA_ARGS__);         \

ERROR: Macros with complex values should be enclosed in parentheses
#100: FILE: /tmp/f1-4132900/mgmt_be_client.c:100:
+#define FOREACH_BE_TXN_BATCH_IN_LIST(txn, batch)                               \
+	frr_each_safe (mgmt_be_batches, &(txn)->cfg_batches, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#103: FILE: /tmp/f1-4132900/mgmt_be_client.c:103:
+#define FOREACH_BE_APPLY_BATCH_IN_LIST(txn, batch)                             \
+	frr_each_safe (mgmt_be_batches, &(txn)->apply_cfgs, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#136: FILE: /tmp/f1-4132900/mgmt_be_client.c:136:
+#define FOREACH_BE_TXN_IN_LIST(client_ctx, txn)                                \
+	frr_each_safe (mgmt_be_txns, &(client_ctx)->txn_head, (txn))

WARNING: line over 80 characters
#600: FILE: /tmp/f1-4132900/mgmt_be_client.c:600:
+			client_ctx->avg_prep_nb_cfg_tm, (uint32_t)num_processed);
Report for mgmt_ds.c | 29 issues
===============================================
WARNING: Missing a blank line after declarations
#193: FILE: /tmp/f1-4132900/mgmt_ds.c:193:
+	struct lyd_node *dnode = mm->candidate_ds->root.cfg_root->dnode;
+	if (dnode)

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#281: FILE: /tmp/f1-4132900/mgmt_ds.c:281:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#283: FILE: /tmp/f1-4132900/mgmt_ds.c:283:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#291: FILE: /tmp/f1-4132900/mgmt_ds.c:291:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#293: FILE: /tmp/f1-4132900/mgmt_ds.c:293:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#301: FILE: /tmp/f1-4132900/mgmt_ds.c:301:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#309: FILE: /tmp/f1-4132900/mgmt_ds.c:309:
+		return EINVAL;
Report for mgmt_fe_adapter.c | 46 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#37: FILE: /tmp/f1-4132900/mgmt_fe_adapter.c:37:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_fe_adapters, &mgmt_fe_adapters, (adapter))

ERROR: Macros with complex values should be enclosed in parentheses
#62: FILE: /tmp/f1-4132900/mgmt_fe_adapter.c:62:
+#define FOREACH_SESSION_IN_LIST(adapter, session)                              \
+	frr_each_safe (mgmt_fe_sessions, &(adapter)->fe_sessions, (session))

WARNING: line over 80 characters
#498: FILE: /tmp/f1-4132900/mgmt_fe_adapter.c:498:
+			gettimeofday(&session->adapter->cmt_stats.last_end, NULL);

WARNING: line over 80 characters
#721: FILE: /tmp/f1-4132900/mgmt_fe_adapter.c:721:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#1114: FILE: /tmp/f1-4132900/mgmt_fe_adapter.c:1114:
+				session, getdata_req->ds_id, getdata_req->req_id,

WARNING: line over 80 characters
#1499: FILE: /tmp/f1-4132900/mgmt_fe_adapter.c:1499:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#1789: FILE: /tmp/f1-4132900/mgmt_fe_adapter.c:1789:
+					&adapter->cmt_stats.apply_cfg_start, buf,

WARNING: line over 80 characters
#1827: FILE: /tmp/f1-4132900/mgmt_fe_adapter.c:1827:
+			mgmt_realtime_to_string(&adapter->setcfg_stats.last_start,

WARNING: line over 80 characters
#1869: FILE: /tmp/f1-4132900/mgmt_fe_adapter.c:1869:
+						session->ds_locked_implict[ds_id]

WARNING: line over 80 characters
#1903: FILE: /tmp/f1-4132900/mgmt_fe_adapter.c:1903:
+		memset(&adapter->setcfg_stats, 0, sizeof(adapter->setcfg_stats));

WARNING: line over 80 characters
#1905: FILE: /tmp/f1-4132900/mgmt_fe_adapter.c:1905:
+			memset(&adapter->cmt_stats, 0, sizeof(adapter->cmt_stats));
Report for mgmt_fe_client.c | 25 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#69: FILE: /tmp/f1-4132900/mgmt_fe_client.c:69:
+#define FOREACH_SESSION_IN_LIST(client_ctx, session)                           \
+	frr_each_safe (mgmt_sessions, &(client_ctx)->client_sessions, (session))

WARNING: line over 80 characters
#112: FILE: /tmp/f1-4132900/mgmt_fe_client.c:112:
+				"Found session %p for session-id %llu.", session,

WARNING: line over 80 characters
#277: FILE: /tmp/f1-4132900/mgmt_fe_client.c:277:
+		lock ? "" : "UN", ds_id, (unsigned long long)session->client_id);

WARNING: line over 80 characters
#317: FILE: /tmp/f1-4132900/mgmt_fe_client.c:317:
+			       Mgmtd__DatastoreId dest_ds_id, bool validate_only,

WARNING: line over 80 characters
#454: FILE: /tmp/f1-4132900/mgmt_fe_client.c:454:
+						->session_reply->client_conn_id);

WARNING: line over 80 characters
#461: FILE: /tmp/f1-4132900/mgmt_fe_client.c:461:
+						->session_reply->client_conn_id);
Report for mgmt_history.c | 30 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#29: FILE: /tmp/f1-4132900/mgmt_history.c:29:
+#define FOREACH_CMT_REC(mm, cmt_info)                                          \
+	frr_each_safe (mgmt_cmt_infos, &mm->cmts, cmt_info)

ERROR: do not initialise statics to NULL
#36: FILE: /tmp/f1-4132900/mgmt_history.c:36:
+static struct vty *rollback_vty = NULL;

WARNING: line over 80 characters
#103: FILE: /tmp/f1-4132900/mgmt_history.c:103:
+static struct mgmt_cmt_info_t *mgmt_history_find_cmt_record(const char *cmtid_str)

WARNING: line over 80 characters
#132: FILE: /tmp/f1-4132900/mgmt_history.c:132:
+			if (!mgmt_history_record_exists(cmt_info.cmt_json_file)) {

WARNING: line over 80 characters
#284: FILE: /tmp/f1-4132900/mgmt_history.c:284:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: line over 80 characters
#323: FILE: /tmp/f1-4132900/mgmt_history.c:323:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: Missing a blank line after declarations
#358: FILE: /tmp/f1-4132900/mgmt_history.c:358:
+	struct mgmt_cmt_info_t *cmt_info = mgmt_history_create_cmt_rec();
+	mgmt_ds_dump_ds_to_file(cmt_info->cmt_json_file, ds_ctx);
Report for mgmt_history.h | 5 issues
===============================================
WARNING: Block comments should align the * on each line
#3: FILE: /tmp/f1-4132900/mgmt_history.h:3:
+/*
+  * Copyright (C) 2021  Vmware, Inc.
Report for mgmt_msg.c | 5 issues
===============================================
WARNING: else is not generally useful after a break or return
#225: FILE: /tmp/f1-4132900/mgmt_msg.c:225:
+				return MSW_SCHED_STREAM;
+			} else
Report for mgmt_txn.c | 20 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#108: FILE: /tmp/f1-4132900/mgmt_txn.c:108:
+#define FOREACH_TXN_CFG_BATCH_IN_LIST(list, batch)                             \
+	frr_each_safe (mgmt_txn_batches, list, batch)

ERROR: Macros with complex values should be enclosed in parentheses
#208: FILE: /tmp/f1-4132900/mgmt_txn.c:208:
+#define FOREACH_TXN_REQ_IN_LIST(list, req)                                     \
+	frr_each_safe (mgmt_txn_reqs, list, req)

ERROR: Macros with complex values should be enclosed in parentheses
#263: FILE: /tmp/f1-4132900/mgmt_txn.c:263:
+#define FOREACH_TXN_IN_LIST(mm, txn)                                           \
+	frr_each_safe (mgmt_txns, &(mm)->txn_list, (txn))

WARNING: Missing a blank line after declarations
#1259: FILE: /tmp/f1-4132900/mgmt_txn.c:1259:
+	char err_buf[1024] = {0};
+	nb_ctx.client = NB_CLIENT_MGMTD_SERVER;
Report for mgmt_vty.c | 10 issues
===============================================
WARNING: Missing a blank line after declarations
#392: FILE: /tmp/f1-4132900/mgmt_vty.c:392:
+	int n = mgmt_debug_be + mgmt_debug_fe + mgmt_debug_ds + mgmt_debug_txn;
+	if (!n)

WARNING: Missing a blank line after declarations
#427: FILE: /tmp/f1-4132900/mgmt_vty.c:427:
+	bool set = !no;
+	if (all)
Report for static_vty.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #385: FILE: /tmp/f1-4132900/static_vty.c:385:
< WARNING: line over 80 characters
< #407: FILE: /tmp/f1-4132900/static_vty.c:407:
Report for vty.c | 8 issues
===============================================
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3491: FILE: /tmp/f1-4132900/vty.c:3491:
< WARNING: line over 80 characters
< #3506: FILE: /tmp/f1-4132900/vty.c:3506:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3592: FILE: /tmp/f1-4132900/vty.c:3592:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3628: FILE: /tmp/f1-4132900/vty.c:3628:

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-10326/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

<stdin>:17923: trailing whitespace.
    
warning: 1 line adds whitespace errors.
Report for mgmt_be_adapter.c | 29 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#36: FILE: /tmp/f1-56709/mgmt_be_adapter.c:36:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_be_adapters, &mgmt_be_adapters, (adapter))

ERROR: space required after that close brace '}'
#85: FILE: /tmp/f1-56709/mgmt_be_adapter.c:85:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#92: FILE: /tmp/f1-56709/mgmt_be_adapter.c:92:
+			 MGMTD_BE_CLIENT_ID_MAX}},

ERROR: space required after that close brace '}'
#101: FILE: /tmp/f1-56709/mgmt_be_adapter.c:101:
+			 MGMTD_BE_CLIENT_ID_MAX}},

WARNING: line over 80 characters
#351: FILE: /tmp/f1-56709/mgmt_be_adapter.c:351:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#744: FILE: /tmp/f1-56709/mgmt_be_adapter.c:744:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#757: FILE: /tmp/f1-56709/mgmt_be_adapter.c:757:
+				 adapter, adapter->conn_fd, &adapter->conn_write_ev);
Report for mgmt_be_client.c | 23 issues
===============================================
WARNING: line over 80 characters
#27: FILE: /tmp/f1-56709/mgmt_be_client.c:27:
+			zlog_debug("%s: " fmt, __func__, ##__VA_ARGS__);         \

ERROR: Macros with complex values should be enclosed in parentheses
#100: FILE: /tmp/f1-56709/mgmt_be_client.c:100:
+#define FOREACH_BE_TXN_BATCH_IN_LIST(txn, batch)                               \
+	frr_each_safe (mgmt_be_batches, &(txn)->cfg_batches, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#103: FILE: /tmp/f1-56709/mgmt_be_client.c:103:
+#define FOREACH_BE_APPLY_BATCH_IN_LIST(txn, batch)                             \
+	frr_each_safe (mgmt_be_batches, &(txn)->apply_cfgs, (batch))

ERROR: Macros with complex values should be enclosed in parentheses
#136: FILE: /tmp/f1-56709/mgmt_be_client.c:136:
+#define FOREACH_BE_TXN_IN_LIST(client_ctx, txn)                                \
+	frr_each_safe (mgmt_be_txns, &(client_ctx)->txn_head, (txn))

WARNING: line over 80 characters
#600: FILE: /tmp/f1-56709/mgmt_be_client.c:600:
+			client_ctx->avg_prep_nb_cfg_tm, (uint32_t)num_processed);
Report for mgmt_ds.c | 29 issues
===============================================
WARNING: Missing a blank line after declarations
#193: FILE: /tmp/f1-56709/mgmt_ds.c:193:
+	struct lyd_node *dnode = mm->candidate_ds->root.cfg_root->dnode;
+	if (dnode)

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#281: FILE: /tmp/f1-56709/mgmt_ds.c:281:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#283: FILE: /tmp/f1-56709/mgmt_ds.c:283:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#291: FILE: /tmp/f1-56709/mgmt_ds.c:291:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EBUSY)
#293: FILE: /tmp/f1-56709/mgmt_ds.c:293:
+		return EBUSY;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#301: FILE: /tmp/f1-56709/mgmt_ds.c:301:
+		return EINVAL;

WARNING: return of an errno should typically be negative (ie: return -EINVAL)
#309: FILE: /tmp/f1-56709/mgmt_ds.c:309:
+		return EINVAL;
Report for mgmt_fe_adapter.c | 46 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#37: FILE: /tmp/f1-56709/mgmt_fe_adapter.c:37:
+#define FOREACH_ADAPTER_IN_LIST(adapter)                                       \
+	frr_each_safe (mgmt_fe_adapters, &mgmt_fe_adapters, (adapter))

ERROR: Macros with complex values should be enclosed in parentheses
#62: FILE: /tmp/f1-56709/mgmt_fe_adapter.c:62:
+#define FOREACH_SESSION_IN_LIST(adapter, session)                              \
+	frr_each_safe (mgmt_fe_sessions, &(adapter)->fe_sessions, (session))

WARNING: line over 80 characters
#498: FILE: /tmp/f1-56709/mgmt_fe_adapter.c:498:
+			gettimeofday(&session->adapter->cmt_stats.last_end, NULL);

WARNING: line over 80 characters
#721: FILE: /tmp/f1-56709/mgmt_fe_adapter.c:721:
+		    && !strncmp(adapter->name, old->name, sizeof(adapter->name))) {

WARNING: line over 80 characters
#1114: FILE: /tmp/f1-56709/mgmt_fe_adapter.c:1114:
+				session, getdata_req->ds_id, getdata_req->req_id,

WARNING: line over 80 characters
#1499: FILE: /tmp/f1-56709/mgmt_fe_adapter.c:1499:
+				adapter, adapter->conn_fd, &adapter->conn_read_ev);

WARNING: line over 80 characters
#1789: FILE: /tmp/f1-56709/mgmt_fe_adapter.c:1789:
+					&adapter->cmt_stats.apply_cfg_start, buf,

WARNING: line over 80 characters
#1827: FILE: /tmp/f1-56709/mgmt_fe_adapter.c:1827:
+			mgmt_realtime_to_string(&adapter->setcfg_stats.last_start,

WARNING: line over 80 characters
#1869: FILE: /tmp/f1-56709/mgmt_fe_adapter.c:1869:
+						session->ds_locked_implict[ds_id]

WARNING: line over 80 characters
#1903: FILE: /tmp/f1-56709/mgmt_fe_adapter.c:1903:
+		memset(&adapter->setcfg_stats, 0, sizeof(adapter->setcfg_stats));

WARNING: line over 80 characters
#1905: FILE: /tmp/f1-56709/mgmt_fe_adapter.c:1905:
+			memset(&adapter->cmt_stats, 0, sizeof(adapter->cmt_stats));
Report for mgmt_fe_client.c | 25 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#69: FILE: /tmp/f1-56709/mgmt_fe_client.c:69:
+#define FOREACH_SESSION_IN_LIST(client_ctx, session)                           \
+	frr_each_safe (mgmt_sessions, &(client_ctx)->client_sessions, (session))

WARNING: line over 80 characters
#112: FILE: /tmp/f1-56709/mgmt_fe_client.c:112:
+				"Found session %p for session-id %llu.", session,

WARNING: line over 80 characters
#277: FILE: /tmp/f1-56709/mgmt_fe_client.c:277:
+		lock ? "" : "UN", ds_id, (unsigned long long)session->client_id);

WARNING: line over 80 characters
#317: FILE: /tmp/f1-56709/mgmt_fe_client.c:317:
+			       Mgmtd__DatastoreId dest_ds_id, bool validate_only,

WARNING: line over 80 characters
#454: FILE: /tmp/f1-56709/mgmt_fe_client.c:454:
+						->session_reply->client_conn_id);

WARNING: line over 80 characters
#461: FILE: /tmp/f1-56709/mgmt_fe_client.c:461:
+						->session_reply->client_conn_id);
Report for mgmt_history.c | 30 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#29: FILE: /tmp/f1-56709/mgmt_history.c:29:
+#define FOREACH_CMT_REC(mm, cmt_info)                                          \
+	frr_each_safe (mgmt_cmt_infos, &mm->cmts, cmt_info)

ERROR: do not initialise statics to NULL
#36: FILE: /tmp/f1-56709/mgmt_history.c:36:
+static struct vty *rollback_vty = NULL;

WARNING: line over 80 characters
#103: FILE: /tmp/f1-56709/mgmt_history.c:103:
+static struct mgmt_cmt_info_t *mgmt_history_find_cmt_record(const char *cmtid_str)

WARNING: line over 80 characters
#132: FILE: /tmp/f1-56709/mgmt_history.c:132:
+			if (!mgmt_history_record_exists(cmt_info.cmt_json_file)) {

WARNING: line over 80 characters
#284: FILE: /tmp/f1-56709/mgmt_history.c:284:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: line over 80 characters
#323: FILE: /tmp/f1-56709/mgmt_history.c:323:
+			ret = mgmt_history_rollback_to_cmt(vty, cmt_info, false);

WARNING: Missing a blank line after declarations
#358: FILE: /tmp/f1-56709/mgmt_history.c:358:
+	struct mgmt_cmt_info_t *cmt_info = mgmt_history_create_cmt_rec();
+	mgmt_ds_dump_ds_to_file(cmt_info->cmt_json_file, ds_ctx);
Report for mgmt_history.h | 5 issues
===============================================
WARNING: Block comments should align the * on each line
#3: FILE: /tmp/f1-56709/mgmt_history.h:3:
+/*
+  * Copyright (C) 2021  Vmware, Inc.
Report for mgmt_msg.c | 5 issues
===============================================
WARNING: else is not generally useful after a break or return
#225: FILE: /tmp/f1-56709/mgmt_msg.c:225:
+				return MSW_SCHED_STREAM;
+			} else
Report for mgmt_txn.c | 20 issues
===============================================
ERROR: Macros with complex values should be enclosed in parentheses
#108: FILE: /tmp/f1-56709/mgmt_txn.c:108:
+#define FOREACH_TXN_CFG_BATCH_IN_LIST(list, batch)                             \
+	frr_each_safe (mgmt_txn_batches, list, batch)

ERROR: Macros with complex values should be enclosed in parentheses
#208: FILE: /tmp/f1-56709/mgmt_txn.c:208:
+#define FOREACH_TXN_REQ_IN_LIST(list, req)                                     \
+	frr_each_safe (mgmt_txn_reqs, list, req)

ERROR: Macros with complex values should be enclosed in parentheses
#263: FILE: /tmp/f1-56709/mgmt_txn.c:263:
+#define FOREACH_TXN_IN_LIST(mm, txn)                                           \
+	frr_each_safe (mgmt_txns, &(mm)->txn_list, (txn))

WARNING: Missing a blank line after declarations
#1259: FILE: /tmp/f1-56709/mgmt_txn.c:1259:
+	char err_buf[1024] = {0};
+	nb_ctx.client = NB_CLIENT_MGMTD_SERVER;
Report for mgmt_vty.c | 10 issues
===============================================
WARNING: Missing a blank line after declarations
#392: FILE: /tmp/f1-56709/mgmt_vty.c:392:
+	int n = mgmt_debug_be + mgmt_debug_fe + mgmt_debug_ds + mgmt_debug_txn;
+	if (!n)

WARNING: Missing a blank line after declarations
#427: FILE: /tmp/f1-56709/mgmt_vty.c:427:
+	bool set = !no;
+	if (all)
Report for static_vty.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #385: FILE: /tmp/f1-56709/static_vty.c:385:
< WARNING: line over 80 characters
< #407: FILE: /tmp/f1-56709/static_vty.c:407:
Report for vty.c | 8 issues
===============================================
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3491: FILE: /tmp/f1-56709/vty.c:3491:
< WARNING: line over 80 characters
< #3506: FILE: /tmp/f1-56709/vty.c:3506:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3592: FILE: /tmp/f1-56709/vty.c:3592:
< ERROR: need consistent spacing around '*' (ctx:WxV)
< #3628: FILE: /tmp/f1-56709/vty.c:3628: