Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: FRRouting/frr
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 341424dd06b657dc6f3341f59a72e0f9489fa2f7
Choose a base ref
...
head repository: FRRouting/frr
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e091a750181886f87f92f3b89125ba9310b3534d
Choose a head ref
  • 8 commits
  • 10 files changed
  • 1 contributor

Commits on Oct 8, 2022

  1. zebra: Return statements do not use paranthesis 

    Signed-off-by: Donald Sharp <sharpd@nvidia.com>
    @donaldsharp
    donaldsharp committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    67cb004 View commit details
    Browse the repository at this point in the history

  2. zebra: Add zrouter.asic_notification_nexthop_control 

    Volta submitted notification changes for the dplane that had a
special use case for their system.  Volta is no more, the code
is not being actively developed and from talking with ex-Volta
employees there is no current plans to even maintain this code.
Wrap the special handling of nexthops that their asic-dataplane
did in a bit of code to isolate it and allow for future removal,
as that I do not actually believe anyone else is using this code.
Add a CPP_NOTICE several years into the future that will tell us
to remove the code.  If someone starts using it then they will
have to notice this variable to set it and hopefully they will
see my CPP_NOTICE to come talk to us.  If this is being used then
we can just remove this wrapper.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
    @donaldsharp
    donaldsharp committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    4e13808 View commit details
    Browse the repository at this point in the history

  3. zebra: Re-arrange fpm_read to reduce code duplication 

    Signed-off-by: Donald Sharp <sharpd@nvidia.com>
    @donaldsharp
    donaldsharp committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    8614d57 View commit details
    Browse the repository at this point in the history

  4. zebra: Remove goto's that do not do anything special 

    If we have this semantics:

int ret = FAILURE;

if (foo)
    goto done;

....

done:
    return ret;

This pattern does us no favors and makes it harder to figure out what is going
on.  Let's remove.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
    @donaldsharp
    donaldsharp committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    e3296ff View commit details
    Browse the repository at this point in the history

  5. zebra: Add dplane_ctx_get|set_flags 

    Zebra needs the ability to pass this data around.
Add it to the dplanes ability to pass.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>

zebra: Add a dplane_ctx_set_flags

The dplane_ctx_set_flags call is missing, we will need it.  Add it.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
    @donaldsharp
    donaldsharp committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    5d0a759 View commit details
    Browse the repository at this point in the history

  6. zebra: Rearrange dplane_ctx_route_init 

    In order for a future commit to abstract the dplane_ctx_route_init
so that the kernel can use it, let's move some stuff around
and add a dplane_ctx_route_init_basic that can be used by multiple
different paths

Signed-off-by: Donald Sharp <sharpd@nvidia.com>

create a dplane_ctx_route_init_basic so it can be used

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
    @donaldsharp
    donaldsharp committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    6bdf101 View commit details
    Browse the repository at this point in the history

  7. zebra: Add ctx to netlink message parsing 

    Add the initial step of passing in a dplane context
to reading route netlink messages.  This code
will be run in two contexts:

a) The normal pthread for reading netlink messages from
the kernel
b) The dplane_fpm_nl pthread.

The goal of this commit is too just allow a) to work
b) will be filled in in the future.  Effectively
everything should still be working as it should
pre this change.  We will just possibly allow
the passing of the context around( but not used )

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
    @donaldsharp
    donaldsharp committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    9628b9e View commit details
    Browse the repository at this point in the history

  8. zebra: Read from the dplane_fpm_nl a route update 

    Read from the fpm dplane a route update that will
include status about whether or not the asic was
successfull in offloading the route.

Have this data passed up to zebra for processing and disseminate
this data as appropriate.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
    @donaldsharp
    donaldsharp committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    e091a75 View commit details
    Browse the repository at this point in the history
Loading