Skip to content

Commit b95bda1

Browse files
committed
fix test failed and googleJavaFormat
1 parent e42aa09 commit b95bda1

File tree

5 files changed

+7
-8
lines changed

5 files changed

+7
-8
lines changed

src/main/java/org/fisco/bcos/sdk/v3/crypto/signature/ECDSASignature.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,8 @@ public String getPubFromSig(final byte[] msgHash, final SignatureResult signatur
116116
}
117117

118118
public static String getPubFromSignature(String msgHash, SignatureResult signature) {
119-
CryptoResult verifyResult = NativeInterface.secp256k1RecoverPublicKey(msgHash, signature.toString());
119+
CryptoResult verifyResult =
120+
NativeInterface.secp256k1RecoverPublicKey(msgHash, signature.toString());
120121
if (verifyResult.wedprErrorMessage != null && !verifyResult.wedprErrorMessage.isEmpty()) {
121122
throw new SignatureException(
122123
"Recover public key failed:" + verifyResult.wedprErrorMessage);

src/main/java/org/fisco/bcos/sdk/v3/crypto/signature/HsmSM2Signature.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import org.fisco.bcos.sdk.v3.crypto.exceptions.SignatureException;
1919
import org.fisco.bcos.sdk.v3.crypto.keypair.CryptoKeyPair;
2020
import org.fisco.bcos.sdk.v3.crypto.keypair.HsmSM2KeyPair;
21-
import org.fisco.bcos.sdk.v3.crypto.keypair.SM2KeyPair;
2221
import org.fisco.bcos.sdk.v3.model.CryptoType;
2322
import org.fisco.bcos.sdk.v3.utils.Hex;
2423
import org.fisco.bcos.sdk.v3.utils.Numeric;

src/main/java/org/fisco/bcos/sdk/v3/crypto/signature/SM2Signature.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import com.webank.wedpr.crypto.NativeInterface;
1818
import org.fisco.bcos.sdk.v3.crypto.exceptions.SignatureException;
1919
import org.fisco.bcos.sdk.v3.crypto.keypair.CryptoKeyPair;
20-
import org.fisco.bcos.sdk.v3.crypto.keypair.ECDSAKeyPair;
2120
import org.fisco.bcos.sdk.v3.crypto.keypair.SM2KeyPair;
2221
import org.fisco.bcos.sdk.v3.utils.Hex;
2322
import org.fisco.bcos.sdk.v3.utils.Numeric;

src/main/java/org/fisco/bcos/sdk/v3/crypto/signature/SignatureResult.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public byte[] getS() {
6161
}
6262

6363
public byte[] getPub() {
64-
return new byte[]{};
64+
return new byte[] {};
6565
}
6666

6767
public byte[] getSignatureBytes() {

src/test/java/org/fisco/bcos/sdk/v3/test/crypto/SignatureTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,7 @@ public void testECDSASignature(CryptoSuite cryptoSuite, CryptoKeyPair keyPair) {
366366
// sign
367367
ECDSASignatureResult signatureResult = (ECDSASignatureResult) cryptoSuite.sign(message, keyPair);
368368
//ecrecover
369-
Assert.assertEquals(keyPair.getHexPublicKey(), cryptoSuite.ecrecover(message, signatureResult));
369+
Assert.assertEquals(keyPair.getAddress(), cryptoSuite.ecrecover(message, signatureResult));
370370
// verify
371371
Assert.assertTrue(
372372
cryptoSuite.verify(
@@ -378,7 +378,7 @@ public void testECDSASignature(CryptoSuite cryptoSuite, CryptoKeyPair keyPair) {
378378

379379
// new sign
380380
ECDSASignatureResult newSign = new ECDSASignatureResult(signatureResult.getV(), signatureResult.getR(), signatureResult.getS());
381-
Assert.assertEquals(keyPair.getHexPublicKey(), cryptoSuite.ecrecover(message, newSign));
381+
Assert.assertEquals(keyPair.getAddress(), cryptoSuite.ecrecover(message, newSign));
382382
Assert.assertTrue(
383383
cryptoSuite.verify(
384384
keyPair.getHexPublicKey(), message, newSign.convertToString()));
@@ -422,7 +422,7 @@ public void testSMSignature(CryptoSuite cryptoSuite, CryptoKeyPair keyPair) {
422422
// sign
423423
SM2SignatureResult signatureResult = (SM2SignatureResult) cryptoSuite.sign(message, keyPair);
424424
//ecrecover
425-
Assert.assertEquals(keyPair.getHexPublicKey(), cryptoSuite.ecrecover(message, signatureResult));
425+
Assert.assertEquals(keyPair.getAddress(), cryptoSuite.ecrecover(message, signatureResult));
426426
// verify
427427
Assert.assertTrue(
428428
cryptoSuite.verify(
@@ -434,7 +434,7 @@ public void testSMSignature(CryptoSuite cryptoSuite, CryptoKeyPair keyPair) {
434434

435435
// new sign
436436
SM2SignatureResult newSign = new SM2SignatureResult(signatureResult.getPub(), signatureResult.getR(), signatureResult.getS());
437-
Assert.assertEquals(keyPair.getHexPublicKey(), cryptoSuite.ecrecover(message, newSign));
437+
Assert.assertEquals(keyPair.getAddress(), cryptoSuite.ecrecover(message, newSign));
438438
Assert.assertTrue(
439439
cryptoSuite.verify(
440440
keyPair.getHexPublicKey(), message, newSign.convertToString()));

0 commit comments

Comments
 (0)