Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSS connection when using HTTPS #685

Open
MElkmeshi opened this issue Dec 25, 2023 · 2 comments
Open

WSS connection when using HTTPS #685

MElkmeshi opened this issue Dec 25, 2023 · 2 comments
Labels
bug Something isn't working Local

Comments

@MElkmeshi
Copy link

Describe the bug
When Using HTTPS (ngrok) everything is HTTPS and working great but not the WebSocket in Display or Match Control Page

To Reproduce
Steps to reproduce the behavior:

  1. run FTC Locally
  2. ngrok HTTP 80
  3. Visit the link
  4. login as local
  5. login you will see DISCONNECTED!! above

Expected behavior
it should works I fixed the issue by looking for the file of the code and making these changes:
from new c(t)
to new c(t.replace("ws",window.location.href.includes("https") ? "wss" : "ws"))

Screenshots
Screenshot 2023-12-25 190450
1- error log
2- code error
3- fixing
4- log after fix
Screenshot 2023-12-25 190459

Additional context
I don't know if it's bug or intended behavior but I thought you may want to fix it

@MElkmeshi MElkmeshi added bug Something isn't working Local labels Dec 25, 2023
@Abdullah-Arab
Copy link

This solution helped me, I'm eager to see it merged into the production

@maths22
Copy link
Contributor

maths22 commented Apr 25, 2024

This should no longer be an issue for displays. Other pages will be addressed in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Local
Projects
None yet
Development

No branches or pull requests

3 participants