Skip to content

Support string subdomain IDs#493

Open
pbrubeck wants to merge 1 commit into
FEniCS:mainfrom
firedrakeproject:pbrubeck/string-subdomain-id
Open

Support string subdomain IDs#493
pbrubeck wants to merge 1 commit into
FEniCS:mainfrom
firedrakeproject:pbrubeck/string-subdomain-id

Conversation

@pbrubeck

Copy link
Copy Markdown
Contributor

No description provided.

@jorgensd

Copy link
Copy Markdown
Member

Is there a particular use-case you have in mind for string domain ids?
In general, I think we should revisit the whole ufl.Measure implementation, as it seems a bit limiting.
Especially the integral_types being strings rather than a typing Protocol.
Whenever we add strings we add tons of undefined behavior (or undocumented behavior).

@pbrubeck

Copy link
Copy Markdown
Contributor Author

Is there a particular use-case you have in mind for string domain ids?
In general, I think we should revisit the whole ufl.Measure implementation, as it seems a bit limiting.
Especially the integral_types being strings rather than a typing Protocol.
Whenever we add strings we add tons of undefined behavior (or undocumented behavior).

I can update docstrings. I'm fine if this is revisited. We should avoid breaking API.

firedrakeproject/firedrake#5199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants