Skip to content

Commit b8bc2f1

Browse files
author
Filip Tehlar
committed
ikev2: fix memory leak
Type: fix Change-Id: I33c38c791cc9a28898de402ae831c4862073eb2d Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
1 parent 041add7 commit b8bc2f1

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

src/plugins/ikev2/ikev2.c

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1442,17 +1442,22 @@ ikev2_process_create_child_sa_req (vlib_main_t * vm,
14421442
rekey->tsi = tsi;
14431443
rekey->tsr = tsr;
14441444
/* update Ni */
1445-
vec_free (sa->i_nonce);
1445+
vec_reset_length (sa->i_nonce);
14461446
vec_add (sa->i_nonce, nonce, IKEV2_NONCE_SIZE);
14471447
/* generate new Nr */
14481448
vec_validate (sa->r_nonce, IKEV2_NONCE_SIZE - 1);
14491449
RAND_bytes ((u8 *) sa->r_nonce, IKEV2_NONCE_SIZE);
1450-
vec_free (n);
14511450
}
1451+
else
1452+
goto cleanup_and_exit;
1453+
vec_free (n);
14521454
return 1;
14531455

14541456
cleanup_and_exit:
14551457
vec_free (n);
1458+
vec_free (proposal);
1459+
vec_free (tsr);
1460+
vec_free (tsi);
14561461
return 0;
14571462
}
14581463

0 commit comments

Comments
 (0)