Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vpp repo] Update make go-api-files procedure in VPP repo #74

Open
3 tasks
ondrej-fabry opened this issue Oct 20, 2022 · 2 comments
Open
3 tasks

[vpp repo] Update make go-api-files procedure in VPP repo #74

ondrej-fabry opened this issue Oct 20, 2022 · 2 comments
Assignees

Comments

@ondrej-fabry
Copy link
Member

ondrej-fabry commented Oct 20, 2022

In the VPP repository there is a make target go-api-files for generating Go bindings for VPP binary API from the local API files in the source code. The make target simply executes a Python script generate_go.py that runs go install to get the GoVPP binapi-generator. However it uses some arbitrary commit of GoVPP with the old import path git.fd.io/govpp.git that used before migration to GitHub.

The VPP repository should only use released versions of GoVPP.

Tasks:

  • update to new import path go.fd.io/govpp
  • replace global variable DefaultGoVppCommit=xxx with DefaultGoVppVersion=v0.6.0
  • replace the install procedure for GoVPP for Go older than 1.18 (which is the minimum version) with error "unsupported Go version, please install Go 1.18 or newer"
@fatelei
Copy link

fatelei commented Oct 22, 2022

assign to me

@ondrej-fabry ondrej-fabry changed the title Update procedure of Go bindings generation in VPP repo Update make go-api-files procedure in VPP repo Nov 3, 2022
@sknat
Copy link
Contributor

sknat commented Nov 3, 2022

This could also include updating the documentation page on VPP itself at e.g. https://s3-docs.fd.io/vpp/23.02/interfacing/go/index.html

@ondrej-fabry ondrej-fabry modified the milestone: v0.7.0 Nov 7, 2022
@ondrej-fabry ondrej-fabry added this to the v0.8.0 milestone Nov 15, 2022
@ondrej-fabry ondrej-fabry removed this from the v0.8.0 milestone Jul 10, 2023
@ondrej-fabry ondrej-fabry changed the title Update make go-api-files procedure in VPP repo [vpp repo] Update make go-api-files procedure in VPP repo Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

3 participants