Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot select single words on first attempt in text with headings or blockquotes on iOS #417

Open
QichenZhu opened this issue Jul 4, 2024 · 2 comments · Fixed by #429
Open
Labels
bug Something isn't working

Comments

@QichenZhu
Copy link
Contributor

When attempting to select a single word in text that contains headings or blockquotes, the selection does not work on the first try.

Video

new_issue.mp4
@QichenZhu
Copy link
Contributor Author

@tomekzaw I came across this while testing Expensify/App#44495, and my PR doesn't fix it, so I reported this new issue. Still, I believe the root cause and solution might be similar.

@tomekzaw tomekzaw added the bug Something isn't working label Jul 4, 2024
@tomekzaw
Copy link
Collaborator

This problem is particularly visible when typing fast inside the component that contains blockquotes:

Bold Blockquote
bold.mp4
blockquote.mp4

I believe the problem is caused by NSMutableParagraphStyle. The problem no longer exists when I remove NSMutableParagraphStyle (but obviously there's no padding then). Also, it helps when I make the MarkdownTextInput component uncontrolled. Finally, making the JS thread busy also improves the behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants