-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD Web-Expensify#43646] Fixes to delegate access reauthentication #49375
base: main
Are you sure you want to change the base?
Conversation
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@parasharrajat @puneetlath One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Marking this as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to work for me! @jasperhuangg I reached out separately with a question about related behavior though
@dangrous and I are discussing the other issues via DM. They could potentially affect the solution presented in this PR so I'm going to hold off on merging this for the time being. |
220645c
Okay I think this is ALMOST there - I just tested, and it's working as expected except that: When the delegate token expires and the user is returned to their original account, the LHN swaps nicely, but if you click into any of those chats they aren't loading properly, until you reload the page. |
Thanks for catching that @dangrous, I'll look into that and ping you when it's ready for another look. Seems like some session data probably isn't being updated correctly. |
@dangrous Addressed the bug. It seems we were clearing out the isSidebarLoaded key in Onyx when using delegate access. This was preventing the report screen from appearing as loaded. It should be fine to preserve that key because we never unrender the sidebar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
niceeeee - this works well for me!
Unassigned @parasharrajat since we only need one C+ here and @eVoloshchak was auto-assigned first |
This is ready for review! |
Needs https://github.com/Expensify/Web-Expensify/pull/43646
Details
This PR ensures:
Fixed Issues
$ #48750
Tests/QA
Need someone in ring1 around while QAing to manually expire the authTokens
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2024-09-23.at.11.32.13.AM.mov
MacOS: Desktop