[HOLD #10894][Image][Performance][$2000] Feature Request - Attachments should be cached after first load. It currently load from internet every time - Reported by: @parasharrajat

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Send a attachment to a conversation

Expected Result:

Attachments should be saved on disk for a faster load of the app.

Actual Result:

Attachments should be saved to disk after first load. It currently load from internet every time.

Workaround:

N/A

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.16-0

Reproducible in staging?: Yes
Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1638120119026500

https://www.upwork.com/jobs/~01b1d106b9bd1735e7

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @CortneyOfstad (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[MelvinBot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[tylerkaraszewski]

I think this would be a great feature for people on slow or metered connections. I think it's fairly complex though, as it requires some sort of cache eviction mechanism. We may already have enough of everything we need to do this with Onyx, so it might not be that much work, but it needs to be considered.

I'm happy to stick the external label on it and see what proposals we get.

[MelvinBot]

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[marcaaron]

Last time I checked, attachments are deliberately not cached because they are only accessible with a fresh authToken and a no-cache header i.e. uses the same mechanism as secure receipts. So probably we should first decide whether it is "secure" to add caching (it seems like it would be fine to me - but I can't quite remember the logic around why they are not cached). @thienlnam has looked into this stuff a bunch and might be able guide us.

[thienlnam]

So we should be caching all attachments now already, the next step is likely to store attachments with onyx so this should probably wait until #3867

[MelvinBot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[MelvinBot]

@isagoico, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[parasharrajat]

Ping. It is still need to be worked on....

[JmillsExpensify]

Noting that this same issue affects avatars as well. I linked the related issue above.

[JmillsExpensify]

What issue or convo is this holding on? Can someone link me to it?

Bump on this question. Are we holding on #10894?

[roryabraham]

Are we holding on #10894?

Yes, that's the one!

[roryabraham]

This also got re-reported in slack pretty recently here

[melvin-bot]

@AndrewGable, @mananjadhav, @kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[kevinksullivan]

Not overdue, on hold.

[mallenexpensify]

Snaggin' from you lil Kev cuz I got the tracking issue assigned to me
[Tracking] [Polish] Image-related feature request and improvements #10894

[trjExpensify]

👋 @Beamanator just checking that we need this issue in addition to this one, that has a PR in review already to address?

[Beamanator]

Good point @trjExpensify - this looks a bit like a duplicate / the fix for that issue (& this one) should also fix this one.

[trjExpensify]

Okay, cool. So there's no point us having this hang out. I'm going to close it, and then @parasharrajat I've sent you the reporting offer on the Upwork job linked to this one.