[HOLD for payment 2024-11-07] Bank account - Incorrect error when invalid character is inserted in legal name fields

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.55-9
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): applausetester+kh1610015@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal team
Slack conversation (hyperlinked to channel name):
Found when executing PR #51231

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Expensify Card.
3. Click Issue new card.
4. Click Connect manually.
5. Enter account numbers > Next.
6. On "What's your legal name" step, enter number on the fields.
7. Click Next.

Expected Result:

The error message for invalid name should be "Please enter a valid first name." and "Please enter a valid last name." (production behavior).

Actual Result:

The error message for invalid name should be "This field is required".
The field labels are also different from production. It shows "First name" instead of "Legal first name".

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6650866_1730352319600.20241031_132034.mp4

bandicam.2024-10-31.08-09-38-518.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @puneetlath

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Beamanator]

Sorry, puneet must have been assigned as bugzero so sorry for removing you 😅

[Beamanator]

@burczu @hungvu193 this def looks related to #51231 yeah?

Especially because the field labels are also different from production. It shows "First name" instead of "Legal first name" & same for last name

[hungvu193]

Checking 👀

[NJ-2020]

@hungvu193 I just want to help you, the issue comes from this file ReimbursementAccount/PersonalInfo/substeps/FullName.tsx

Because we remove the the input name validation

And for the FullNameStep component, we should pass customValidate param instead of validate={function}

[hungvu193]

Thanks @NJ-2020, I'm preparing a PR already.

[ikevin127]

I got auto-assigned as reviewer for the PR, I will be able to review it in ~ 8 hours.

If it's more urgent then feel free to re-assign reviewer!

[Beamanator]

Thanks for the heads up @ikevin127 , I think we will move forward w/out your review since this is a deploy blocker 🙏

[Beamanator]

confirmed fixed in staging, no payment needed here 👍

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.55-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Correct validation message for legal name  #51777

If no regressions arise, payment will be issued on 2024-11-07. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment through NewDot Manual Requests

[melvin-bot]

@hungvu193 @puneetlath The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]