Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant reassure tests and improve documentation #51637

Open
mountiny opened this issue Oct 29, 2024 · 2 comments
Open

Remove redundant reassure tests and improve documentation #51637

mountiny opened this issue Oct 29, 2024 · 2 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2

Comments

@mountiny
Copy link
Contributor

Coming from this proposal in Slack.

Problem:

There are redundant/flaky performance tests in the Reassure suite. These tests are difficult to maintain and provide low value, as their scenarios are already covered elsewhere or offer little regression detection. This creates unnecessary complexity, slows down the test suite, and increases the likelihood of false positives.

Solution:

Remove the redundant tests that verify scenarios already covered in separate tests. Eliminate tests that check interactions with minimal impact on regression detection. Focus on retaining tests that provide high-value regression coverage, and reorganize the test suites for better maintainability by moving essential tests to lower levels where they are easier to manage.

  • Move the reassure test documentation to the contributingGuidelines
  • Update the guidelines to provide more guidance on how to prevent adding any redundant tests
@mountiny mountiny added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 29, 2024
@mountiny mountiny self-assigned this Oct 29, 2024
Copy link

melvin-bot bot commented Oct 29, 2024

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@OlimpiaZurek
Copy link
Contributor

Hi! I'm Olimpia from Callstack and I'd like to work on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2
Projects
Development

No branches or pull requests

3 participants