Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Hybrid Android - Emoji picker for status page overlap with save button #51138

Closed
2 of 8 tasks
IuliiaHerets opened this issue Oct 20, 2024 · 25 comments
Closed
2 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Oct 20, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.51-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): testpayment935+468@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Navigate to Expensify hybrid android app
  2. Go to setting - profile - status
  3. Click drop down button to choose emoji

Expected Result:

Emoji picker pop up without any overlap

Actual Result:

Emoji picker overlap with save button when the first status was empty

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6640150_1729417732701.Screen_Recording_20241020_115524.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021848448347625250199
  • Upwork Job ID: 1848448347625250199
  • Last Price Increase: 2024-11-11
Issue OwnerCurrent Issue Owner: @ntdiary
@IuliiaHerets IuliiaHerets added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 20, 2024
Copy link

melvin-bot bot commented Oct 20, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Oct 20, 2024
@IuliiaHerets
Copy link
Author

I marked the issue as a deploy because this issue is not repro on Hybrid prod app
Screenshot_20241020-203825

@IuliiaHerets
Copy link
Author

Issue reproducible on both stg and prod Android App

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment and removed Daily KSv2 labels Oct 20, 2024
Copy link

melvin-bot bot commented Oct 20, 2024

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Oct 20, 2024

💬 A slack conversation has been started in #expensify-open-source

@yuwenmemon
Copy link
Contributor

Since this is reproducible on production as well, I'm removing the deploy blocker and taking this external.

@yuwenmemon yuwenmemon added Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors External Added to denote the issue can be worked on by a contributor and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 21, 2024
@melvin-bot melvin-bot bot changed the title Hybrid Android - Emoji picker for status page overlap with save button [$250] Hybrid Android - Emoji picker for status page overlap with save button Oct 21, 2024
Copy link

melvin-bot bot commented Oct 21, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021848448347625250199

Copy link

melvin-bot bot commented Oct 21, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

@photoday0914
Copy link

Implement a mechanism to detect the available screen space when the emoji picker is activated. This could involve calculating the distance from the bottom of the screen to the save button and positioning the emoji picker above or below it, depending on the available space.

Copy link

melvin-bot bot commented Oct 22, 2024

📣 @photoday0914! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@photoday0914
Copy link

Contributor details
Your Expensify account email: nikoladev86@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/nikolad54

Implement a mechanism to detect the available screen space when the emoji picker is activated. This could involve calculating the distance from the bottom of the screen to the save button and positioning the emoji picker above or below it, depending on the available space. The calculation should be based on screen size. It may use function below.

export const vhToPx = (value, isNum) => {
  var w = window,
    d = document,
    e = d.documentElement,
    g = d.getElementsByTagName('body')[0],
    y = w.innerHeight || e.clientHeight || g.clientHeight

  var result = (y * value) / 100
  if (isNum) {
    return result
  } else {
    return result + 'px'
  }
}

export const responsiveDimension = val => {
  return IsMobile
    ? window.innerWidth / window.innerHeight <= 0.68
      ? mobileScale(val)
      : vhToPx(val)
    : vhToPx(val)
}

Copy link

melvin-bot bot commented Oct 22, 2024

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@ntdiary
Copy link
Contributor

ntdiary commented Oct 22, 2024

Hi, @photoday0914, if you'd like to post a proposal, please read through our contributor guidelines, ensure you can test it on all platforms, and then update your proposal according to the proposal template. :)

Copy link

melvin-bot bot commented Oct 25, 2024

@yuwenmemon, @ntdiary, @anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Oct 25, 2024
Copy link

melvin-bot bot commented Oct 28, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@ntdiary
Copy link
Contributor

ntdiary commented Oct 29, 2024

Still waiting for a valid proposal.

@melvin-bot melvin-bot bot removed the Overdue label Oct 29, 2024
Copy link

melvin-bot bot commented Nov 1, 2024

@yuwenmemon, @ntdiary, @anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Nov 1, 2024
Copy link

melvin-bot bot commented Nov 3, 2024

@yuwenmemon @ntdiary @anmurali this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@QichenZhu
Copy link
Contributor

This seems similar to #48100 and should have been fixed by #51307.

@ntdiary
Copy link
Contributor

ntdiary commented Nov 4, 2024

This seems similar to #48100 and should have been fixed by #51307.

Yeah, I just download the latest ND, this has been fixed. :)

cc @yuwenmemon @anmurali

test.mp4

@melvin-bot melvin-bot bot removed the Overdue label Nov 4, 2024
Copy link

melvin-bot bot commented Nov 4, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot melvin-bot bot added the Overdue label Nov 8, 2024
Copy link

melvin-bot bot commented Nov 11, 2024

@yuwenmemon, @ntdiary, @anmurali Still overdue 6 days?! Let's take care of this!

Copy link

melvin-bot bot commented Nov 11, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot removed the Overdue label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

7 participants