[$250] Handle blocked copilot and Expensify card flows gracefully

[Julesssss]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Similar to this issue, we need to prevent co-pilots from issuing new Expensify cards.

We should implement exact same solution for issue new Expensify card flow, additionally we need to check for company cards as well.

{ "code": 666, "jsonCode": 666, "type": "Expensify\\Libs\\Error\\ExpError", "UUID": "7D862FFF-854D-4AE0-B50B-6C8C96D37AB9", "message": "You must be a domain admin to create the virtual card.", "title": "", "data": [], "htmlMessage": "", "onyxData": [], "requestID": "8d2f62629dff8531-BOM" }

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

N/A

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021846678596552098944
• Upwork Job ID: 1846678596552098944
• Last Price Increase: 2024-10-16

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @ChavdaSachin

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Julesssss]

Hey @jliexpensify we're going to hire @c3024 and @ChavdaSachin as discussed here.

[ChavdaSachin]

coming from here

[c3024]

Please assign me. Thanks!

[jliexpensify]

@Julesssss - just checking: are we paying $250 in this issue, or is Anu handling in the other one? Thanks!

[Julesssss]

Lets keep them seperate

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021846678596552098944

[melvin-bot]

Current assignee @c3024 is eligible for the External assigner, not assigning anyone new.

[jliexpensify]

@ChavdaSachin @c3024 I think I hired the right people? 😅 Let me know if you didn't get an offer

[c3024]

I got the offer on Upwork!

[ChavdaSachin]

Got the offer ✅

[jliexpensify]

@Julesssss are we following the timeline in the other GH? If so, that's set to pay on the 24th.

[Julesssss]

@Julesssss are we following the timeline in the other GH? If so, that's set to pay on the 24th.

Yeah 👍

[Julesssss]

Wait, I have lost track of the PR now.

So could you raise an issue with same c+ here and I will raise a quick PR.
also could you please add my accounts to copilot beta

@ChavdaSachin I can't find the PR, can you share a link please?

[ChavdaSachin]

@Julesssss I haven't raised PR here yet, coz I am testing other scenarios where we might need same implementation.
Like - copilot is able to close owner's account.
So let me prepare a complete list so we can solve this issue for once and all.

[ChavdaSachin]

Will send you a list in a couple hrs, and after your confirmation will raise PR.

[Julesssss]

No worries, thanks for confirming. I'll remove the payment date

[ChavdaSachin]

PR is nearly 80% done, but since it would be large PR - I am spending more time on testing and am focusing on making more scalable changes. Should be delivered within a day or two.

[melvin-bot]

@Julesssss, @jliexpensify, @ChavdaSachin, @c3024 Huh... This is 4 days overdue. Who can take care of this?

[jliexpensify]

Not overdue, PR being worked on

[Julesssss]

Hey @ChavdaSachin, just checking in on this task. Let me know if you need help with anything!

[ChavdaSachin]

hi @Julesssss changes for noDelegateAccessWrapper, and subscription page are yet to be implemented, but I am raising a draft pr for rest of the work already done so you could review those changes in mean time.

[melvin-bot]

Triggered auto assignment to @dubielzyk-expensify (Design), see these Stack Overflow questions for more details.

[Julesssss]

Thanks @ChavdaSachin

Hey @dubielzyk-expensify, @ChavdaSachin is trying to prevent users from performing actions as a copilot and has a good question about blocked actions that are accessed via the three-dot menu. Here's a link to the comment that has screenshots.

Quick question -
On security page in delegates section, both menu items are restricted actions, should we hide three dot menu there?

[dubielzyk-expensify]

If you can't do any of the actions in the three dot menu, then yes, I think it makes sense to remove the icon altogether. @Expensify/design team for gut check

[shawnborton]

Yup, that makes sense to me as well.

[dannymcclain]

I'm fine with hiding it, though elsewhere don't we just allow you to click on an action and then surface the "You can't do that" modal?

[shawnborton]

Oh that's a totally fair point, I forgot about that pattern here.

[dubielzyk-expensify]

Just for my education, where do we do that? I remember buttons like this, but not overflows. FWIW I think that's the right pattern if we have a button

[shawnborton]

Yeah that's a fair point too... when you tap a button, you are told that the action of the button can't be taken:

For the overflow icon... it might feel weird if we throw a big modal in your face after simply tapping a small icon. So I could see where just hiding it is better, or don't hide the three dots and then throw the modal once one of the options from the menu is taken?

[dannymcclain]

don't hide the three dots and then throw the modal once one of the options from the menu is taken?

This is what I was imagining. Definitely don't want to throw the modal after tapping the overflow icon. But the menu items within don't really seem that different from a button to me.

Happy to defer to what you all think is best—just wanted to point out that pattern because I remember us using it elsewhere!

[shawnborton]

But the menu items within don't really seem that different from a button to me.

Yup, totally agree there - that would be my vote.

[dubielzyk-expensify]

SGTM 👍

[melvin-bot]

@Julesssss, @jliexpensify, @ChavdaSachin, @c3024, @dubielzyk-expensify Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@Julesssss @jliexpensify @ChavdaSachin @c3024 @dubielzyk-expensify this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

@Julesssss, @jliexpensify, @ChavdaSachin, @c3024, @dubielzyk-expensify Huh... This is 4 days overdue. Who can take care of this?

[Julesssss]

In progress

[melvin-bot]

@Julesssss, @jliexpensify, @ChavdaSachin, @c3024, @dubielzyk-expensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[ChavdaSachin]

Hey @dubielzyk-expensify I am here trying to block delegates from performing certain actions, and I need your view here.
please take a look at #52103 (comment)