Book travel - Book travel animation becomes blank while RHP is dismissed

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.40-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh230901@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Open FAB
3. Click Book travel
4. Dismiss the RHP

Expected Result:

Book travel animation will not become blank while RHP is dismissed

Actual Result:

Book travel animation becomes blank while RHP is dismissed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6615160_1727291080522.20240926_020845.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[rushatgabhane]

don't know what caused it, but def NOT A BLOCKER

[Nodebrute]

This happens with all the animations, like on the wallet, security, and troubleshoot pages.

[rushatgabhane]

let's close 😄

[MonilBhavsar]

Thanks for looking! Demoting from blocker, but let's try if we can fix it

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Default name in name field displays user/report ID instead of user/report name

What is the root cause of that problem?

This happens as we render an empty view here if the user has navigated away. The issue we set hasNavigatedAway quickly before the RHP animation has been completed. This then shows the user an empty view while RHP is dismissing.

What changes do you think we should make in order to solve the problem?

We will change the state change here: to run after interactions, which will make it wait for the animation to be completed:

App/src/components/Lottie/index.tsx

Lines 82 to 88 in a4a344b

	// If the page navigates to another screen, the image fails to load, app is in background state, animation file isn't ready, or the splash screen isn't hidden yet,
	// we'll just render an empty view as the fallback to prevent
	// 1. memory leak, see issue: https://github.com/Expensify/App/issues/36645
	// 2. heavy rendering, see issues: https://github.com/Expensify/App/issues/34696 and https://github.com/Expensify/App/issues/47273
	// 3. lag on react navigation transitions, see issue: https://github.com/Expensify/App/issues/44812
	if (
	hasNavigatedAway ||

InteractionManager.runAfterInteractions(() => {
    setHasNavigatedAway(true);
});

Result

Screen.Recording.2024-09-26.at.2.36.22.AM.mov

[rushatgabhane]

@MonilBhavsar @neonbhai the reasons mentioned here suggest that we should do nothing. Or it may cause issues 1, 2, 3

But I guess that is only the case when the image hasn't loaded

App/src/components/Lottie/index.tsx

Lines 82 to 88 in a4a344b

	// If the page navigates to another screen, the image fails to load, app is in background state, animation file isn't ready, or the splash screen isn't hidden yet,
	// we'll just render an empty view as the fallback to prevent
	// 1. memory leak, see issue: https://github.com/Expensify/App/issues/36645
	// 2. heavy rendering, see issues: https://github.com/Expensify/App/issues/34696 and https://github.com/Expensify/App/issues/47273
	// 3. lag on react navigation transitions, see issue: https://github.com/Expensify/App/issues/44812
	if (
	hasNavigatedAway ||

[MonilBhavsar]

Since this was reported as a regression, may be it comes from #48040 🤔
Going to check

[MonilBhavsar]

Not reproducible after reverting #48040
@Krishna2323 @hungvu193 if you could please take a look