Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use force while importing polyfill #47140

Open
hurali97 opened this issue Aug 9, 2024 · 4 comments
Open

use force while importing polyfill #47140

hurali97 opened this issue Aug 9, 2024 · 4 comments
Assignees
Labels
Reviewing Has a PR in review Weekly KSv2

Comments

@hurali97
Copy link
Contributor

hurali97 commented Aug 9, 2024

Description:

Based on the comment here, we can profile and validate the gains by using -force while importing the respective polyfill APIs. This should help in reducing the App Startup Time, since we polyfill them upon startup of the App.

Copy link

melvin-bot bot commented Aug 9, 2024

Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@Beamanator
Copy link
Contributor

Hey @hurali97 , it looks like this is a pretty decent idea, especially if it could reduce app startup time! Did you bring this up in our slack channels before creating this issue?

  • If so, great! Can you please link those convos here?
  • If not, can you please bring this up as a Problem / Solution statement so we can get agreement before working on this?

@mountiny
Copy link
Contributor

Damn I did not see there was this issue created before. I will close it in favour of this one #47305 as it has more details now. Assigned you to it too

@mallenexpensify
Copy link
Contributor

mallenexpensify commented Aug 16, 2024

@hurali97 QQ, are you able to add the Bug label to issues you create in E/App? Asking cuz I'm updating the process for agency devs creating issues and PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants