Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-26] [HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] Cancel payment - Inconsistency in reimbursement message after cancelling payment #34676

Closed
6 tasks done
lanitochka17 opened this issue Jan 17, 2024 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Monthly KSv2 Reviewing Has a PR in review

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 17, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.26-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to workspace chat
  2. Create a manual request
  3. Open expense preview
  4. Pay elsewhere the report
  5. Refresh the page
  6. Note that the reimbursement message is "You marked this report as manually reimbursed. This report will be reimbursed outside of Expensify."
  7. Click 3-dot menu > Cancel payment
  8. Refresh the page

Expected Result:

The reimbursement message will remain the same

Actual Result:

The reimbursement message changes to "You marked this report as reimbursed."

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6345744_1705522256680.bandicam_2024-01-18_00-25-22-004.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jan 17, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Jan 17, 2024

Triggered auto assignment to @blimpich (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@lanitochka17
Copy link
Author

@blimpich
Copy link
Contributor

Not a blocker.

@blimpich blimpich removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jan 17, 2024
@blimpich
Copy link
Contributor

Probably related to #33836. CC: @Gonals

@blimpich blimpich added the Weekly KSv2 label Jan 17, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 18, 2024
@melvin-bot melvin-bot bot changed the title Cancel payment - Inconsistency in reimbursement message after cancelling payment [HOLD for payment 2024-01-25] Cancel payment - Inconsistency in reimbursement message after cancelling payment Jan 18, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 18, 2024
Copy link

melvin-bot bot commented Jan 18, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 18, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-25. 🎊

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jan 19, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-01-25] Cancel payment - Inconsistency in reimbursement message after cancelling payment [HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] Cancel payment - Inconsistency in reimbursement message after cancelling payment Jan 19, 2024
Copy link

melvin-bot bot commented Jan 19, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.27-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-26. 🎊

@melvin-bot melvin-bot bot added the Overdue label Jan 29, 2024
@blimpich
Copy link
Contributor

not overdue, waiting for automation to close

@blimpich
Copy link
Contributor

blimpich commented Feb 7, 2024

not overdue, waiting for PR to close

@melvin-bot melvin-bot bot removed the Overdue label Feb 7, 2024
Copy link

melvin-bot bot commented Feb 15, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added the Overdue label Feb 15, 2024
Copy link

melvin-bot bot commented Feb 16, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Feb 16, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Feb 16, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 19, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] Cancel payment - Inconsistency in reimbursement message after cancelling payment [HOLD for payment 2024-02-26] [HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] Cancel payment - Inconsistency in reimbursement message after cancelling payment Feb 19, 2024
@melvin-bot melvin-bot bot removed the Overdue label Feb 19, 2024
Copy link

melvin-bot bot commented Feb 19, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-26. 🎊

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Feb 21, 2024
Copy link

melvin-bot bot commented Feb 26, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Mar 18, 2024
Copy link

melvin-bot bot commented Mar 18, 2024

This issue has not been updated in over 15 days. @blimpich eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@blimpich
Copy link
Contributor

Closing as the fix for this was deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

2 participants