Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-06] [$125] [Form Provider Refactor] BankAccountPlaidStep #31559

Closed
luacmartins opened this issue Nov 20, 2023 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Nov 20, 2023

Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/pages/ReimbursementAccount/BankAccountPlaidStep.js

cc @kowczarz @cdOut

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019decd021d25bec28
  • Upwork Job ID: 1726649372555628544
  • Last Price Increase: 2023-11-21
  • Automatic offers:
    • alitoshmatov | Reviewer | 27774339
@luacmartins luacmartins added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. labels Nov 20, 2023
@luacmartins luacmartins self-assigned this Nov 20, 2023
Copy link

melvin-bot bot commented Nov 20, 2023

Job added to Upwork: https://www.upwork.com/jobs/~019decd021d25bec28

Copy link

melvin-bot bot commented Nov 20, 2023

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Nov 20, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @alitoshmatov (Internal)

This comment was marked as off-topic.

@joekaufmanexpensify
Copy link
Contributor

@luacmartins this is one you're working on?

@luacmartins
Copy link
Contributor Author

Np, just waiting for @cdOut or @kowczarz to comment so I can assign it to them.

@kowczarz
Copy link
Contributor

Hello! I'm from Software Mansion and I will work on this task.

@luacmartins luacmartins added External Added to denote the issue can be worked on by a contributor and removed Internal Requires API changes or must be handled by Expensify staff labels Nov 21, 2023
@melvin-bot melvin-bot bot changed the title [Form Provider Refactor] BankAccountPlaidStep [$500] [Form Provider Refactor] BankAccountPlaidStep Nov 21, 2023
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 21, 2023
Copy link

melvin-bot bot commented Nov 21, 2023

Current assignee @alitoshmatov is eligible for the External assigner, not assigning anyone new.

@luacmartins luacmartins changed the title [$500] [Form Provider Refactor] BankAccountPlaidStep [$125] [Form Provider Refactor] BankAccountPlaidStep Nov 21, 2023
Copy link

melvin-bot bot commented Nov 21, 2023

Upwork job price has been updated to $125

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 21, 2023
Copy link

melvin-bot bot commented Nov 21, 2023

📣 @alitoshmatov 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Nov 22, 2023
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Nov 29, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Nov 29, 2023
@melvin-bot melvin-bot bot changed the title [$125] [Form Provider Refactor] BankAccountPlaidStep [HOLD for payment 2023-12-06] [$125] [Form Provider Refactor] BankAccountPlaidStep Nov 29, 2023
Copy link

melvin-bot bot commented Nov 29, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 29, 2023
Copy link

melvin-bot bot commented Nov 29, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

This comment was marked as off-topic.

@joekaufmanexpensify
Copy link
Contributor

No BZ checklist needed here since this was a refactor, not a bug.

@joekaufmanexpensify
Copy link
Contributor

Only step needed here is $125 payment to @alitoshmatov , paid via Upwork. We'll issue this payment on 2023-12-06 (assuming no regressions).

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 Daily KSv2 labels Dec 5, 2023
@joekaufmanexpensify
Copy link
Contributor

All set to issue payment.

@joekaufmanexpensify
Copy link
Contributor

@alitoshmatov $125 sent and contract ended.

@joekaufmanexpensify
Copy link
Contributor

All set!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jan 18, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants