[HOLD for payment 2024-01-24] [$500] Upgrade react-native to 0.73+

[roryabraham]

Problem

There are two problems that significantly affect us with the current version of react-native we're using:

TL;DR: animations done using RN’s Animated skip changing the shadow tree, which is used to calculate hit regions of views, so animating a pressable will move the view itself, but not its hitbox

which is fixed by facebook/react-native#37836 in 0.73+

Second, there's a very painful delay on starting the android app with npm run android due to a bug in the react-native cli, that's fixed in 0.72.7+

Solution

Upgrade to the latest react-native RC version ASAP.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010abb6a11a875d563
• Upwork Job ID: 1724835564082188288
• Last Price Increase: 2023-11-15

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[WoLewicki]

Let's do it 🚀

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010abb6a11a875d563

[melvin-bot]

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

[roryabraham]

Marking this as external for the sake of C+ payment. @WoLewicki works for SWM and will invoice us separately

[roryabraham]

@WoLewicki any update?

[WoLewicki]

PR is here: #31558 🚀

[melvin-bot]

This issue has not been updated in over 15 days. @WoLewicki, @roryabraham, @laurenreidexpensify, @situchan eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• chore: Update React Native to 0.73.2 #31558

If no regressions arise, payment will be issued on 2024-01-24. 🎊

For reference, here are some details about the assignees on this issue:

• @WoLewicki does not require payment (Contractor)
• @situchan requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[laurenreidexpensify]

@situchan Upwork job is here https://www.upwork.com/jobs/~016f56acd80d15a12e

[situchan]

Is it possible to increase bounty? The PR was large, I had to review and test multiple times, and took responsible for all follow-up issues caused by RN upgrade.
cc: @roryabraham

[laurenreidexpensify]

@situchan sorry I missed this - I've checked with @roryabraham and @mountiny and we agree a one off discretionary bonus makes sense in this case, because of the additional work you did. I will issue this in upwork now.

Sorry for teh delay here, I've been offline unwell!

[laurenreidexpensify]

Payment Summary:

• Contributor @WoLewicki payment N/A - expert contributor
• C+ @situchan $1500 (due to additional work - internal convo here https://expensify.slack.com/archives/C01SKUP7QR0/p1707410501008239) offer sent in Upwork

[laurenreidexpensify]

@situchan pls accept offer and I will issue payment and then we can close

[situchan]

Thanks so much. Offer accepted

[laurenreidexpensify]

Payment issued in upwork. Closing