-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-12-12] [HOLD for payment 2023-11-06] [$500] [Form Provider Refactor] RoomNamePage and WorkspaceNewRoomPage #28877
Comments
Job added to Upwork: https://www.upwork.com/jobs/~01f44006a9fb9bd1d3 |
Triggered auto assignment to @NicMendonca ( |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor Plus for review of internal employee PR - @allroundexperts ( |
Hello! I'm Kamil Owczarz from Software Mansion, the expert agency and I would like to work on this task. |
Current assignee @allroundexperts is eligible for the External assigner, not assigning anyone new. |
@kowczarz any progress on this one? Thanks! |
Hey, probably tomorrow I will prepare a PR. |
I'm working on it. |
Since it's pretty similar case as here #28879 (comment), I will handle |
#28821 Blocks the issue, I think as soon as it will be merged I will be able to prepare a working PR. |
@luacmartins, @NicMendonca, @allroundexperts, @kowczarz Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Waiting for this to merge: #28821 |
@NicMendonca Mind updating the payment summary? |
|
$250 payment approved for @allroundexperts based on summary above. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.7-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-12-12. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
This issue has not been updated in over 15 days. @luacmartins, @NicMendonca, @allroundexperts, @kowczarz eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
we're all set here! |
Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.
This issue is specific to refactoring
src/pages/settings/Report/RoomNamePage.js
andsrc/pages/WorkspaceNewRoomPage.js
cc @kowczarz
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: