[$1000] Issue in saving waypoints; no route displayed

[hayata-suenaga]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

This issue is present on the latest main branch

1. Go to a workspace chat (if you don't have a workspace yet, create one
2. Click the "+" icon next to the text input (i.e. composer)
3. Click Money Request
4. Click the Distance tab on the Right Hand Side panel that appears
5. Select "Start" and type any U.S. address and click a suggested option
6. Select "Finish" and type any U.S. address and click a suggested option
7. Confirm that there is no line drawn on the map to indicate a route between the start and stop points
8. Confirm that there is an error logged out in the developer console of the browser

VIDEO

new.mov

Expected Result:

A route should be drawn on the map

Actual Result:

No route is drawn

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

Only tested on the web, but I suspect the issue is present on all platforms

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f4f0ba58c25296a9
• Upwork Job ID: 1696388884744749056
• Last Price Increase: 2023-08-29

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f4f0ba58c25296a9

[melvin-bot]

Current assignee @muttmuure is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[bernhardoj]

@hayata-suenaga This is a BE issue.

GetRoute API returns onyxData as an object instead of an array of objects.

Onyx.update will try to iterate over the onyxData, but because it's an object, it iterates over the object values.
https://github.com/Expensify/react-native-onyx/blob/06f2bd190bfef9e19288b324606a78bccfa132f8/lib/Onyx.js#L1293-L1306

Here is how other API response looks like

[b4s36t4]

@bernhardoj Were you able to reproduce this issue? if so can you explain me how you did that?

[bernhardoj]

@b4s36t4 Nothing specific. I just follow the reproduction steps.

[b4s36t4]

You tried on local or prod/staging?

[bernhardoj]

local

[b4s36t4]

Ok, thanks for the help.

[melvin-bot]

Current assignee @mollfpr is eligible for the Internal assigner, not assigning anyone new.

[hayata-suenaga]

Using @bernhardoj 's suggestion to fix the issue on the backend

[thienlnam]

@hayata-suenaga I'm handling this in #25980
BE PR was done here https://github.com/Expensify/Web-Expensify/pull/38595

[muttmuure]

Not overdue

[thienlnam]

On staging - the fix is linked to another issue so going to close this one