[HOLD for payment 2023-09-07] [$500] Redirect icon is not highlighted on hover

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to the staging Expensify website.
2. Click on the plus sign and select "Request Money".
3. Add a desired amount and an email address.
4. Click on the requested money.
5. Observe that the redirect icon

Expected Result:

The redirect icon should be highlighted on hover

Actual Result:

The redirect icon is not highlighted on hover

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.56-4
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-capture.-.2023-08-21T233549.020.mp4

Recording.385.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692685377725719

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0138f9abcf1acbfcc9
• Upwork Job ID: 1694124812688658432
• Last Price Increase: 2023-08-22
• Automatic offers:
• dhairyasenjaliya | Contributor | 26374116
• tewodrosGirmaA | Reporter | 26374119

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[dhairyasenjaliya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Redirect icon is not highlighted on hover

What is the root cause of that problem?

• The root cause is we are have not added hover state to check colour of icon

What changes do you think we should make in order to solve the problem?

• We should add fill props to Icon component of arrorRight on ReportPreview.js and MoneyRequestPreview.js

• We should add fill={StyleUtils.getIconFillColor(getButtonState(props.isHovered))} to check hovers state

What alternative solutions did you explore? (Optional)

• N/A
  ———————

Result

Screen.Recording.2023-08-22.at.9.13.32.PM.mov

[sakluger]

This doesn't need to be a deploy blocker, it doesn't block any user actions, and while it's not the intended styling, it doesn't make the feature confusing to the user.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0138f9abcf1acbfcc9

[melvin-bot]

Current assignee @sakluger is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[melvin-bot]

Upwork job price has been updated to $500

[FrancisJTR7]

Proposal: Simply change the color to the "highlighted" color on hover. This would be from #8B9C8F to #9DADA8. This can be done by changing color on hover or if that doesn't work by applying a second icon above it which changes opacity to reveal different colors on hover, etc.. there are many ways to fix this.

[melvin-bot]

📣 @FrancisJTR7! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[FrancisJTR7]

Contributor details
Your Expensify account email: xgalasko@outlook.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0144bc7dc4388ee107

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @dhairyasenjaliya 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @tewodrosGirmaA 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[dhairyasenjaliya]

@allroundexperts PR ready for review

[melvin-bot]

🎯 ⚡️ Woah @allroundexperts / @dhairyasenjaliya, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @dhairyasenjaliya got assigned: 2023-08-28 17:37:17 Z
• when the PR got merged: 2023-08-29 23:40:05 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.59-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Added Fill props to both component #25751

If no regressions arise, payment will be issued on 2023-09-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligible for Manual Requests)
• @dhairyasenjaliya requires payment offer (Contributor)
• @tewodrosGirmaA requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sakluger]

Summarizing payouts for this issue:

Reporter: @tewodrosGirmaA $250 (paid on Upwork
Contributor: @dhairyasenjaliya $750 (paid on Upwork)
Contributor+: @allroundexperts $750 (payable via Manual Request after BZ checklist is completed)

Above payments include efficiency bonus 🎉
Upwork job: https://www.upwork.com/jobs/~0138f9abcf1acbfcc9

[sakluger]

@allroundexperts please let me know once you have finished the BZ checklist and requested payment via NewDot so that I can close the issue, thanks!

[allroundexperts]

Requested payment. Onto the checklist.

[sakluger]

@allroundexperts any updates on the checklist?

[allroundexperts]

Checklist

1. Display receipts in chat #24235
2. https://github.com/Expensify/App/pull/24235/files#r1328152348
3. Slack discussion is not needed here. This was a small UI issue which could have been caught earlier by better testing.
4. Regression test might not be needed here as this was really a very minor UI issue. If however, we feel like a test is necessary, then the following are the steps.

Regression Test Steps

1. Request money manually and open the chat where the IOU Preview is visible.
2. Hover over the IOUPreview component.
3. Verify that the right arrow icon changes colour to white.

Do we 👍 or 👎 ?

[sakluger]

Looks good to me! @allroundexperts please feel free to request the payment, and thanks again!

[JmillsExpensify]

$750 payment for @allroundexperts approved based on BZ summary.