[HOLD for payment 2023-09-04] [$1000] System throws an error while requesting money if a long description & marchant value is given

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open an existing chat
2. Click on '+' icon
3. Click on 'Request money' link
4. Enter amount & click on 'Next' button
5. Click on description > enter over 300 characters value > click on 'Save' button
6. Click on 'Show more' button
7. Click on Marchant > enter over 300 characters value > click on 'Save' button
8. Click on 'Request' button

Expected Result:

Money requests should be successful

Actual Result:

System throws an error

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

**Version Number:**1.3.56-3
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.2023-08-22.09-20-48.mp4

Recording.381.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692686163590699

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016b3cd02197f18a6f
• Upwork Job ID: 1694128412349935616
• Last Price Increase: 2023-08-22
• Automatic offers:
• situchan | Contributor | 26273602
• Natnael-Guchima | Reporter | 26273603
• pradeepmdk | Contributor | 26273680

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[pradeepmdk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

System throws an error while requesting money if a long description & marchant value is given

What is the root cause of that problem?

RequestMoney API this throwing size Exceeded

What changes do you think we should make in order to solve the problem?

we need to limit the character length in the the UI

App/src/pages/iou/MoneyRequestMerchantPage.js

Line 108 in c053381

<TextInput

maxLength

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016b3cd02197f18a6f

[melvin-bot]

Current assignee @isabelastisser is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[joelbettner]

@eVoloshchak the proposal from @pradeepmdk looks good to me.

[pradeepmdk]

@joelbettner can i create the PR Now Due to DeployBlockerCash

[joelbettner]

@pradeepmdk yes you can feel free to start creating that PR in the interest of time.

[pradeepmdk]

Thank you @joelbettner. and i want confirm want is limit should i added in the maxLength currently backend will support unitl 255 character. should i added the same number ?

[joelbettner]

Yes, make it 255. Thank you!

[melvin-bot]

📣 @pradeepmdk 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

🎯 ⚡️ Woah @situchan / @pradeepmdk, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @pradeepmdk got assigned: 2023-08-23 00:32:34 Z
• when the PR got merged: 2023-08-23 00:34:20 UTC

On to the next one 🚀

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[situchan]

Not a blocker. Just linked the comment where I found the issue while reviewing PR.

[luacmartins]

Demoting it from NAB - https://expensify.slack.com/archives/C05P73VT267/p1692815976972019

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP] impose max length on merchant name in money requests #25738

If no regressions arise, payment will be issued on 2023-09-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @pradeepmdk requires payment offer (Contributor)
• @situchan requires payment offer (Contributor)
• @Natnael-Guchima requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[situchan]

PR was deployed to production on Aug 24

[isabelastisser]

Offers sent in Upwork!

@situchan, please complete the BZ checklist so we can close this issue. Thanks!

[isabelastisser]

Bump @situchan

[situchan]

No regression. Just missed this when implement merchant field.
As this is rare case, I don't think regression test is needed.

[joelbettner]

Any news here?

[isabelastisser]

Hey @situchan, can you please complete the rest of the checklist below? Thanks!

[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

[situchan]

• The PR that introduced the bug has been identified. Link to the PR: N/A
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A

[isabelastisser]

All payments were made in Upwork.

Payment summary:

• @situchan C+ review $1000, urgency bonus $500
• @pradeepmdk accepted proposal $1000, urgency bonus $500.
• @Natnael-Guchima $250 reported the issue.