Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: addOwnOrder iteration call #614

Merged
merged 1 commit into from
Oct 29, 2018
Merged

fix: addOwnOrder iteration call #614

merged 1 commit into from
Oct 29, 2018

Conversation

moshababo
Copy link
Collaborator

I saw this issue after checking #612. I'm not sure it's the entire problem, we'll need to have testing for this section soon.

@ghost ghost assigned moshababo Oct 29, 2018
@ghost ghost added the in progress label Oct 29, 2018
@moshababo moshababo mentioned this pull request Oct 29, 2018
Closed
@kilrau kilrau added this to the 1.0.0-alpha.2 milestone Oct 29, 2018
@moshababo
Copy link
Collaborator Author

moshababo commented Oct 29, 2018 •
edited by michael1011
Loading

Also fixes #613

sangaman
sangaman approved these changes Oct 29, 2018
View reviewed changes
Copy link
Collaborator

@sangaman sangaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, we only want to preserve the remaining order from the first iteration (if discardRemaining is false) and not any of the subsequent ones.

@sangaman sangaman mentioned this pull request Oct 29, 2018
Closed
@moshababo moshababo merged commit 1c8b09b into master Oct 29, 2018
@ghost ghost removed the in progress label Oct 29, 2018
@moshababo moshababo deleted the addownorder_fix branch October 29, 2018 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sangaman sangaman sangaman approved these changes

Assignees

@sangaman sangaman

@moshababo moshababo

Labels
None yet
Projects
None yet
Milestone
1.0.0-alpha.2
Development

Successfully merging this pull request may close these issues.
3 participants
@moshababo @sangaman @kilrau