Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Concept] Handling of trading fees (matching mode) #724

Closed
kilrau opened this issue Dec 4, 2018 · 2 comments
Closed

[Concept] Handling of trading fees (matching mode) #724

kilrau opened this issue Dec 4, 2018 · 2 comments
Assignees
@kilrau
Labels
P2 mid priority question/tbd Further information or discussion needed

Comments

@kilrau
Copy link
Contributor

kilrau commented Dec 4, 2018 •
edited
Loading

Based on our technical paper, this issue implements handling trading fees for exchanges running xud in matching mode:

  • taker_fee & maker_fee are defined in xud.conf in % (e.g. taker_fee = 0.25 means taker fee is 0.25%), reminder to store consistent with datatype as per gRPC SubscribeAddedOrders + SubscribeRemovedOrders float issue #740
  • xud calculates and subtracts taker_fee+maker_fee when matching & requesting a swap as taker. Maker fee needs to be calculated in base currency (using local last price) and converted into quote currency.
  • xud calculates and adds taker_fee+maker_fee before propagating an order to peers as maker. Taker fee needs to be calculated in quote currency (using local last price) and converted into base currency.
  • trading fees are recorded in separate trading fee account within xud once swap is successful
@kilrau kilrau added this to the 1.0.0-alpha.6 milestone Dec 4, 2018
@kilrau kilrau changed the title Handling of trading fees (matching mode) [Concept] Handling of trading fees (matching mode) Dec 6, 2018
@kilrau kilrau added the question/tbd Further information or discussion needed label Dec 6, 2018
@kilrau kilrau modified the milestones: 1.0.0-alpha.6, 1.0.0-alpha.8 Jan 2, 2019
@kilrau kilrau modified the milestones: 1.0.0-alpha.7, 1.0.0-alpha.8 Jan 23, 2019
@kilrau kilrau modified the milestones: 1.0.0-alpha.10, 1.0.0-alpha.12 Mar 6, 2019
@kilrau kilrau assigned ghost , sangaman and kilrau and unassigned sangaman, offerm, moshababo and kilrau Mar 26, 2019
@kilrau
Copy link
Contributor Author

kilrau commented Mar 26, 2019 •
edited
Loading

Reviving this. Feedback pls @erkarl @sangaman , I think we need a bit more details.

@kilrau kilrau modified the milestones: 1.0.0-sprint.12, 1.0.0-sprint.13 Apr 2, 2019
@kilrau kilrau modified the milestones: 1.0.0-sprint.13, 1.0.0-sprint.14 Apr 11, 2019
@kilrau kilrau removed this from the 1.0.0-sprint.14 milestone May 8, 2019
@kilrau kilrau modified the milestones: 1.0.0, post-1.0.0 May 8, 2019
@kilrau kilrau removed this from the post-1.0.0 milestone Jun 11, 2019
@kilrau kilrau added P1 top priority P2 mid priority and removed P1 top priority labels Oct 9, 2019
@kilrau kilrau unassigned ghost and sangaman Oct 31, 2019
@kilrau
Copy link
Contributor Author

kilrau commented Jan 15, 2020

Handled by arby & hedgy respectively. Closing.

@kilrau kilrau closed this as completed Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kilrau kilrau

Labels
P2 mid priority question/tbd Further information or discussion needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sangaman @offerm @moshababo @kilrau