Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate gRPC calls to make them CCXT-compatible #707

Open
kilrau opened this issue Nov 26, 2018 · 13 comments
Open

Translate gRPC calls to make them CCXT-compatible #707

kilrau opened this issue Nov 26, 2018 · 13 comments
Labels
101-250 XUC grpc gRPC API P2 mid priority

Comments

@kilrau
Copy link
Contributor

kilrau commented Nov 26, 2018

We aim to make xud's main calls ccxt compatible, so that professional traders can easily connect their existing GUI + algorithms. As per #471 (comment) we will not start a GUI project on our own.

Here is the full list of all unified ccxt API methods (subset of methods common among the exchanges) which we should support. I suggest to do this with a ccxt wrapper, not touching existing calls. The CLI is not affected and can stay as is. Goes without saying - we'll keep all other calls as is

@kilrau kilrau added the grpc gRPC API label Nov 26, 2018
@kilrau kilrau added this to the 1.0.0-alpha.7 milestone Nov 26, 2018
@ImmanuelSegol
Copy link
Contributor

@kilrau Is anyone planning to work on this? if not I will take it.

@kilrau
Copy link
Contributor Author

kilrau commented Jan 2, 2019

Please, but let's discuss on the way how to do this - if via ccxt wrapper around our current gRPC or change the gRPC

@ImmanuelSegol
Copy link
Contributor

@kilrau @sangaman We should discus this on the weekly meeting.

@kilrau
Copy link
Contributor Author

kilrau commented Jan 14, 2019

@kilrau @sangaman We should discus this on the weekly meeting.

Sure! Weekly call on Wednesday 16:00 UTC+1

@kilrau
Copy link
Contributor Author

kilrau commented Jan 23, 2019

Any questions left? @ImmanuelSegol

@kilrau kilrau modified the milestones: 1.0.0-alpha.7, 1.0.0-alpha.8 Jan 23, 2019
@kilrau kilrau modified the milestones: 1.0.0-alpha.10, 1.0.0-alpha.11 Mar 6, 2019
@kilrau kilrau modified the milestones: 1.0.0-alpha.11, 1.0.0-sprint.12 Mar 25, 2019
@kilrau kilrau modified the milestones: 1.0.0-sprint.12, 1.0.0-sprint.16 Apr 11, 2019
@kilrau
Copy link
Contributor Author

kilrau commented Apr 16, 2019

@sangaman
Copy link
Collaborator

I'm not familiar with CCXT and I don't think it's been brought up on one of the calls, but we can discuss next time. I'd expect that it'd be better to have a wrapper around our existing API.

@ghost ghost added the question/tbd Further information or discussion needed label Apr 19, 2019
@kilrau
Copy link
Contributor Author

kilrau commented Apr 19, 2019

I'd expect that it'd be better to have a wrapper around our existing API.

That's what I thought too!

Please bring this up on our next call on Wednesday and definitely don't accept that we skip you again! ;)

@kilrau kilrau removed this from the 1.0.0-sprint.16 milestone May 8, 2019
@kilrau kilrau added this to the 1.0.0 milestone May 8, 2019
@kilrau
Copy link
Contributor Author

kilrau commented May 8, 2019

CLI is enough for 1.0.0. Moving to post-1.0.0.

@kilrau kilrau modified the milestones: 1.0.0, post-1.0.0 May 8, 2019
@kilrau kilrau removed this from the post-1.0.0 milestone Jun 11, 2019
@kilrau kilrau assigned rsercano and unassigned ImmanuelSegol Jul 23, 2019
@kilrau kilrau added the P2 mid priority label Oct 9, 2019
@xVETTEx
Copy link

xVETTEx commented Feb 12, 2020

Is this open to work? I would like to take this if this is avaible to work. And if I can work on this, can you give estimation salary?

@kilrau kilrau added 101-250 XUC and removed question/tbd Further information or discussion needed labels Feb 12, 2020
@kilrau
Copy link
Contributor Author

kilrau commented Feb 12, 2020

It is! Added estimation. I suggest to keep us in the loop on how exactly you plan to implement this to make sure you are heading into the right direction!

@xVETTEx
Copy link

xVETTEx commented Mar 3, 2020

@kilrau I think we need provide http api on xud if we want to use api trough ccxt. So I'll create grpc services for every ccxt api endpoint?

@kilrau
Copy link
Contributor Author

kilrau commented Mar 4, 2020

I think we need provide http api on xud if we want to use api trough ccxt.

gRPC is HTTP(/2)

So I'll create grpc services for every ccxt api endpoint?

gRPC wrapper services, internally pointing to the existing gRPC calls. That's at least how I imagined it. Thoughts? @sangaman @erkarl

I would like to take care of ExchangeUnion/market-maker-bot#1 first though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
101-250 XUC grpc gRPC API P2 mid priority
Projects
None yet
Development

No branches or pull requests

5 participants