-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate gRPC calls to make them CCXT-compatible #707
Comments
@kilrau Is anyone planning to work on this? if not I will take it. |
Please, but let's discuss on the way how to do this - if via ccxt wrapper around our current gRPC or change the gRPC |
Sure! Weekly call on Wednesday 16:00 UTC+1 |
Any questions left? @ImmanuelSegol |
I'm not familiar with CCXT and I don't think it's been brought up on one of the calls, but we can discuss next time. I'd expect that it'd be better to have a wrapper around our existing API. |
That's what I thought too! Please bring this up on our next call on Wednesday and definitely don't accept that we skip you again! ;) |
CLI is enough for |
Is this open to work? I would like to take this if this is avaible to work. And if I can work on this, can you give estimation salary? |
It is! Added estimation. I suggest to keep us in the loop on how exactly you plan to implement this to make sure you are heading into the right direction! |
@kilrau I think we need provide http api on xud if we want to use api trough ccxt. So I'll create grpc services for every ccxt api endpoint? |
gRPC is HTTP(/2)
gRPC wrapper services, internally pointing to the existing gRPC calls. That's at least how I imagined it. Thoughts? @sangaman @erkarl I would like to take care of ExchangeUnion/market-maker-bot#1 first though. |
We aim to make
xud
's main calls ccxt compatible, so that professional traders can easily connect their existing GUI + algorithms. As per #471 (comment) we will not start a GUI project on our own.Here is the full list of all unified ccxt API methods (subset of methods common among the exchanges) which we should support. I suggest to do this with a ccxt wrapper, not touching existing calls. The CLI is not affected and can stay as is. Goes without saying - we'll keep all other calls as is
The text was updated successfully, but these errors were encountered: