Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect sort order in sortOrders function #1886

Open
raladev opened this issue Sep 10, 2020 · 1 comment
Open

Incorrect sort order in sortOrders function #1886

raladev opened this issue Sep 10, 2020 · 1 comment
Labels
bug Something isn't working P3 low priority

Comments

@raladev
Copy link
Contributor

raladev commented Sep 10, 2020

export const sortOrders = <T extends SortableOrder>(orders: T[], isBuy: boolean): T[] => {

based on #1883 (review)

@raladev raladev added bug Something isn't working P3 low priority labels Sep 10, 2020
@kilrau
Copy link
Contributor

kilrau commented Sep 10, 2020

Since this is a breaking, non-trivial change that only appears on the gRPC and #1883 fixed the only place in the xucli where this surfaces, I'm inclined to not touch this any time soon :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P3 low priority
Projects
None yet
Development

No branches or pull requests

3 participants