Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make output of discover command more informative #1527

Closed
raladev opened this issue May 6, 2020 · 1 comment
Closed

feat: make output of discover command more informative #1527

raladev opened this issue May 6, 2020 · 1 comment
Labels
enhancement New feature or request P3 low priority question/tbd Further information or discussion needed

Comments

@raladev
Copy link
Contributor

raladev commented May 6, 2020

Reason

After discovering I have no information about count of peers that were autoconnected to me.

Task 1

If discover is always equivalent of discover+autoconnect, it would be good to return number of autoconnected nodes too because it can be different because of tor using or network settings.

{
discovered:3
connected:2
}

Task 2

Add plain text output for discover command in cli.

Draft:
3 nodes discovered and connection is established with 2 of them - if connected field is not empty
3 nodes discovered - if connected field is empty
There is no discovered nodes - if discovered is 0

@raladev raladev added enhancement New feature or request question/tbd Further information or discussion needed P3 low priority labels May 6, 2020
@kilrau kilrau removed their assignment May 6, 2020
@kilrau
Copy link
Contributor

kilrau commented Oct 19, 2020

I don't consider discover really relevant on the CLI for now.

@kilrau kilrau closed this as completed Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P3 low priority question/tbd Further information or discussion needed
Projects
None yet
Development

No branches or pull requests

2 participants