Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation Tests: Master Password #1016

Open
kilrau opened this issue Jun 10, 2019 · 4 comments
Open

Simulation Tests: Master Password #1016

kilrau opened this issue Jun 10, 2019 · 4 comments
Assignees
Labels

Comments

@kilrau
Copy link
Contributor

kilrau commented Jun 10, 2019

Continuation of #912:

Simulations tests to use encryption

@kilrau kilrau added this to the 1.0.0-beta milestone Jun 10, 2019
@kilrau kilrau changed the title Integrate 'XUD Master Password' in simulation tests [XUD Master Password] integration in simulation tests Jun 10, 2019
@kilrau kilrau added the P2 mid priority label Jun 10, 2019
@kilrau kilrau changed the title [XUD Master Password] integration in simulation tests [XUD Master Password] Integration in simulation tests Jun 10, 2019
@kilrau kilrau removed this from the 1.0.0-beta milestone Jun 11, 2019
@kilrau kilrau assigned sangaman and moshababo and unassigned moshababo and sangaman Oct 9, 2019
@kilrau
Copy link
Contributor Author

kilrau commented Nov 12, 2019

@sangaman could you explain this again?

@kilrau kilrau assigned LePremierHomme and unassigned moshababo Nov 18, 2019
@LePremierHomme
Copy link
Contributor

@sangaman can you please describe what's the desired outcome here?

@kilrau
Copy link
Contributor Author

kilrau commented Dec 12, 2019

Please jump in @sangaman , but I'd say something along the lines:

  • create node, set random password, cache seed
  • lock, unlock with password
  • restore node with seed

@sangaman
Copy link
Collaborator

Yes I think that's about right. We want to turn off noencrypt and then use the RPC calls to create a wallet, it would be good to also unlock the wallet if possible.

Restoring a node would be trickier, maybe could be in a separate PR, but for that I think we would want to create a node, send funds to at least one LND instance (and ideally one ERC20 token as well), then delete the node and the lnd data dirs/eth keystore. Then we'd want to use the RestoreNode rpc call, pass in the mnemonic we got when creating the wallet, and ensure that our node key matches what it did originally and also that the funds are still in our wallets.

@kilrau kilrau changed the title [XUD Master Password] Integration in simulation tests simulation tests: master password Mar 31, 2020
@kilrau kilrau changed the title simulation tests: master password Simulation Tests: Master Password Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants