Skip to content

Commit ae0742d

Browse files
committed
fix: resolve CI issues with missing generated files and non-null assertions
- Add schema generation step before typecheck in CI workflow - Fix non-null assertions in api-server.test.ts by using optional checks - Ensure generated files are available before TypeScript compilation
1 parent b6e420d commit ae0742d

File tree

2 files changed

+27
-9
lines changed

2 files changed

+27
-9
lines changed

.github/workflows/main.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,10 @@ jobs:
100100
git push
101101
fi
102102
103+
# Generate required files before quality checks
104+
- name: Generate schemas (required for TypeScript compilation)
105+
run: npm run generate:schemas
106+
103107
# Quality checks (must pass for all further steps)
104108
- name: Run lint (fast fail)
105109
run: npm run lint

src/api-server.test.ts

Lines changed: 23 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,11 @@ describe('API Server', () => {
6262
server = createApiServer(port);
6363

6464
await new Promise<void>((resolve) => {
65-
server!.on('listening', () => {
66-
resolve();
67-
});
65+
if (server) {
66+
server.on('listening', () => {
67+
resolve();
68+
});
69+
}
6870
});
6971

7072
expect(server.listening).toBe(true);
@@ -95,7 +97,9 @@ describe('API Server', () => {
9597
beforeEach(async () => {
9698
server = createApiServer(port);
9799
await new Promise<void>((resolve) => {
98-
server!.on('listening', () => resolve());
100+
if (server) {
101+
server.on('listening', () => resolve());
102+
}
99103
});
100104
});
101105

@@ -140,7 +144,9 @@ describe('API Server', () => {
140144
beforeEach(async () => {
141145
server = createApiServer(port);
142146
await new Promise<void>((resolve) => {
143-
server!.on('listening', () => resolve());
147+
if (server) {
148+
server.on('listening', () => resolve());
149+
}
144150
});
145151
});
146152

@@ -194,7 +200,9 @@ describe('API Server', () => {
194200
beforeEach(async () => {
195201
server = createApiServer(port);
196202
await new Promise<void>((resolve) => {
197-
server!.on('listening', () => resolve());
203+
if (server) {
204+
server.on('listening', () => resolve());
205+
}
198206
});
199207
});
200208

@@ -241,7 +249,9 @@ describe('API Server', () => {
241249
beforeEach(async () => {
242250
server = createApiServer(port);
243251
await new Promise<void>((resolve) => {
244-
server!.on('listening', () => resolve());
252+
if (server) {
253+
server.on('listening', () => resolve());
254+
}
245255
});
246256
});
247257

@@ -321,7 +331,9 @@ describe('API Server', () => {
321331
beforeEach(async () => {
322332
server = createApiServer(port);
323333
await new Promise<void>((resolve) => {
324-
server!.on('listening', () => resolve());
334+
if (server) {
335+
server.on('listening', () => resolve());
336+
}
325337
});
326338
});
327339

@@ -404,7 +416,9 @@ describe('API Server', () => {
404416
beforeEach(async () => {
405417
server = createApiServer(port);
406418
await new Promise<void>((resolve) => {
407-
server!.on('listening', () => resolve());
419+
if (server) {
420+
server.on('listening', () => resolve());
421+
}
408422
});
409423
});
410424

0 commit comments

Comments
 (0)