-
Couldn't load subscription status.
- Fork 4.6k
fix mysql wavoip token #1433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix mysql wavoip token #1433
Conversation
Reviewer's GuideThis pull request introduces a database migration that adds a File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @paulocoutinhox - I've reviewed your changes - here's some feedback:
- The PR title and migration file name only mention the
wavoipTokenaddition; consider updating them to reflect that a unique constraint is also added to theChattable. - Consider if the
wavoipTokenaddition and theChattable unique constraint should be in separate migrations as they appear to address distinct concerns.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| ); | ||
|
|
||
| SET @sql := IF(@column_exists = 0, | ||
| 'ALTER TABLE Setting ADD COLUMN wavoipToken VARCHAR(100);', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
Summary by Sourcery
Add a wavoip token column to the Settings table and create a unique constraint on Chat table
New Features:
Enhancements: