Everest leaks file descriptors on Linux

[ddevault]

My mods and Everest install are up to date

Yes

I have recreated the bug with only Everest OR a minimum number of mods enabled

No

Describe the bug

Everest hits ENFILE on Linux because it has too many open file descriptors. Should double check that files are closed when no longer in use.

Steps to reproduce

1. Install a lot of mods.
2. Poof

Expected behavior

Should close files when done with them to avoid hitting the open file limit.

Operating System

Linux

Everest Version

1.4.0.0

Mods required to reproduce

Any mods: just install enough of them to exhaust the fds.

Additional context

No response

[WEGFan]

Did you unzipped the mods? Everest will automatically watch the files in unzipped mods for the hot reload feature, I don't know if it's the issue. But if you aren't making mods you shouldn't unzip them.

[ddevault]

I did not unzip them, no.

[microlith57]

how many mods is enough for you, and what is your ulimit -n? on my system i have it set to > 1 million, so i don't think it's possible for me to reproduce this.

[ddevault]

I have 79 mods installed and the default ulimit of 1024. You can set a lower ulimit for testing with ulimit -n <whatever>.

[0x0ade]

Does setting the environment variable MONO_MANAGED_WATCHER to disabled help in any way? I've heard that macOS has got a "low" ulimit as well (at least compared to other environments Everest is being used in), which makes me wish I had the time
to move away from the C# standard FileSystemWatcher implementation. Maybe someone else would be willing to look into that too.

[ddevault]

Yep, setting that variable seems to prevent the crash.

[LeSeulArtichaut]

I ran into this bug while trying to play the Strawberry Jam Collab. Setting MONO_MANAGED_WATCHER=disabled didn't seem to help, however setting a high ulimit -n did prevent the crash.

[Kalobi]

The current recommended solution is to disable FastTextureLoading in modsettings-Everest.celeste until we figure out how to limit the open files for FTL.