fix close function to abort XHR - #52
Merged
Merged
Conversation
Author
|
I did attempt to write tests for this, but I couldn't find any existing tests of the close function, except for an assertion of the readyState after close() is called. There's no external reference to "req" or "xhr", so writing a test would likely involve mocking the entire http/https dependency, which seems a bit excessive for one line of code. |
Contributor
|
Thanks! Yeah, it's harder to write tests for the polyfill - would be nice to have some automated tests running in an actual browser. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed while using the polyfill, calling the close() function was not actually closing the http connection, but making this small change to call the abort() function of the actual xhr reference fixed the problem.