Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows support #10

Open
EugeneLoy opened this issue Dec 26, 2018 · 4 comments
Open

Add windows support #10

EugeneLoy opened this issue Dec 26, 2018 · 4 comments

Comments

@EugeneLoy
Copy link
Owner

No description provided.

@SotaroOKUDA
Copy link

Hello, thanks for your effort.
I usually use this on ubuntu 18.04 it works well.
Today I tried to this on Windows but doesnt worked.
Jupyter Notebook doesnt connect to kernel and output errors;

[IPKernelApp] ERROR | CoqtopError has occured. Scheduling shutdown.
Traceback (most recent call last):
File "C:\Python\Python37\lib\site-packages\coq_jupyter\coqtop.py", line 78, in init
self._coqtop = pexpect.spawn("coqidetop -main-channel stdfds {}".format(coqtop_args), **spawn_args)
AttributeError: module 'pexpect' has no attribute 'spawn'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "C:\Python\Python37\lib\site-packages\coq_jupyter\kernel.py", line 59, in wrapper
return function(self, *args, **kwargs)
File "C:\Python\Python37\lib\site-packages\coq_jupyter\kernel.py", line 99, in init
self.coqtop = Coqtop(self, self.coqtop_args)
File "C:\Python\Python37\lib\site-packages\coq_jupyter\coqtop.py", line 87, in init
raise_with_traceback(CoqtopError("Cause: {}".format(repr(e))))
File "C:\Python\Python37\lib\site-packages\future\utils_init
.py", line 446, in raise_with_traceback
raise exc.with_traceback(traceback)
File "C:\Python\Python37\lib\site-packages\coq_jupyter\coqtop.py", line 78, in init
self._coqtop = pexpect.spawn("coqidetop -main-channel stdfds {}".format(coqtop_args), **spawn_args)
coq_jupyter.coqtop.CoqtopError: Cause: AttributeError("module 'pexpect' has no attribute 'spawn'")

Python 3.8 / 3.7
jupyter core : 4.6.1
jupyter-notebook : 6.0.3
qtconsole : 4.6.0
ipython : 7.12.0
ipykernel : 5.1.4
jupyter client : 5.3.4
jupyter lab : not installed
nbconvert : 5.6.1
ipywidgets : 7.5.1
nbformat : 5.0.4
traitlets : 4.3.3

@EugeneLoy
Copy link
Owner Author

@SotaroOKUDA Hi.

At the moment support for windows is not implemented and, TBH, I am not sure whether it is worth the effort.

If I'll see interest in it I'll look into implementing it, however. Let me know if you need this by "thumbs-up"-ing this ticket.

If someone is willing to do PR for this, the main issue here is that pexpect.spawn is not supported on windows, thus, some alternative should be used. All relevant code is located in coqtop.Coqtop class (see usage of _coqtop property of that class).

@SotaroOKUDA
Copy link

Hi, thanks for your replying!
I found wexpect instead pexpect, does this work?
Maybe I'll try it for my study.
Thank you!

@EugeneLoy
Copy link
Owner Author

@SotaroOKUDA it looks like all required methods are present. Might actually work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants