Update Adventure #6163
Update Adventure #6163
Conversation
|
can you bump adventure platform to 4.4.0 as well? otherwise good |
|
Yes sir captin sir 🫡 |
|
how does it even fail- |
|
Apparently it failed to find Adventure Platform related classes.. (btw it is on Maven Central, so it not being found is actually insanity) the fix is not really on my mind |
|
Probs some maven cache or something silly |
Real intention behind this is to rerun the build. lol
Head branch was pushed to by a user without write access
|
The error is about a class that isn't even used in the code, im not sure why it's happening but apparently it's loading and compiling just fine, the tests on the other hand aren't doing so fine themselves |
|
Upon further investigation, this line: which uses Bukkit#getUnsafe#getDataVersion is the reason behind it all, the tests simply cant provide it A solution would be to use proper testing for Bukkit like MockBukkit or.. Just temporarily disable these tests |
|
I'll look in a few |
EssentialsX@40540eb Expose IUser#getLastActivityTime to API (EssentialsX#6101) EssentialsX@50b696b Adds social spy message type for in EssentialsDiscord (EssentialsX#5620) EssentialsX@dabe687 Add SignTransactionEvent for buy and sell signs (EssentialsX#6071) EssentialsX@0cb387f Fix NPE when unlinking offline players (EssentialsX#6111) EssentialsX@f09541c Update to Minecraft 1.21.5 (EssentialsX#6109) EssentialsX@c7ff994 Fire GlobalChatEvent even when local chat is disabled (EssentialsX#6113) EssentialsX@06c886c Fix /baltop on 1.15.2 and below (EssentialsX#6115) EssentialsX@2bb4438 Fix further trade sign validation mismatches (EssentialsX#6116) EssentialsX@8455212 Fix /spawnmob on < 1.21.5 (EssentialsX#6121) EssentialsX@be3e641 New Crowdin updates (EssentialsX#6089) EssentialsX@3f5b122 Use legacy text for TranslatableException#getMessage (EssentialsX#6134) EssentialsX@fe43017 Fix heer typo in messages_en.properties (EssentialsX#6135) EssentialsX@a58db23 Update English source strings with fixes from Crowdin (EssentialsX#6140) EssentialsX@d137031 Improve config comments & ordering (EssentialsX#6108) EssentialsX@3b0c229 New Crowdin updates (EssentialsX#6131) EssentialsX@3fe1495 Fix unexpected behavior with essentials.home.bed & essentials.sethome.bed permissions (EssentialsX#5991) EssentialsX@aebe851 Fix double messages when deleting a non-existent home (EssentialsX#6150) EssentialsX@3a5c7c4 Revert changes to /home and /sethome that break bed interactions (EssentialsX#6151) EssentialsX@3d28d82 Release 2.21.1 EssentialsX@e836747 Prepare for 2.21.2 dev builds (EssentialsX#6128) EssentialsX@d42347f Fix sending message during /editsign paste if SignChangeEvent is cancelled (EssentialsX#6136) EssentialsX@997f600 Update adventure dependencies (EssentialsX#6163) EssentialsX@4057326 Update to Minecraft 1.21.6 EssentialsX@2796399 Add 1.21.6 Mobs EssentialsX@31ea903 Move tests to MockBukkit EssentialsX@ff1b8b8 Add 1.21.6 Aliases
3 participants
Information
This PR fixes an issue where clickable messages don't work on newer versions (1.21.5).
Details
Proposed fix:
Update Adventure
Environments tested:
OS: Windows, Linux
Java version: 21
Demonstration:
It's really not worth a demonstration lol