Skip to content

Add ability to register custom item transformers.#4871

Merged
JRoy merged 2 commits intoEssentialsX:2.xfrom
Golfing7:2.x
Nov 29, 2025
Merged

Add ability to register custom item transformers.#4871
JRoy merged 2 commits intoEssentialsX:2.xfrom
Golfing7:2.x

Conversation

@Golfing7
Copy link
Contributor

@Golfing7 Golfing7 commented Mar 24, 2022 •
edited by JRoy
Loading

.

@mdcfe
Copy link
Member

mdcfe commented Mar 24, 2022

Thanks for your interest in contributing to EssentialsX!

As it stands, MetaItemStack has been long in need of a major overhaul which I've been working on in a private branch. Part of this rework would overlap with the functionality added in this PR, so I will need some time to consider whether it would make sense to merge this PR at this stage.

@pop4959 pop4959 added type: enhancement Features and feature requests. module: main Issues or PRs for the main Essentials module labels May 21, 2022
@Golfing7
Copy link
Contributor Author

Golfing7 commented Dec 31, 2023

It's been a while, just would like to see if this could still be merged as the rework to MetaItemStack appears to have not come yet. Thanks!

@Golfing7
Copy link
Contributor Author

Golfing7 commented Nov 5, 2025

Heyo! I recently found a need for this again and wanted to know if this could get merged in quickly. Thanks!

JRoy
JRoy requested changes Nov 16, 2025
View reviewed changes
Copy link
Member

@JRoy JRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit + fix the formatting issues + fix the merge conflicts

@Golfing7
Copy link
Contributor Author

Golfing7 commented Nov 17, 2025

I've addressed the changes. Should I modify anything else?

JRoy
JRoy requested changes Nov 17, 2025
View reviewed changes
Copy link
Member

@JRoy JRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some final codestyle nits

@Golfing7
Copy link
Contributor Author

Golfing7 commented Nov 17, 2025

Addressed!

@Golfing7
Copy link
Contributor Author

Golfing7 commented Nov 18, 2025

I flattened the commits and updated my usage of the logger.

@mdcfe mdcfe self-requested a review November 18, 2025 18:47
@JRoy JRoy enabled auto-merge November 29, 2025 17:02
@JRoy JRoy added this pull request to the merge queue Nov 29, 2025
Merged via the queue into EssentialsX:2.x with commit 0fa6f70 Nov 29, 2025
1 check passed
Euphillya added a commit to Euphillya/Essentials-Folia that referenced this pull request Dec 2, 2025
@Euphillya
Update Upstream Essentials:
bf333e1 
EssentialsX@87dfe37 Update to adventure 4.25.0 (EssentialsX#6331)
EssentialsX@af44749 Add WarmUpCancelled Event & Expose TPType (EssentialsX#6351)
EssentialsX@0fa6f70 Add ability to register custom item transformers. (EssentialsX#4871)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdcfe mdcfe mdcfe approved these changes

@JRoy JRoy JRoy approved these changes

Assignees

No one assigned

Labels

module: main Issues or PRs for the main Essentials module type: enhancement Features and feature requests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Golfing7 @mdcfe @JRoy @pop4959