Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Action] Look into options for having a numbered indicator #10287

Open
2 of 6 tasks
DitwanP opened this issue Sep 12, 2024 · 1 comment
Open
2 of 6 tasks

[Action] Look into options for having a numbered indicator #10287

DitwanP opened this issue Sep 12, 2024 · 1 comment
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - design - sm Small design effort; 1-4 days of design work impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment.

Comments

@DitwanP
Copy link
Contributor

DitwanP commented Sep 12, 2024

Check existing issues

Description

We have received requests for having a way to display a count where the indicator currently is.

Acceptance Criteria

  • Provide a way to display a indicator/badge with a count.

Relevant Info

Valuable Info from Adam:

Chip has sort of served as the “badge” use case (some DS make a distinction, some don’t) and while Action is a common place for that kind of display it could be valid elsewhere too.
We could look at a way to handle this just in Action for the time being as it’s the most commonly asked context. Badge-count or something, would need to handle intl numeric characters, more than two characters, etc.
Technically right now users can slot things inside actions and fudge around with padding etc but we don’t doc that

More info in response to if this functionality should be a standalone option or an augmentation to current indicator:

I think there's value in the themeable dot still - we've also had requests for "adornments" like a checkmark icon, security badge icon, etc., sometimes in the context of Avatar but also in the case of Action. Scoped to a numeric value, I'd think we'd only want one visual to be possible - like if you provide indicator-count it overrides the indicator dot, etc. (now, badges usually top-right where indicators bottom-right, but that's kind of implementation q)

Which Component

calcite-action

Example Use Case

Notification count, inbox count, etc...

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)

@DitwanP DitwanP added enhancement Issues tied to a new feature or request. design Issues that need design consultation prior to development. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. labels Sep 12, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Sep 12, 2024
@driskull
Copy link
Member

We should discuss if we can handle numbers, icons, and just the generic dot with a single badge property or slot which could possibly deprecate indicator.

@ashetland ashetland added p - low Issue is non core or affecting less that 10% of people using the library estimate - design - sm Small design effort; 1-4 days of design work and removed needs triage Planning workflow - pending design/dev review. labels Nov 14, 2024
@ashetland ashetland added this to the Design Backlog milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - design - sm Small design effort; 1-4 days of design work impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment.
Projects
None yet
Development

No branches or pull requests

3 participants