Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discoverHost requires Kryo serialization, but shouldn't #127

Closed
erjo1776 opened this issue Feb 11, 2017 · 0 comments
Closed

discoverHost requires Kryo serialization, but shouldn't #127

erjo1776 opened this issue Feb 11, 2017 · 0 comments

Comments

@erjo1776
Copy link

Both discoverHost() and discoverHosts() in Client end up calling getKryo() which crashes when your serializer is not based on Kryo.

Probably an easy fix if you change getKryo() to return null for non-Kryo cases. Also, note that onDiscoveredHost() must support a null kryo parameter.

If what I say above is acceptable, then the fix can be made in a minute or two.

I am using JSON serialization because iOS currently chokes on Kyro when using MOE (Multi-OS Engine).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant