From 6f47acf688706e6fbb0a4291daa2721bdeb059b3 Mon Sep 17 00:00:00 2001 From: Joey Parrish Date: Wed, 26 Oct 2016 13:26:02 -0700 Subject: [PATCH] Fix spurious error message in build/checkversion.py There is a meaningless and unhelpful error message appearing at publish time with some npm versions. Suppress it by including stderr into the captured stdout. Change-Id: I73693433e5df5cc8d63375c08f765fbbb801f10f --- build/shakaBuildHelpers.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/shakaBuildHelpers.py b/build/shakaBuildHelpers.py index ea898f8f4c..1e80cec3df 100644 --- a/build/shakaBuildHelpers.py +++ b/build/shakaBuildHelpers.py @@ -121,7 +121,7 @@ def npm_version(is_dirty=False): cmd = 'npm.cmd' if is_windows() else 'npm' cmd_line = [cmd, '--prefix', base, 'ls', 'shaka-player'] print_cmd_line(cmd_line) - text = subprocess.check_output(cmd_line) + text = subprocess.check_output(cmd_line, stderr=subprocess.STDOUT) except subprocess.CalledProcessError as e: text = e.output match = re.search(r'shaka-player@(.*) ', text)