Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review status change dropdowns are not "buttons" #3197

Open
whisperity opened this issue Feb 19, 2021 · 0 comments
Open

Review status change dropdowns are not "buttons" #3197

whisperity opened this issue Feb 19, 2021 · 0 comments
Labels
bug 🐛 enhancement 🌟 GUI 🎨 usability 👍 Usability-related features web 🌍 Related to the web app

Comments

@whisperity
Copy link
Contributor

I'm not sure if this is more of a bug or just an enchantment request as this is pretty much a nieche issue.

Describe the bug
The review status change options in the dropdown are not "buttons" but some special element that respond to the "click" event. This makes Vimium (a browser addon that allows you to use Vim-like keybinds to navigate the pages) not pick them up.

In Vimium, you can press f which will annotate all of the "clickable" elements of the webpage with keybind shortcuts. These shortcuts are random generated at each run but allows you to visually see what further keys (usually 1 or 2 keys after having pressed f) you have to press to "click" the element.

For example, looking at a CodeChecker after pressing f (note that some other elements such as the check name or the table headings are also not getting their "clickykey"!):

Uploading Screenshot_20210219_110925.png…

Now if I press fk I emulate the "click" on the first bug, and am presented with the usual bug path view, which gets the following keys assigned after pressing f:

Screenshot_20210219_110938

Now if I press m, it "clicks" the dropdown and the dropdown opens, however, a subsequent press of f does not annotate the dropdown elements:

Screenshot_20210219_110948

So to actually change the review status, I have to go to my mouse.

CodeChecker version

(venv) 127 whisperity@cc:~/CodeChecker-Build/source$ build/CodeChecker/bin/CodeChecker web-version
------------------------------------------------------------------------
Kind                          | Version
------------------------------------------------------------------------
Base package version          | 6.16.0
Package build date            | 2021-02-18T15:51
Git commit ID (hash)          | f3998ed4b4065e6d0d2342ebc1d33e2090a20df7
Git tag information           | 6.16
Server supported API (Thrift) | 6.39
Client API (Thrift)           | 6.39
------------------------------------------------------------------------

Expected behaviour
The elements of the dropdown are picked up as buttons and thus can be used with the keybind for clicking.

Desktop (please complete the following information)

  • OS: Ubuntu 18.04.5 LTS
  • Browser: Firefox
  • Version: 85.0.1

Additional context
On a website like GitHub, pressing f on the code page:

Screenshot_20210219_111141

and afterwards opening the branch list and pressing f again, the individual elements are assigned a letter (somehow GitHub managed to make sure the other elements (apart from the branch list) are not picked up as links/clickies, so they don't get a letter):

Screenshot_20210219_111211

The generation of the shortcut keys are somehow tied to the things being links, so as a hunch, I believe the issues lies in that the dropdowns are some sort of "custom" element that handle click()s, but are not technically "links" themselves. Several other otherwise clickable elements have the same issue, such as here the options(?) for the filter cannot be set — but the buttons that apply/cancel the changing of the option are properly clicky.

Screenshot_20210219_111555

@whisperity whisperity added bug 🐛 enhancement 🌟 GUI 🎨 usability 👍 Usability-related features web 🌍 Related to the web app labels Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 enhancement 🌟 GUI 🎨 usability 👍 Usability-related features web 🌍 Related to the web app
Projects
None yet
Development

No branches or pull requests

1 participant