Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeChecker finds all old issues again when renaming a file #3158

Open
jimis opened this issue Jan 21, 2021 · 1 comment
Open

CodeChecker finds all old issues again when renaming a file #3158

jimis opened this issue Jan 21, 2021 · 1 comment
Labels
analyzer 📈 Related to the analyze commands (analysis driver) usability 👍 Usability-related features

Comments

@jimis
Copy link
Contributor

jimis commented Jan 21, 2021

  • File had a bunch of unreviewed issues but they were being ignored
  • File gets renamed in a git commit
  • New run of CodeChecker analyze presents all the old issues as new. The report hash appears to be different, the issues are shown on the UI like they have no history.
@csordasmarton csordasmarton added analyzer 📈 Related to the analyze commands (analysis driver) usability 👍 Usability-related features labels Feb 18, 2021
@csordasmarton
Copy link
Contributor

@jimis The problem at here is that the report hash contains the file name which is described at here: https://github.com/Ericsson/codechecker/blob/master/docs/analyzer/report_identification.md. I don't know what would be the best choice to solve this problem. Maybe we can create a new context free hash method (context-free-v3) where we skip the file name from the report hash so the hash will contain only the following information:

  • checker name (e.g.: bugprone-infinite-loop, core.DivideZero etc.).
  • content of the line where the bug is if it can be read up. All the whitespaces from the source content are removed.
  • range column numbers where the bug is.

Is it sounds good to you or do you have any other recommended solution to this problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer 📈 Related to the analyze commands (analysis driver) usability 👍 Usability-related features
Projects
None yet
Development

No branches or pull requests

2 participants