Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't collect failure ZIP if "debug" checkers were enabled #1311

Open
whisperity opened this issue Jan 23, 2018 · 0 comments
Open

Don't collect failure ZIP if "debug" checkers were enabled #1311

whisperity opened this issue Jan 23, 2018 · 0 comments
Labels
analyzer 📈 Related to the analyze commands (analysis driver) enhancement 🌟

Comments

@whisperity
Copy link
Contributor

As it was discussed in #1203 (and related issues), the failure ZIP creating routine is not armed to handle generation of ZIPs when any debug. checker is enabled. These checkers are only enabled on the most explicit user consent of all times, typing in at least -e debug.

Because at analysis we know which checkers are enabled (either via the direct invocation command or the metadata.json output), we could skip the generation of the failure ZIP in case such a checker was enabled, in which almost all cases, it could have tainted the analyzer's output.

Alternatively, looking at the Namespace value for enabled checkers, if it contains any "debug" thing, the flag which prevents failure ZIP creation (I vaguely recall the existence of such) could be turned on.

@whisperity whisperity added enhancement 🌟 analyzer 📈 Related to the analyze commands (analysis driver) labels Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer 📈 Related to the analyze commands (analysis driver) enhancement 🌟
Projects
None yet
Development

No branches or pull requests

1 participant