Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix showing diagnostics in the Problems pane #70

Merged

Conversation

csordasmarton
Copy link
Contributor

Closes #49

  • Show reports as separate diagnostic items and show bug steps as diagnostic
    related information.
  • Show different severities based on the CodeChecker severity level.
  • Refactoring the code.

Screenshot:
image

@csordasmarton csordasmarton added this to the 1.1.1 milestone Feb 2, 2022
Copy link
Collaborator

@Discookie Discookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a couple things broken by this change:

  • The reproduction steps are now invisible in the editor, other than the CodeLens header. Makes it much harder to see eg. when there's multiple statements on the same line, or when only a certain parameter is of interest. (CodeChecker web highlights the steps in yellow.)
  • Reproduction steps are always shown in the Problems tab, so when the user clicks on a non-active repr. step, and the step is in a different file, the entire bug disappears.
  • There's now a considerable amount of duplicate information between the Reports tab and the Problems list, but with the Problems list having worse functionality.
  • Since keyboard navigation is based on the repr. steps' ranges, it becomes very unintuitive as well since the user won't be able to find the range where the navigation works.
  • Small nitpick is that the report's description always contains a link to itself as the last step.

My recommendation would be to have the steps displayed only under the active report, but still have the individual steps be displayed as Information ranges.

Another thing is using the other diagnostic severities for different kinds of reports, so that Low severity can become a warning instead of an error, and so on.

@csordasmarton csordasmarton modified the milestones: 1.2.0, 1.3.0 Feb 14, 2022
- Show reports as separate diagnostic items and show bug steps as diagnostic
  related information.
- Show different severities based on the CodeChecker severity level.
- Refactoring the code.
@csordasmarton csordasmarton force-pushed the fix_diagnostics_in_problems_panel branch from 6781ad8 to 425894f Compare February 14, 2022 11:21
@csordasmarton
Copy link
Contributor Author

As we discussed this on a meeting we will remove bug steps from the Problems pane and I created an issue (#88) to highlight bug step ranges in the editor different way if it's supported.

Copy link
Collaborator

@Discookie Discookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Discookie Discookie merged commit 2e45395 into Ericsson:main Feb 14, 2022
@csordasmarton csordasmarton modified the milestones: 1.3.0, 1.2.0 Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug steps inserted to the wrong level in the problems tree
2 participants